fix(ledger): use a named type for credential hash (#962)

wolf31o2 · web-flow · commit 63be43cc8831 · 2025-03-23T22:25:43.000-04:00
Signed-off-by: Chris Gianelloni &lt;wolf31o2@blinklabs.io&gt;
diff --git a/internal/test/ledger/ledger.go b/internal/test/ledger/ledger.go
@@ -51,7 +51,11 @@ func (ls MockLedgerState) StakeRegistration(
 ) ([]common.StakeRegistrationCertificate, error) {
 	ret := []common.StakeRegistrationCertificate{}
 	for _, cert := range ls.MockStakeRegistration {
-		if string(cert.StakeRegistration.Credential) == string(stakingKey) {
+		if string(
+			common.Blake2b224(cert.StakeRegistration.Credential).Bytes(),
+		) == string(
+			stakingKey,
+		) {
 			ret = append(ret, cert)
 		}
 	}
diff --git a/ledger/common/credentials.go b/ledger/common/credentials.go
@@ -27,11 +27,13 @@ const (
 	CredentialTypeScriptHash  = 1
 )
 
+type CredentialHash Blake2b224
+
 type Credential struct {
 	cbor.StructAsArray
 	cbor.DecodeStoreCbor
 	CredType   uint
-	Credential []byte
+	Credential CredentialHash
 }
 
 func (c *Credential) UnmarshalCBOR(data []byte) error {

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,11 @@ func (ls MockLedgerState) StakeRegistration(`
`51`	`51`	`) ([]common.StakeRegistrationCertificate, error) {`
`52`	`52`	`ret := []common.StakeRegistrationCertificate{}`
`53`	`53`	`for _, cert := range ls.MockStakeRegistration {`
`54`		`- if string(cert.StakeRegistration.Credential) == string(stakingKey) {`
	`54`	`+ if string(`
	`55`	`+ common.Blake2b224(cert.StakeRegistration.Credential).Bytes(),`
	`56`	`+ ) == string(`
	`57`	`+ stakingKey,`
	`58`	`+ ) {`
`55`	`59`	`ret = append(ret, cert)`
`56`	`60`	`}`
`57`	`61`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,11 +27,13 @@ const (`
`27`	`27`	`CredentialTypeScriptHash = 1`
`28`	`28`	`)`
`29`	`29`
	`30`	`+type CredentialHash Blake2b224`
	`31`	`+`
`30`	`32`	`type Credential struct {`
`31`	`33`	`cbor.StructAsArray`
`32`	`34`	`cbor.DecodeStoreCbor`
`33`	`35`	`CredType uint`
`34`		`- Credential []byte`
	`36`	`+ Credential CredentialHash`
`35`	`37`	`}`
`36`	`38`
`37`	`39`	`func (c *Credential) UnmarshalCBOR(data []byte) error {`