fix(lint): avoid string concat in loop (#1218)

Signed-off-by: Chris Gianelloni <[email protected]>

Author: wolf31o2

cbor/value.go

@@ -211,19 +211,20 @@ func generateAstJson(obj any) ([]byte, error) {
 }
 
 func generateAstJsonList[T []any | Set](v T) ([]byte, error) {
-	tmpJson := `{"list":[`
+	var sb strings.Builder
+	sb.WriteString(`{"list":[`)
 	for idx, val := range v {
 		tmpVal, err := generateAstJson(val)
 		if err != nil {
 			return nil, err
 		}
-		tmpJson += string(tmpVal)
+		sb.WriteString(string(tmpVal))
 		if idx != (len(v) - 1) {
-			tmpJson += `,`
+			sb.WriteString(`,`)
 		}
 	}
-	tmpJson += `]}`
-	return []byte(tmpJson), nil
+	sb.WriteString(`]}`)
+	return []byte(sb.String()), nil
 }
 
 func generateAstJsonMap[T map[any]any | Map](v T) ([]byte, error) {
@@ -343,7 +344,8 @@ func (c Constructor) MarshalCBOR() ([]byte, error) {
 }
 
 func (v Constructor) MarshalJSON() ([]byte, error) {
-	tmpJson := fmt.Sprintf(`{"constructor":%d,"fields":[`, v.constructor)
+	var sb strings.Builder
+	sb.WriteString(fmt.Sprintf(`{"constructor":%d,"fields":[`, v.constructor))
 	tmpList := [][]byte{}
 	for _, val := range v.value.Value().([]any) {
 		tmpVal, err := generateAstJson(val)
@@ -353,13 +355,13 @@ func (v Constructor) MarshalJSON() ([]byte, error) {
 		tmpList = append(tmpList, tmpVal)
 	}
 	for idx, val := range tmpList {
-		tmpJson += string(val)
+		sb.WriteString(string(val))
 		if idx != (len(tmpList) - 1) {
-			tmpJson += `,`
+			sb.WriteString(`,`)
 		}
 	}
-	tmpJson += `]}`
-	return []byte(tmpJson), nil
+	sb.WriteString(`]}`)
+	return []byte(sb.String()), nil
 }
 
 type LazyValue struct {

ledger/error.go

@@ -17,6 +17,8 @@ package ledger
 import (
 	"errors"
 	"fmt"
+	"strconv"
+	"strings"
 
 	"github.com/blinklabs-io/gouroboros/cbor"
 )
@@ -196,15 +198,16 @@ func (e *ApplyTxError) UnmarshalCBOR(data []byte) error {
 }
 
 func (e *ApplyTxError) Error() string {
-	ret := "ApplyTxError (["
+	var sb strings.Builder
+	sb.WriteString("ApplyTxError ([")
 	for idx, failure := range e.Failures {
-		ret = fmt.Sprintf("%s%s", ret, failure)
+		sb.WriteString(failure.Error())
 		if idx < (len(e.Failures) - 1) {
-			ret = ret + ", "
+			sb.WriteString(", ")
 		}
 	}
-	ret = ret + "])"
-	return ret
+	sb.WriteString("])")
+	return sb.String()
 }
 
 type UtxowFailure struct {
@@ -311,15 +314,16 @@ type BadInputsUtxo struct {
 }
 
 func (e *BadInputsUtxo) Error() string {
-	ret := "BadInputsUtxo (["
+	var sb strings.Builder
+	sb.WriteString("BadInputsUtxo ([")
 	for idx, input := range e.Inputs {
-		ret = fmt.Sprintf("%s%s", ret, input.String())
+		sb.WriteString(input.String())
 		if idx < (len(e.Inputs) - 1) {
-			ret = ret + ", "
+			sb.WriteString(", ")
 		}
 	}
-	ret = ret + "])"
-	return ret
+	sb.WriteString("])")
+	return sb.String()
 }
 
 type TxIn struct {
@@ -404,15 +408,16 @@ type OutputTooSmallUtxo struct {
 }
 
 func (e *OutputTooSmallUtxo) Error() string {
-	ret := "OutputTooSmallUtxo (["
+	var sb strings.Builder
+	sb.WriteString("OutputTooSmallUtxo ([")
 	for idx, output := range e.Outputs {
-		ret = fmt.Sprintf("%s%s", ret, output.String())
+		sb.WriteString(output.String())
 		if idx < (len(e.Outputs) - 1) {
-			ret = ret + ", "
+			sb.WriteString(", ")
 		}
 	}
-	ret = ret + "])"
-	return ret
+	sb.WriteString("])")
+	return sb.String()
 }
 
 type TxOut struct {
@@ -466,15 +471,16 @@ type OutputBootAddrAttrsTooBig struct {
 }
 
 func (e *OutputBootAddrAttrsTooBig) Error() string {
-	ret := "OutputBootAddrAttrsTooBig (["
+	var sb strings.Builder
+	sb.WriteString("OutputBootAddrAttrsTooBig ([")
 	for idx, output := range e.Outputs {
-		ret = fmt.Sprintf("%s%s", ret, output.String())
+		sb.WriteString(output.String())
 		if idx < (len(e.Outputs) - 1) {
-			ret = ret + ", "
+			sb.WriteString(", ")
 		}
 	}
-	ret = ret + "])"
-	return ret
+	sb.WriteString("])")
+	return sb.String()
 }
 
 type TriesToForgeADA struct {
@@ -495,21 +501,22 @@ type OutputTooBigUtxo struct {
 }
 
 func (e *OutputTooBigUtxo) Error() string {
-	ret := "OutputTooBigUtxo (["
+	var sb strings.Builder
+	sb.WriteString("OutputTooBigUtxo ([")
 	for idx, output := range e.Outputs {
-		ret = fmt.Sprintf(
-			"%s(ActualSize %d, MaxSize %d, Output (%s))",
-			ret,
-			output.ActualSize,
-			output.MaxSize,
-			output.Output.String(),
-		)
+		sb.WriteString("(ActualSize ")
+		sb.WriteString(strconv.Itoa(output.ActualSize))
+		sb.WriteString(", MaxSize ")
+		sb.WriteString(strconv.Itoa(output.MaxSize))
+		sb.WriteString(", Output (")
+		sb.WriteString(output.Output.String())
+		sb.WriteString("))")
 		if idx < (len(e.Outputs) - 1) {
-			ret = ret + ", "
+			sb.WriteString(", ")
 		}
 	}
-	ret = ret + "])"
-	return ret
+	sb.WriteString("])")
+	return sb.String()
 }
 
 type InsufficientCollateral struct {