chore(golangci-lint): enable format, import, and unused presets; disable depguard (#950)

Signed-off-by: Chris Gianelloni <[email protected]>

Author: wolf31o2

.golangci.yml

@@ -4,6 +4,11 @@ issues:
   max-issues-per-linter: 0
   max-same-issues: 0
 linters:
+  disable:
+    - asasalint
+    - depguard
+    - recvcheck
+    - unparam
   enable:
     - errcheck
     - gosimple
@@ -12,12 +17,15 @@ linters:
     - staticcheck
     - unused
     # Defaults above ours below
-  disable:
-    - asasalint
-    - recvcheck
+    - copyloopvar
+    - usestdlibvars
+    - whitespace
   presets:
     - bugs
+    - format
+    - import
     - performance
+    - unused
 #linters-settings:
 #  errcheck:
 #    check-type-assertions: true

cbor/cbor.go

@@ -36,8 +36,10 @@ const (
 type RawMessage = _cbor.RawMessage
 
 // Alias for Tag for convenience
-type Tag = _cbor.Tag
-type RawTag = _cbor.RawTag
+type (
+	Tag    = _cbor.Tag
+	RawTag = _cbor.RawTag
+)
 
 // Useful for embedding and easier to remember
 type StructAsArray struct {

cbor/decode.go

@@ -115,8 +115,10 @@ func DecodeById(
 	return ret, nil
 }
 
-var decodeGenericTypeCache = map[reflect.Type]reflect.Type{}
-var decodeGenericTypeCacheMutex sync.RWMutex
+var (
+	decodeGenericTypeCache      = map[reflect.Type]reflect.Type{}
+	decodeGenericTypeCacheMutex sync.RWMutex
+)
 
 // DecodeGeneric decodes the specified CBOR into the destination object without using the
 // destination object's UnmarshalCBOR() function

cbor/encode.go

@@ -39,8 +39,10 @@ func Encode(data interface{}) ([]byte, error) {
 	return buf.Bytes(), err
 }
 
-var encodeGenericTypeCache = map[reflect.Type]reflect.Type{}
-var encodeGenericTypeCacheMutex sync.RWMutex
+var (
+	encodeGenericTypeCache      = map[reflect.Type]reflect.Type{}
+	encodeGenericTypeCacheMutex sync.RWMutex
+)
 
 // EncodeGeneric encodes the specified object to CBOR without using the source object's
 // MarshalCBOR() function

cbor/value.go

@@ -248,7 +248,6 @@ func generateAstJsonMap[T map[any]any | Map](v T) ([]byte, error) {
 		strings.Join(tmpItems, ","),
 	)
 	return []byte(tmpJson), nil
-
 }
 
 type Constructor struct {

cmd/gouroboros/mem_usage.go

@@ -19,14 +19,13 @@ import (
 	"fmt"
 	"log"
 	"net/http"
+	// #nosec G108
+	_ "net/http/pprof"
 	"os"
 	"runtime"
 	"runtime/pprof"
 	"time"
 
-	// #nosec G108
-	_ "net/http/pprof"
-
 	ouroboros "github.com/blinklabs-io/gouroboros"
 )
 

cmd/gouroboros/server.go

@@ -26,14 +26,14 @@ import (
 
 type serverFlags struct {
 	flagset *flag.FlagSet
-	//txFile  string
+	// txFile  string
 }
 
 func newServerFlags() *serverFlags {
 	f := &serverFlags{
 		flagset: flag.NewFlagSet("server", flag.ExitOnError),
 	}
-	//f.flagset.StringVar(&f.txFile, "tx-file", "", "path to the transaction file to submit")
+	// f.flagset.StringVar(&f.txFile, "tx-file", "", "path to the transaction file to submit")
 	return f
 }
 

cmd/tx-submission/main.go

@@ -33,10 +33,12 @@ type txSubmissionFlags struct {
 	rawTxFile string
 }
 
-var txBytes []byte
-var txHash [32]byte
-var sentTx bool
-var doneChan chan any
+var (
+	txBytes  []byte
+	txHash   [32]byte
+	sentTx   bool
+	doneChan chan any
+)
 
 func main() {
 	// Parse commandline

ledger/allegra.go

@@ -20,11 +20,13 @@ import "github.com/blinklabs-io/gouroboros/ledger/allegra"
 // to keep existing code working after a refactor of the ledger package
 
 // Allegra types
-type AllegraBlock = allegra.AllegraBlock
-type AllegraTransaction = allegra.AllegraTransaction
-type AllegraTransactionBody = allegra.AllegraTransactionBody
-type AllegraProtocolParameters = allegra.AllegraProtocolParameters
-type AllegraProtocolParameterUpdate = allegra.AllegraProtocolParameterUpdate
+type (
+	AllegraBlock                   = allegra.AllegraBlock
+	AllegraTransaction             = allegra.AllegraTransaction
+	AllegraTransactionBody         = allegra.AllegraTransactionBody
+	AllegraProtocolParameters      = allegra.AllegraProtocolParameters
+	AllegraProtocolParameterUpdate = allegra.AllegraProtocolParameterUpdate
+)
 
 // Allegra constants
 const (

ledger/allegra/allegra.go

@@ -21,7 +21,6 @@ import (
 	"github.com/blinklabs-io/gouroboros/cbor"
 	"github.com/blinklabs-io/gouroboros/ledger/common"
 	"github.com/blinklabs-io/gouroboros/ledger/shelley"
-
 	utxorpc "github.com/utxorpc/go-codegen/utxorpc/v1alpha/cardano"
 )
 
@@ -36,12 +35,10 @@ const (
 	TxTypeAllegra = 2
 )
 
-var (
-	EraAllegra = common.Era{
-		Id:   EraIdAllegra,
-		Name: EraNameAllegra,
-	}
-)
+var EraAllegra = common.Era{
+	Id:   EraIdAllegra,
+	Name: EraNameAllegra,
+}
 
 func init() {
 	common.RegisterEra(EraAllegra)