fix: use correct comparison for bounds check in localtxmonitor (#809)

agaffney · web-flow · commit 71842b50af86 · 2024-12-27T08:43:05.000-06:00
diff --git a/protocol/localtxmonitor/server.go b/protocol/localtxmonitor/server.go
@@ -185,7 +185,7 @@ func (s *Server) handleNextTx() error {
 			"role", "server",
 			"connection_id", s.callbackContext.ConnectionId.String(),
 		)
-	if s.mempoolNextTxIdx > len(s.mempoolTxs) {
+	if s.mempoolNextTxIdx >= len(s.mempoolTxs) {
 		newMsg := NewMsgReplyNextTx(0, nil)
 		if err := s.SendMessage(newMsg); err != nil {
 			return err

Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ func (s *Server) handleNextTx() error {`
`185`	`185`	`"role", "server",`
`186`	`186`	`"connection_id", s.callbackContext.ConnectionId.String(),`
`187`	`187`	`)`
`188`		`- if s.mempoolNextTxIdx > len(s.mempoolTxs) {`
	`188`	`+ if s.mempoolNextTxIdx >= len(s.mempoolTxs) {`
`189`	`189`	`newMsg := NewMsgReplyNextTx(0, nil)`
`190`	`190`	`if err := s.SendMessage(newMsg); err != nil {`
`191`	`191`	`return err`