fix: guard against a nil roll forward message (#790)

wolf31o2 · web-flow · commit a307899fd802 · 2024-11-14T17:00:09.000-05:00
Signed-off-by: Chris Gianelloni &lt;wolf31o2@blinklabs.io&gt;
diff --git a/protocol/chainsync/server.go b/protocol/chainsync/server.go
@@ -135,6 +135,17 @@ func (s *Server) RollForward(blockType uint, blockData []byte, tip Tip) error {
 			blockData,
 			tip,
 		)
+		if msg == nil {
+			s.Protocol.Logger().
+				Error(
+					"failed to create roll forward message",
+					"component", "network",
+					"protocol", ProtocolName,
+					"role", "server",
+					"connection_id", s.callbackContext.ConnectionId.String(),
+				)
+			return fmt.Errorf("failed to create roll forward message")
+		}
 		return s.SendMessage(msg)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -135,6 +135,17 @@ func (s *Server) RollForward(blockType uint, blockData []byte, tip Tip) error {`
`135`	`135`	`blockData,`
`136`	`136`	`tip,`
`137`	`137`	`)`
	`138`	`+ if msg == nil {`
	`139`	`+ s.Protocol.Logger().`
	`140`	`+ Error(`
	`141`	`+ "failed to create roll forward message",`
	`142`	`+ "component", "network",`
	`143`	`+ "protocol", ProtocolName,`
	`144`	`+ "role", "server",`
	`145`	`+ "connection_id", s.callbackContext.ConnectionId.String(),`
	`146`	`+ )`
	`147`	`+ return fmt.Errorf("failed to create roll forward message")`
	`148`	`+ }`
`138`	`149`	`return s.SendMessage(msg)`
`139`	`150`	`}`
`140`	`151`	`}`