fix: Address plutus data structure (#1121)

Signed-off-by: Aurora Gaffney <[email protected]>

Author: agaffney

ledger/alonzo/alonzo_test.go

@@ -42,13 +42,10 @@ func TestAlonzoTransactionOutputToPlutusDataCoinOnly(t *testing.T) {
 			0,
 			data.NewConstr(
 				0,
-				data.NewConstr(
-					0,
-					data.NewByteString(
-						[]byte{
-							0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
-						},
-					),
+				data.NewByteString(
+					[]byte{
+						0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
+					},
 				),
 			),
 			data.NewConstr(
@@ -109,13 +106,10 @@ func TestAlonzoTransactionOutputToPlutusDataCoinAssets(t *testing.T) {
 			0,
 			data.NewConstr(
 				0,
-				data.NewConstr(
-					0,
-					data.NewByteString(
-						[]byte{
-							0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
-						},
-					),
+				data.NewByteString(
+					[]byte{
+						0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
+					},
 				),
 			),
 			data.NewConstr(

ledger/babbage/babbage_test.go

@@ -2824,13 +2824,10 @@ func TestBabbageTransactionOutputToPlutusDataCoinOnly(t *testing.T) {
 			0,
 			data.NewConstr(
 				0,
-				data.NewConstr(
-					0,
-					data.NewByteString(
-						[]byte{
-							0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
-						},
-					),
+				data.NewByteString(
+					[]byte{
+						0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
+					},
 				),
 			),
 			data.NewConstr(
@@ -2891,13 +2888,10 @@ func TestBabbageTransactionOutputToPlutusDataCoinAssets(t *testing.T) {
 			0,
 			data.NewConstr(
 				0,
-				data.NewConstr(
-					0,
-					data.NewByteString(
-						[]byte{
-							0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
-						},
-					),
+				data.NewByteString(
+					[]byte{
+						0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
+					},
 				),
 			),
 			data.NewConstr(

ledger/common/address.go

@@ -295,22 +295,14 @@ func (a *Address) ToPlutusData() data.PlutusData {
 	var paymentPd data.PlutusData
 	switch a.addressType {
 	case AddressTypeKeyKey, AddressTypeKeyScript, AddressTypeKeyPointer, AddressTypeKeyNone:
-		tmpCred := &Credential{
-			CredType:   CredentialTypeAddrKeyHash,
-			Credential: NewBlake2b224(a.paymentAddress),
-		}
 		paymentPd = data.NewConstr(
 			0,
-			tmpCred.ToPlutusData(),
+			data.NewByteString(a.paymentAddress),
 		)
 	case AddressTypeScriptKey, AddressTypeScriptScript, AddressTypeScriptPointer, AddressTypeScriptNone:
-		tmpCred := &Credential{
-			CredType:   CredentialTypeScriptHash,
-			Credential: NewBlake2b224(a.paymentAddress),
-		}
 		paymentPd = data.NewConstr(
 			1,
-			tmpCred.ToPlutusData(),
+			data.NewByteString(a.paymentAddress),
 		)
 	default:
 		return nil

ledger/common/address_test.go

@@ -339,13 +339,10 @@ func TestAddressToPlutusData(t *testing.T) {
 				0,
 				data.NewConstr(
 					0,
-					data.NewConstr(
-						0,
-						data.NewByteString(
-							[]byte{
-								0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
-							},
-						),
+					data.NewByteString(
+						[]byte{
+							0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11, 0x11,
+						},
 					),
 				),
 				data.NewConstr(