fix: use LazyValue for metadata to avoid decoding issues (#638)

agaffney · web-flow · commit e7f2e2eece15 · 2024-05-17T07:10:45.000-05:00
The TX metadata isn't guaranteed to be well-formed, so we don't decode
it immediately
diff --git a/ledger/allegra.go b/ledger/allegra.go
@@ -39,7 +39,7 @@ type AllegraBlock struct {
 	Header                 *AllegraBlockHeader
 	TransactionBodies      []AllegraTransactionBody
 	TransactionWitnessSets []ShelleyTransactionWitnessSet
-	TransactionMetadataSet map[uint]*cbor.Value
+	TransactionMetadataSet map[uint]*cbor.LazyValue
 }
 
 func (b *AllegraBlock) UnmarshalCBOR(cborData []byte) error {
@@ -135,7 +135,7 @@ type AllegraTransaction struct {
 	cbor.DecodeStoreCbor
 	Body       AllegraTransactionBody
 	WitnessSet ShelleyTransactionWitnessSet
-	TxMetadata *cbor.Value
+	TxMetadata *cbor.LazyValue
 }
 
 func (t AllegraTransaction) Hash() string {
@@ -210,7 +210,7 @@ func (t AllegraTransaction) ProposalProcedures() []ProposalProcedure {
 	return t.Body.ProposalProcedures()
 }
 
-func (t AllegraTransaction) Metadata() *cbor.Value {
+func (t AllegraTransaction) Metadata() *cbor.LazyValue {
 	return t.TxMetadata
 }
 
diff --git a/ledger/alonzo.go b/ledger/alonzo.go
@@ -40,7 +40,7 @@ type AlonzoBlock struct {
 	Header                 *AlonzoBlockHeader
 	TransactionBodies      []AlonzoTransactionBody
 	TransactionWitnessSets []AlonzoTransactionWitnessSet
-	TransactionMetadataSet map[uint]*cbor.Value
+	TransactionMetadataSet map[uint]*cbor.LazyValue
 	InvalidTransactions    []uint
 }
 
@@ -249,7 +249,7 @@ type AlonzoTransaction struct {
 	Body       AlonzoTransactionBody
 	WitnessSet AlonzoTransactionWitnessSet
 	IsTxValid  bool
-	TxMetadata *cbor.Value
+	TxMetadata *cbor.LazyValue
 }
 
 func (t AlonzoTransaction) Hash() string {
@@ -324,7 +324,7 @@ func (t AlonzoTransaction) ProposalProcedures() []ProposalProcedure {
 	return t.Body.ProposalProcedures()
 }
 
-func (t AlonzoTransaction) Metadata() *cbor.Value {
+func (t AlonzoTransaction) Metadata() *cbor.LazyValue {
 	return t.TxMetadata
 }
 
diff --git a/ledger/babbage.go b/ledger/babbage.go
@@ -40,7 +40,7 @@ type BabbageBlock struct {
 	Header                 *BabbageBlockHeader
 	TransactionBodies      []BabbageTransactionBody
 	TransactionWitnessSets []BabbageTransactionWitnessSet
-	TransactionMetadataSet map[uint]*cbor.Value
+	TransactionMetadataSet map[uint]*cbor.LazyValue
 	InvalidTransactions    []uint
 }
 
@@ -417,7 +417,7 @@ type BabbageTransaction struct {
 	Body       BabbageTransactionBody
 	WitnessSet BabbageTransactionWitnessSet
 	IsTxValid  bool
-	TxMetadata *cbor.Value
+	TxMetadata *cbor.LazyValue
 }
 
 func (t BabbageTransaction) Hash() string {
@@ -492,7 +492,7 @@ func (t BabbageTransaction) ProposalProcedures() []ProposalProcedure {
 	return t.Body.ProposalProcedures()
 }
 
-func (t BabbageTransaction) Metadata() *cbor.Value {
+func (t BabbageTransaction) Metadata() *cbor.LazyValue {
 	return t.TxMetadata
 }
 
diff --git a/ledger/byron.go b/ledger/byron.go
@@ -126,7 +126,7 @@ type ByronTransaction struct {
 	hash       string
 	TxInputs   []ByronTransactionInput
 	TxOutputs  []ByronTransactionOutput
-	Attributes *cbor.Value
+	Attributes *cbor.LazyValue
 }
 
 func (t *ByronTransaction) UnmarshalCBOR(data []byte) error {
@@ -235,7 +235,7 @@ func (t *ByronTransaction) ProposalProcedures() []ProposalProcedure {
 	return nil
 }
 
-func (t *ByronTransaction) Metadata() *cbor.Value {
+func (t *ByronTransaction) Metadata() *cbor.LazyValue {
 	return t.Attributes
 }
 
diff --git a/ledger/conway.go b/ledger/conway.go
@@ -39,7 +39,7 @@ type ConwayBlock struct {
 	Header                 *ConwayBlockHeader
 	TransactionBodies      []ConwayTransactionBody
 	TransactionWitnessSets []BabbageTransactionWitnessSet
-	TransactionMetadataSet map[uint]*cbor.Value
+	TransactionMetadataSet map[uint]*cbor.LazyValue
 	InvalidTransactions    []uint
 }
 
@@ -322,7 +322,7 @@ type ConwayTransaction struct {
 	Body       ConwayTransactionBody
 	WitnessSet BabbageTransactionWitnessSet
 	IsTxValid  bool
-	TxMetadata *cbor.Value
+	TxMetadata *cbor.LazyValue
 }
 
 func (t ConwayTransaction) Hash() string {
@@ -397,7 +397,7 @@ func (t ConwayTransaction) ProposalProcedures() []ProposalProcedure {
 	return t.Body.ProposalProcedures()
 }
 
-func (t ConwayTransaction) Metadata() *cbor.Value {
+func (t ConwayTransaction) Metadata() *cbor.LazyValue {
 	return t.TxMetadata
 }
 
diff --git a/ledger/mary.go b/ledger/mary.go
@@ -40,7 +40,7 @@ type MaryBlock struct {
 	Header                 *MaryBlockHeader
 	TransactionBodies      []MaryTransactionBody
 	TransactionWitnessSets []MaryTransactionWitnessSet
-	TransactionMetadataSet map[uint]*cbor.Value
+	TransactionMetadataSet map[uint]*cbor.LazyValue
 }
 
 func (b *MaryBlock) UnmarshalCBOR(cborData []byte) error {
@@ -146,7 +146,7 @@ type MaryTransaction struct {
 	cbor.DecodeStoreCbor
 	Body       MaryTransactionBody
 	WitnessSet MaryTransactionWitnessSet
-	TxMetadata *cbor.Value
+	TxMetadata *cbor.LazyValue
 }
 
 type MaryTransactionWitnessSet struct {
@@ -227,7 +227,7 @@ func (t MaryTransaction) ProposalProcedures() []ProposalProcedure {
 	return t.Body.ProposalProcedures()
 }
 
-func (t MaryTransaction) Metadata() *cbor.Value {
+func (t MaryTransaction) Metadata() *cbor.LazyValue {
 	return t.TxMetadata
 }
 
diff --git a/ledger/shelley.go b/ledger/shelley.go
@@ -39,7 +39,7 @@ type ShelleyBlock struct {
 	Header                 *ShelleyBlockHeader
 	TransactionBodies      []ShelleyTransactionBody
 	TransactionWitnessSets []ShelleyTransactionWitnessSet
-	TransactionMetadataSet map[uint]*cbor.Value
+	TransactionMetadataSet map[uint]*cbor.LazyValue
 }
 
 func (b *ShelleyBlock) UnmarshalCBOR(cborData []byte) error {
@@ -389,7 +389,7 @@ type ShelleyTransaction struct {
 	cbor.DecodeStoreCbor
 	Body       ShelleyTransactionBody
 	WitnessSet ShelleyTransactionWitnessSet
-	TxMetadata *cbor.Value
+	TxMetadata *cbor.LazyValue
 }
 
 func (t ShelleyTransaction) Hash() string {
@@ -464,7 +464,7 @@ func (t ShelleyTransaction) ProposalProcedures() []ProposalProcedure {
 	return t.Body.ProposalProcedures()
 }
 
-func (t ShelleyTransaction) Metadata() *cbor.Value {
+func (t ShelleyTransaction) Metadata() *cbor.LazyValue {
 	return t.TxMetadata
 }
 
diff --git a/ledger/tx.go b/ledger/tx.go
@@ -26,7 +26,7 @@ import (
 
 type Transaction interface {
 	TransactionBody
-	Metadata() *cbor.Value
+	Metadata() *cbor.LazyValue
 	IsValid() bool
 	Consumed() []TransactionInput
 	Produced() []TransactionOutput

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ type AllegraBlock struct {`
`39`	`39`	`Header *AllegraBlockHeader`
`40`	`40`	`TransactionBodies []AllegraTransactionBody`
`41`	`41`	`TransactionWitnessSets []ShelleyTransactionWitnessSet`
`42`		`- TransactionMetadataSet map[uint]*cbor.Value`
	`42`	`+ TransactionMetadataSet map[uint]*cbor.LazyValue`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`func (b *AllegraBlock) UnmarshalCBOR(cborData []byte) error {`
`@@ -135,7 +135,7 @@ type AllegraTransaction struct {`
`135`	`135`	`cbor.DecodeStoreCbor`
`136`	`136`	`Body AllegraTransactionBody`
`137`	`137`	`WitnessSet ShelleyTransactionWitnessSet`
`138`		`- TxMetadata *cbor.Value`
	`138`	`+ TxMetadata *cbor.LazyValue`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`func (t AllegraTransaction) Hash() string {`
`@@ -210,7 +210,7 @@ func (t AllegraTransaction) ProposalProcedures() []ProposalProcedure {`
`210`	`210`	`return t.Body.ProposalProcedures()`
`211`	`211`	`}`
`212`	`212`
`213`		`-func (t AllegraTransaction) Metadata() *cbor.Value {`
	`213`	`+func (t AllegraTransaction) Metadata() *cbor.LazyValue {`
`214`	`214`	`return t.TxMetadata`
`215`	`215`	`}`
`216`	`216`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ type AlonzoBlock struct {`
`40`	`40`	`Header *AlonzoBlockHeader`
`41`	`41`	`TransactionBodies []AlonzoTransactionBody`
`42`	`42`	`TransactionWitnessSets []AlonzoTransactionWitnessSet`
`43`		`- TransactionMetadataSet map[uint]*cbor.Value`
	`43`	`+ TransactionMetadataSet map[uint]*cbor.LazyValue`
`44`	`44`	`InvalidTransactions []uint`
`45`	`45`	`}`
`46`	`46`
`@@ -249,7 +249,7 @@ type AlonzoTransaction struct {`
`249`	`249`	`Body AlonzoTransactionBody`
`250`	`250`	`WitnessSet AlonzoTransactionWitnessSet`
`251`	`251`	`IsTxValid bool`
`252`		`- TxMetadata *cbor.Value`
	`252`	`+ TxMetadata *cbor.LazyValue`
`253`	`253`	`}`
`254`	`254`
`255`	`255`	`func (t AlonzoTransaction) Hash() string {`
`@@ -324,7 +324,7 @@ func (t AlonzoTransaction) ProposalProcedures() []ProposalProcedure {`
`324`	`324`	`return t.Body.ProposalProcedures()`
`325`	`325`	`}`
`326`	`326`
`327`		`-func (t AlonzoTransaction) Metadata() *cbor.Value {`
	`327`	`+func (t AlonzoTransaction) Metadata() *cbor.LazyValue {`
`328`	`328`	`return t.TxMetadata`
`329`	`329`	`}`
`330`	`330`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ type BabbageBlock struct {`
`40`	`40`	`Header *BabbageBlockHeader`
`41`	`41`	`TransactionBodies []BabbageTransactionBody`
`42`	`42`	`TransactionWitnessSets []BabbageTransactionWitnessSet`
`43`		`- TransactionMetadataSet map[uint]*cbor.Value`
	`43`	`+ TransactionMetadataSet map[uint]*cbor.LazyValue`
`44`	`44`	`InvalidTransactions []uint`
`45`	`45`	`}`
`46`	`46`
`@@ -417,7 +417,7 @@ type BabbageTransaction struct {`
`417`	`417`	`Body BabbageTransactionBody`
`418`	`418`	`WitnessSet BabbageTransactionWitnessSet`
`419`	`419`	`IsTxValid bool`
`420`		`- TxMetadata *cbor.Value`
	`420`	`+ TxMetadata *cbor.LazyValue`
`421`	`421`	`}`
`422`	`422`
`423`	`423`	`func (t BabbageTransaction) Hash() string {`
`@@ -492,7 +492,7 @@ func (t BabbageTransaction) ProposalProcedures() []ProposalProcedure {`
`492`	`492`	`return t.Body.ProposalProcedures()`
`493`	`493`	`}`
`494`	`494`
`495`		`-func (t BabbageTransaction) Metadata() *cbor.Value {`
	`495`	`+func (t BabbageTransaction) Metadata() *cbor.LazyValue {`
`496`	`496`	`return t.TxMetadata`
`497`	`497`	`}`
`498`	`498`
Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ type ByronTransaction struct {`
`126`	`126`	`hash string`
`127`	`127`	`TxInputs []ByronTransactionInput`
`128`	`128`	`TxOutputs []ByronTransactionOutput`
`129`		`- Attributes *cbor.Value`
	`129`	`+ Attributes *cbor.LazyValue`
`130`	`130`	`}`
`131`	`131`
`132`	`132`	`func (t *ByronTransaction) UnmarshalCBOR(data []byte) error {`
`@@ -235,7 +235,7 @@ func (t *ByronTransaction) ProposalProcedures() []ProposalProcedure {`
`235`	`235`	`return nil`
`236`	`236`	`}`
`237`	`237`
`238`		`-func (t ByronTransaction) Metadata() cbor.Value {`
	`238`	`+func (t ByronTransaction) Metadata() cbor.LazyValue {`
`239`	`239`	`return t.Attributes`
`240`	`240`	`}`
`241`	`241`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ type ConwayBlock struct {`
`39`	`39`	`Header *ConwayBlockHeader`
`40`	`40`	`TransactionBodies []ConwayTransactionBody`
`41`	`41`	`TransactionWitnessSets []BabbageTransactionWitnessSet`
`42`		`- TransactionMetadataSet map[uint]*cbor.Value`
	`42`	`+ TransactionMetadataSet map[uint]*cbor.LazyValue`
`43`	`43`	`InvalidTransactions []uint`
`44`	`44`	`}`
`45`	`45`
`@@ -322,7 +322,7 @@ type ConwayTransaction struct {`
`322`	`322`	`Body ConwayTransactionBody`
`323`	`323`	`WitnessSet BabbageTransactionWitnessSet`
`324`	`324`	`IsTxValid bool`
`325`		`- TxMetadata *cbor.Value`
	`325`	`+ TxMetadata *cbor.LazyValue`
`326`	`326`	`}`
`327`	`327`
`328`	`328`	`func (t ConwayTransaction) Hash() string {`
`@@ -397,7 +397,7 @@ func (t ConwayTransaction) ProposalProcedures() []ProposalProcedure {`
`397`	`397`	`return t.Body.ProposalProcedures()`
`398`	`398`	`}`
`399`	`399`
`400`		`-func (t ConwayTransaction) Metadata() *cbor.Value {`
	`400`	`+func (t ConwayTransaction) Metadata() *cbor.LazyValue {`
`401`	`401`	`return t.TxMetadata`
`402`	`402`	`}`
`403`	`403`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ type MaryBlock struct {`
`40`	`40`	`Header *MaryBlockHeader`
`41`	`41`	`TransactionBodies []MaryTransactionBody`
`42`	`42`	`TransactionWitnessSets []MaryTransactionWitnessSet`
`43`		`- TransactionMetadataSet map[uint]*cbor.Value`
	`43`	`+ TransactionMetadataSet map[uint]*cbor.LazyValue`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`func (b *MaryBlock) UnmarshalCBOR(cborData []byte) error {`
`@@ -146,7 +146,7 @@ type MaryTransaction struct {`
`146`	`146`	`cbor.DecodeStoreCbor`
`147`	`147`	`Body MaryTransactionBody`
`148`	`148`	`WitnessSet MaryTransactionWitnessSet`
`149`		`- TxMetadata *cbor.Value`
	`149`	`+ TxMetadata *cbor.LazyValue`
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`type MaryTransactionWitnessSet struct {`
`@@ -227,7 +227,7 @@ func (t MaryTransaction) ProposalProcedures() []ProposalProcedure {`
`227`	`227`	`return t.Body.ProposalProcedures()`
`228`	`228`	`}`
`229`	`229`
`230`		`-func (t MaryTransaction) Metadata() *cbor.Value {`
	`230`	`+func (t MaryTransaction) Metadata() *cbor.LazyValue {`
`231`	`231`	`return t.TxMetadata`
`232`	`232`	`}`
`233`	`233`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ type ShelleyBlock struct {`
`39`	`39`	`Header *ShelleyBlockHeader`
`40`	`40`	`TransactionBodies []ShelleyTransactionBody`
`41`	`41`	`TransactionWitnessSets []ShelleyTransactionWitnessSet`
`42`		`- TransactionMetadataSet map[uint]*cbor.Value`
	`42`	`+ TransactionMetadataSet map[uint]*cbor.LazyValue`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`func (b *ShelleyBlock) UnmarshalCBOR(cborData []byte) error {`
`@@ -389,7 +389,7 @@ type ShelleyTransaction struct {`
`389`	`389`	`cbor.DecodeStoreCbor`
`390`	`390`	`Body ShelleyTransactionBody`
`391`	`391`	`WitnessSet ShelleyTransactionWitnessSet`
`392`		`- TxMetadata *cbor.Value`
	`392`	`+ TxMetadata *cbor.LazyValue`
`393`	`393`	`}`
`394`	`394`
`395`	`395`	`func (t ShelleyTransaction) Hash() string {`
`@@ -464,7 +464,7 @@ func (t ShelleyTransaction) ProposalProcedures() []ProposalProcedure {`
`464`	`464`	`return t.Body.ProposalProcedures()`
`465`	`465`	`}`
`466`	`466`
`467`		`-func (t ShelleyTransaction) Metadata() *cbor.Value {`
	`467`	`+func (t ShelleyTransaction) Metadata() *cbor.LazyValue {`
`468`	`468`	`return t.TxMetadata`
`469`	`469`	`}`
`470`	`470`