fix: remove muxer recv chan to prevent double close (#785)

agaffney · web-flow · commit f07ac1ab2320 · 2024-11-10T21:58:31.000-06:00
diff --git a/muxer/muxer.go b/muxer/muxer.go
@@ -245,8 +245,11 @@ func (m *Muxer) readLoop() {
 		// Close receiver channels
 		m.protocolReceiversMutex.Lock()
 		for _, protocolRoles := range m.protocolReceivers {
-			for _, recvChan := range protocolRoles {
+			for protocolRole, recvChan := range protocolRoles {
+				// Signal shutdown to protocol
 				close(recvChan)
+				// Remove mapping
+				delete(protocolRoles, protocolRole)
 			}
 		}
 		m.protocolReceiversMutex.Unlock()

Original file line number	Diff line number	Diff line change
`@@ -245,8 +245,11 @@ func (m *Muxer) readLoop() {`
`245`	`245`	`// Close receiver channels`
`246`	`246`	`m.protocolReceiversMutex.Lock()`
`247`	`247`	`for _, protocolRoles := range m.protocolReceivers {`
`248`		`- for _, recvChan := range protocolRoles {`
	`248`	`+ for protocolRole, recvChan := range protocolRoles {`
	`249`	`+ // Signal shutdown to protocol`
`249`	`250`	`close(recvChan)`
	`251`	`+ // Remove mapping`
	`252`	`+ delete(protocolRoles, protocolRole)`
`250`	`253`	`}`
`251`	`254`	`}`
`252`	`255`	`m.protocolReceiversMutex.Unlock()`