feat: support for acquire immutable tip in local-state-query #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf31o2
previously approved these changes
Dec 28, 2024
| type AcquirePoint struct { | ||
| Point *common.Point | ||
| Volatile bool | ||
| Immutable bool |
There was a problem hiding this comment.
Can it ever be neither or both? Are these completely independent from each other?
There was a problem hiding this comment.
It can only be one of them at a time. It might make a little more sense to have a "type" field to make it a bit more explicit which one it is, or even separate types for each with an interface type
There was a problem hiding this comment.
I switch this to 4 separate types, one for each acquire target type, and an interface that covers all of them for convenience.
* rename (Re)AcquireNoPoint to (Re)AcquireVolatileTip * add new messages for ImmutableTip * add client functions for acquiring volatile/immutable tip * change Acquire callback signature for immutable trip Fixes #766
agaffney
force-pushed
the
feat/localstatequery-immutable-tip
branch
from
059045e to
bf9e71b
Compare
wolf31o2
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #766