feat: close Ouroboros connection after submitting transaction

Fixes #11

Author: agaffney

Makefile

@@ -13,11 +13,14 @@ $(BINARY): $(GO_FILES)
 	go mod tidy
 	go build -o $(BINARY) ./cmd/$(BINARY)
 
-.PHONY: build image
+.PHONY: build clean image
 
 # Alias for building program binary
 build: $(BINARY)
 
+clean:
+	rm -f $(BINARY)
+
 # Build docker image
 image: build
 	docker build -t cloudstruct/$(BINARY) .

go.mod

@@ -3,7 +3,7 @@ module github.com/cloudstruct/go-cardano-submit-api
 go 1.17
 
 require (
-	github.com/cloudstruct/go-ouroboros-network v0.13.0
+	github.com/cloudstruct/go-ouroboros-network v0.13.1
 	github.com/fxamacker/cbor/v2 v2.4.0
 	github.com/gin-contrib/zap v0.0.2
 	github.com/gin-gonic/gin v1.7.7

go.sum

@@ -1,7 +1,7 @@
 github.com/benbjohnson/clock v1.1.0 h1:Q92kusRqC1XV2MjkWETPvjJVqKetz1OzxZB7mHJLju8=
 github.com/benbjohnson/clock v1.1.0/go.mod h1:J11/hYXuz8f4ySSvYwY0FKfm+ezbsZBKZxNJlLklBHA=
-github.com/cloudstruct/go-ouroboros-network v0.13.0 h1:q6l4QQocuDTz0TOynEo5jwe9R+9tCL6vLJpWdMer9kc=
-github.com/cloudstruct/go-ouroboros-network v0.13.0/go.mod h1:06ggUMerJLwKJkVi5DLX1QMDz8r+R8o92rht7Z4ss9k=
+github.com/cloudstruct/go-ouroboros-network v0.13.1 h1:/F9fXKXLmGPdMQrqyBovbTbLUZdj/7cG0qjA/a31cZk=
+github.com/cloudstruct/go-ouroboros-network v0.13.1/go.mod h1:06ggUMerJLwKJkVi5DLX1QMDz8r+R8o92rht7Z4ss9k=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=

internal/api/api.go

@@ -86,15 +86,13 @@ func handleSubmitTx(c *gin.Context) {
 			},
 		},
 	}
-	go func() {
-		err, ok := <-errorChan
-		if ok {
-			logger.Errorf("failure communicating with node: %s", err)
-			c.String(500, "failure communicating with node")
-			doneChan <- true
-		}
-	}()
 	oConn, err := ouroboros.New(oOpts)
+	defer func() {
+		// We have to close the channel to break out of the async error handler goroutine
+		close(errorChan)
+		// Close Ouroboros connection
+		oConn.Close()
+	}()
 	if err != nil {
 		logger.Errorf("failure creating Ouroboros connection: %s", err)
 		c.String(500, "failure communicating with node")
@@ -113,6 +111,15 @@ func handleSubmitTx(c *gin.Context) {
 			return
 		}
 	}
+	// Start async error handler
+	go func() {
+		err, ok := <-errorChan
+		if ok {
+			logger.Errorf("failure communicating with node: %s", err)
+			c.String(500, "failure communicating with node")
+			doneChan <- true
+		}
+	}()
 	// TODO: figure out better way to determine era
 	if err = oConn.LocalTxSubmission.SubmitTx(block.TX_TYPE_ALONZO, rawTx); err != nil {
 		logger.Errorf("failure submitting transaction: %s", err)
@@ -121,6 +128,4 @@ func handleSubmitTx(c *gin.Context) {
 	}
 	// Wait for async process to finish
 	<-doneChan
-	// We have to close the channel to break out of the Goroutine waiting on it
-	close(errorChan)
 }