Goose code quality

[GordianDziwis]

I am currently working on a pull request and I am a bit taken aback by the code style. Just for example this function: reply_internal is a few hundred lines of unreadable for loops and if statements.

Will this be refactored?

[michaelneale]

yeah almost certainly, but some of it (much!) written by agents (goose itself, claude etc) which can erro on side of followin patterns:

the nested stuff around tool calling with Some(Some etc is common to see (unfortunate). Some of us (especially) @codefromthecrypt like to rage out and rip things out from time to time (but oddly enough, core things like that don't get enough attention).

[GordianDziwis]

Guess everyone (agents included) is moving fast now. :)

Couldn't this objectively bad stuff, be caught with a review/refactor agent or maybe prevented in .goosehints?

Guidelines:

DO NOT USE mod.rs use rust 2018 modules.
Keep functions under x lines.
Do not indent more than y times.
Keep Kolmogorov complexity under z.
etc.

[codefromthecrypt]

Yeah what mic said. The challenge is moving fast and trying not to break everything. It always feels like a coin toss burn it down vs not, but what makes it fireproof is the many people working.

There is a bright side.. we have been painfully adding more and more integration tests and hardening the scenarios that must pass. This is partly quality and parlty for more options. For example, the whole CLI path will likely be burned for a centralized goose-server approach (possibly ACP based).

Knowing there is a rearch in progress makes burning and what to burn fluid questions.

I think at the moment we can try to unblock "future arch" stuff as that can let more things burn even if possibly not reply_internal ;)

Targeted burns for things like functions that are too wiley can still be interleaved with all this, just be aware you will likley have to rebase a couple times. This self selects into small or mechanical.

My rambling 2p

[GordianDziwis]

Thanks, this clears my concerns, I just wanted to know, before I commit to goose, if the code quality is a conscious tradeoff and not just neglect.

[michaelneale]

@GordianDziwis yeah it is a crazy world, we are all trying to navigate, really not sure how some days, good luck and hope you learn some stuff on the journey

[DOsinga]

reply_internal is probably the worst. refactoring it is also not easy. those if statements all cover some weird corner case. and the whole thing is doing the streaming. but yeah, we should, really.

[michaelneale]

the developer mcp was at one point 4-6k lines of rust. I heard cursor has a 70k lines single rust file!

[ekoeppen]

Slightly related, I'm more taken aback by the more than 1000 transitive dependencies and the binary size, plus the disk footprint during development. The number of dependencies is scary also for security reasons. Any thoughts on getting these numbers down?

[ekoeppen]

I think the focus on extensions is actually a great enabler to potentially trim down the footprint :)

[DOsinga]

Slightly related, I'm more taken aback by the more than 1000 transitive dependencies and the binary size,

dependencies is a weakness of AI generated code. maybe we need to add it to the projects .md's, but they really like to use some arcane library instead of reusing the existing ones. but good point, we should push against