-
Notifications
You must be signed in to change notification settings - Fork 18
Open
Labels
enhancementNew featuresNew featureshelp wantedExtra attention is neededExtra attention is neededhot taskDoubled points in the reward tableDoubled points in the reward table
Description
Refactor Request
Describe the Refactor Request
We will find the name() function being used in multiple places across the dApp to refer to the ERC20 or ERC721 token name following the Metadata.sol standard by OpenZeppelin.
But when it comes to industry standards we always use the shorten version symbol() which is limited to usually 7 characters maximum, as described in the overall trading industry.
Describe Preferred Solution
Find where name() is being used to be displayed in the dApp and change for the corresponding symbol(). It will also be used when using Alchemy SDK. The return will return both name and symbol.
Remember to also add the prefix "$" in the symbol and uppercase the letters.
Definition of Done:
- Refactor all name() usages into symbol().
- Find Alchemy SDK usage of name and change for symbol.
- Use $ as a prefix for symbol and force the letters into uppercase.
- Test the application with erc20 and erc721 that has no image to be displayed to see with the symbol was applied.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew featuresNew featureshelp wantedExtra attention is neededExtra attention is neededhot taskDoubled points in the reward tableDoubled points in the reward table
Type
Projects
Status
π TODO