Merge pull request #42 from blocknotes/test-suite-improvements

Improve data setup for specs

Author: blocknotes

spec/rails_helper.rb

@@ -37,12 +37,13 @@
 module SpecHelpers
   class << self
     def setup_data
-      Rails.application.load_seed
-      author = Author.find_by!(name: 'A test author')
-      tag = Tag.find_by!(name: 'A test tag')
-      Post.first.update!(title: 'A post', author: author, category: 'news', published: true, dt: Time.zone.today)
-      Post.second.update!(title: 'Another post', author: author, category: 'story', dt: Date.yesterday, tags: [tag])
-      Post.third.update!(title: 'Last post', author: author, category: 'news', position: 234, dt: Date.tomorrow)
+      author1 = Author.create!(name: 'First author', email: '[email protected]', age: 33)
+      author2 = Author.create!(name: 'Second author', email: '[email protected]', age: 42)
+      tag = Tag.create!(name: 'A test tag')
+      Post.create!(title: 'A post', author: author1, category: 'news', published: true, dt: Time.zone.today)
+      Post.create!(title: 'Another post', author: author1, category: 'story', dt: Date.yesterday, tags: [tag])
+      Post.create!(title: 'Last post', author: author1, category: 'news', position: 234, dt: Date.tomorrow)
+      Post.create!(title: 'More post', author: author2, category: 'gallery', dt: Date.yesterday)
     end
   end
 end
@@ -61,10 +62,6 @@ def setup_data
   config.use_instantiated_fixtures = false
   config.render_views = false
 
-  config.before(:suite) do
-    SpecHelpers.setup_data
-  end
-
   config.before(:suite) do
     require 'administrate/version'
 

spec/system/belongs_to_filter_spec.rb

@@ -1,11 +1,15 @@
 # frozen_string_literal: true
 
 RSpec.describe 'Belongs to filter' do
-  let(:author) { Author.find_by!(name: 'A test author') }
+  let(:author) { Author.find_by!(name: 'First author') }
   let(:posts) { Post.where(author: author) }
 
+  before do
+    SpecHelpers.setup_data
+  end
+
   it 'filters the posts by author', :aggregate_failures do
-    visit '/admin/posts'
+    visit admin_posts_path
 
     find('.filter-author .selectize-input').click
     find(".filter-author .option[data-value='#{author.id}']").click

spec/system/boolean_filter_spec.rb

@@ -1,18 +1,19 @@
 # frozen_string_literal: true
 
 RSpec.describe 'Boolean filter' do
-  let(:first_post) { Post.first }
-  let(:second_post) { Post.second }
+  before do
+    SpecHelpers.setup_data
+  end
 
   it 'filters the posts by published', :aggregate_failures do
-    visit '/admin/posts'
+    visit admin_posts_path
 
     find('.filter-published .selectize-input').click
     find('.filter-published .option[data-value="true"]').click
     find('input[type="submit"]').click
 
     expect(page).to have_current_path %r{/admin/posts\?.+q%5Bpublished_eq%5D=true.*}
-    expect(page).to have_css('a.action-show', text: first_post.title)
-    expect(page).not_to have_css('a.action-show', text: second_post.title)
+    expect(page).to have_css('a.action-show', text: "A post")
+    expect(page).not_to have_css('a.action-show', text: "Last post")
   end
 end

spec/system/date_filter_spec.rb

@@ -1,17 +1,19 @@
 # frozen_string_literal: true
 
 RSpec.describe 'Date filter' do
-  let(:post3) { Post.third }
+  before do
+    SpecHelpers.setup_data
+  end
 
   it 'filters the posts by date', :aggregate_failures do
-    visit '/admin/posts'
+    visit admin_posts_path
 
     date = Date.tomorrow
     fill_in('q[dt_gteq]', with: date)
     find('input[type="submit"]').click
 
     expect(page).to have_current_path %r{/admin/posts\?.+q%5Bdt_gteq%5D=#{date}.*}
     expect(page).to have_css('.js-table-row', count: 1)
-    expect(page).to have_css('.js-table-row a.action-show', text: post3.title)
+    expect(page).to have_css('.js-table-row a.action-show', text: "Last post")
   end
 end

spec/system/filters_bar_spec.rb

@@ -2,7 +2,7 @@
 
 RSpec.describe 'Filters bar' do
   it 'checks that filters bar is present (looking for some specific elements)', :aggregate_failures do
-    visit '/admin/posts'
+    visit admin_posts_path
 
     expect(page).to have_css('form#post_search')
     expect(page).to have_css('input#q_title_cont')

spec/system/has_many_filter_spec.rb

@@ -1,11 +1,14 @@
 # frozen_string_literal: true
 
 RSpec.describe 'Has many filter' do
-  let(:post2) { Post.second }
   let(:tag) { Tag.find_by!(name: 'A test tag') }
 
+  before do
+    SpecHelpers.setup_data
+  end
+
   it 'filters the posts by tag (with Selectize)', :aggregate_failures do
-    visit '/admin/posts'
+    visit admin_posts_path
 
     find('.filter-tags .selectize-input').click
     find(".filter-tags .option[data-value='#{tag.id}']").click
@@ -14,13 +17,14 @@
     expected_param = CGI.escape("q[tags_id_in][]")
     expect(page).to have_current_path %r{/admin/posts\?.+#{expected_param}=#{tag.id}}
     expect(page).to have_css('.js-table-row', count: 1)
-    expect(page).to have_css('.js-table-row a.action-show', text: post2.title)
+    expect(page).to have_css('.js-table-row a.action-show', text: "Another post")
   end
 
   it 'filters the tags by post', :aggregate_failures do
-    visit '/admin/tags'
+    visit admin_tags_path
 
-    find("#q_posts_id_in_#{post2.id}").set(true)
+    post = Post.find_by!(title: "Another post")
+    find("#q_posts_id_in_#{post.id}").set(true)
     find('input[type="submit"]').click
 
     expect(page).to have_css('.js-table-row', count: 1)

spec/system/number_filter_spec.rb

@@ -1,16 +1,18 @@
 # frozen_string_literal: true
 
 RSpec.describe 'Number filter' do
-  let(:post3) { Post.third }
+  before do
+    SpecHelpers.setup_data
+  end
 
   it 'filters the posts by position', :aggregate_failures do
-    visit '/admin/posts'
+    visit admin_posts_path
 
     fill_in('q[position_eq]', with: '234')
     find('input[type="submit"]').click
 
     expect(page).to have_current_path %r{/admin/posts\?.+q%5Bposition_eq%5D=234.*}
     expect(page).to have_css('.js-table-row', count: 1)
-    expect(page).to have_css('.js-table-row a.action-show', text: post3.title)
+    expect(page).to have_css('.js-table-row a.action-show', text: "Last post")
   end
 end

spec/system/scope_filter_spec.rb

@@ -3,8 +3,12 @@
 RSpec.describe 'Scope filter' do
   let(:posts) { Post.where(category: 'news') }
 
+  before do
+    SpecHelpers.setup_data
+  end
+
   it 'filters the posts by category (using the scope)', :aggregate_failures do
-    visit '/admin/posts'
+    visit admin_posts_path
 
     fill_in('q[by_category]', with: 'news')
     find('input[type="submit"]').click

spec/system/select_filter_spec.rb

@@ -1,17 +1,19 @@
 # frozen_string_literal: true
 
 RSpec.describe 'Select filter' do
-  let(:post2) { Post.second }
+  before do
+    SpecHelpers.setup_data
+  end
 
   it 'filters the posts by category', :aggregate_failures do
-    visit '/admin/posts'
+    visit admin_posts_path
 
     find('.filter-category .selectize-input').click
     find('.filter-category .option[data-value="story"]').click
     find('input[type="submit"]').click
 
     expect(page).to have_current_path %r{/admin/posts\?.+q%5Bcategory_eq%5D=story.*}
     expect(page).to have_css('.js-table-row', count: 1)
-    expect(page).to have_css('.js-table-row a.action-show', text: post2.title)
+    expect(page).to have_css('.js-table-row a.action-show', text: "Another post")
   end
 end

spec/system/string_filter_spec.rb

@@ -1,15 +1,18 @@
 # frozen_string_literal: true
 
 RSpec.describe 'String filter' do
-  let(:post2) { Post.second }
+  before do
+    SpecHelpers.setup_data
+  end
 
   it 'filters the posts by title', :aggregate_failures do
-    visit '/admin/posts'
+    visit admin_posts_path
 
     fill_in('q[title_cont]', with: 'another')
     find('input[type="submit"]').click
 
+    expect(page).to have_current_path %r{/admin/posts?.*q%5Btitle_cont%5D=another}
     expect(page).to have_css('.js-table-row', count: 1)
-    expect(page).to have_css('.js-table-row a.action-show', text: post2.title)
+    expect(page).to have_css('.js-table-row a.action-show', text: "Another post")
   end
 end