review and workflow fixes

Author: tom2drum

.github/workflows/checks.yml

@@ -22,6 +22,11 @@ permissions:
   contents: read
   pull-requests: write
 
+# pnpm deps: rely on actions/setup-node cache: pnpm (content-addressable store, keyed on
+# pnpm-lock.yaml). Always run pnpm install --frozen-lockfile in each job — with a warm store
+# it is mostly linking. Caching only the repo-root node_modules tarball omits workspace
+# package node_modules symlinks and breaks tsc/vite in toolkit and deploy/tools/* packages.
+
 jobs:
   code_quality:
     name: Code quality
@@ -35,29 +40,17 @@ jobs:
         uses: pnpm/action-setup@v4
         with:
           version: 10.32.1
+          cache: true
 
       - name: Setup node
         uses: actions/setup-node@v4
         with:
           node-version: 22.14.0
           cache: 'pnpm'
 
-      - name: Cache node_modules
-        uses: actions/cache@v4
-        id: cache-node-modules
-        with:
-          path: |
-            node_modules
-          key: node_modules-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }}
-
       - name: Install dependencies
-        if: steps.cache-node-modules.outputs.cache-hit != 'true'
         run: pnpm install --frozen-lockfile
 
-      - name: Generate Chakra types
-        if: steps.cache-node-modules.outputs.cache-hit == 'true'
-        run: pnpm chakra:typegen
-
       - name: Run ESLint
         run: pnpm lint:eslint
 
@@ -82,29 +75,17 @@ jobs:
         uses: pnpm/action-setup@v4
         with:
           version: 10.32.1
+          cache: true
 
       - name: Setup node
         uses: actions/setup-node@v4
         with:
           node-version: 22.14.0
           cache: 'pnpm'
 
-      - name: Cache node_modules
-        uses: actions/cache@v4
-        id: cache-node-modules
-        with:
-          path: |
-            node_modules
-          key: node_modules-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }}
-
       - name: Install project dependencies
-        if: steps.cache-node-modules.outputs.cache-hit != 'true'
         run: pnpm install --frozen-lockfile
 
-      - name: Generate Chakra types
-        if: steps.cache-node-modules.outputs.cache-hit == 'true'
-        run: pnpm chakra:typegen
-
       - name: Type check the package
         run: pnpm --filter @blockscout/ui-toolkit typecheck
 
@@ -141,36 +122,19 @@ jobs:
         uses: pnpm/action-setup@v4
         with:
           version: 10.32.1
+          cache: true
 
       - name: Setup node
         uses: actions/setup-node@v4
         with:
           node-version: 22.14.0
           cache: 'pnpm'
 
-      - name: Cache node_modules
-        uses: actions/cache@v4
-        id: cache-node-modules
-        with:
-          path: |
-            node_modules
-          key: node_modules-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }}
-
       - name: Install dependencies
-        if: steps.cache-node-modules.outputs.cache-hit != 'true'
         run: pnpm install --frozen-lockfile
 
-      - name: Generate Chakra types
-        if: steps.cache-node-modules.outputs.cache-hit == 'true'
-        run: pnpm chakra:typegen
-
       - name: Run validation tests
-        run: |
-          set +e
-          pnpm --filter envs-validator test
-          exitcode="$?"
-          echo "exitcode=$exitcode" >> $GITHUB_OUTPUT
-          exit "$exitcode"
+        run: pnpm --filter envs-validator test
 
   vitest_tests:
     name: Unit tests
@@ -186,29 +150,17 @@ jobs:
         uses: pnpm/action-setup@v4
         with:
           version: 10.32.1
+          cache: true
 
       - name: Setup node
         uses: actions/setup-node@v4
         with:
           node-version: 22.14.0
           cache: 'pnpm'
 
-      - name: Cache node_modules
-        uses: actions/cache@v4
-        id: cache-node-modules
-        with:
-          path: |
-            node_modules
-          key: node_modules-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }}
-
       - name: Install dependencies
-        if: steps.cache-node-modules.outputs.cache-hit != 'true'
         run: pnpm install --frozen-lockfile
 
-      - name: Generate Chakra types
-        if: steps.cache-node-modules.outputs.cache-hit == 'true'
-        run: pnpm chakra:typegen
-
       - name: Run Vitest
         run: pnpm test:vitest ${{ github.event_name == 'pull_request' && '--changed=origin/main' || '' }} --passWithNoTests
 
@@ -227,29 +179,17 @@ jobs:
         uses: pnpm/action-setup@v4
         with:
           version: 10.32.1
+          cache: true
 
       - name: Setup node
         uses: actions/setup-node@v4
         with:
           node-version: 22.14.0
           cache: 'pnpm'
 
-      - name: Cache node_modules
-        uses: actions/cache@v4
-        id: cache-node-modules
-        with:
-          path: |
-            node_modules
-          key: node_modules-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }}
-
       - name: Install dependencies
-        if: steps.cache-node-modules.outputs.cache-hit != 'true'
         run: pnpm install --frozen-lockfile
 
-      - name: Generate Chakra types
-        if: steps.cache-node-modules.outputs.cache-hit == 'true'
-        run: pnpm chakra:typegen
-
       - name: Run script
         run: pnpm test:pw:detect-affected
 
@@ -290,29 +230,17 @@ jobs:
         uses: pnpm/action-setup@v4
         with:
           version: 10.32.1
+          cache: true
 
       - name: Setup node
         uses: actions/setup-node@v4
         with:
           node-version: 22.14.0
           cache: 'pnpm'
 
-      - name: Cache node_modules
-        uses: actions/cache@v4
-        id: cache-node-modules
-        with:
-          path: |
-            node_modules
-          key: node_modules-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }}
-
       - name: Install dependencies
-        if: steps.cache-node-modules.outputs.cache-hit != 'true'
         run: pnpm install --frozen-lockfile
 
-      - name: Generate Chakra types
-        if: steps.cache-node-modules.outputs.cache-hit == 'true'
-        run: pnpm chakra:typegen
-
       - name: Download affected tests list
         if: ${{ needs.pw_affected_tests.result == 'success' }}
         uses: actions/download-artifact@v5
@@ -369,6 +297,7 @@ jobs:
         uses: pnpm/action-setup@v4
         with:
           version: 10.32.1
+          cache: true
 
       - name: Setup node
         if: steps.check-reports.outputs.has_reports == 'true'
@@ -377,17 +306,8 @@ jobs:
           node-version: 22.14.0
           cache: 'pnpm'
 
-      - name: Cache node_modules
-        if: steps.check-reports.outputs.has_reports == 'true'
-        uses: actions/cache@v4
-        id: cache-node-modules
-        with:
-          path: |
-            node_modules
-          key: node_modules-${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }}
-
       - name: Install dependencies
-        if: steps.check-reports.outputs.has_reports == 'true' && steps.cache-node-modules.outputs.cache-hit != 'true'
+        if: steps.check-reports.outputs.has_reports == 'true'
         run: pnpm install --frozen-lockfile
 
       - name: Merge into HTML Report

cspell.jsonc

@@ -264,6 +264,7 @@
         "VEVENT",
         "viem",
         "vitalik",
+        "vite",
         "vitest",
         "wagmi",
         "warpcast",

toolkit/components/truncation/TruncatedText.tsx

@@ -6,7 +6,8 @@ import type { ExcludeUndefined } from 'types/utils';
 
 import type { SkeletonTextProps } from '../../chakra/skeleton';
 import { Skeleton } from '../../chakra/skeleton';
-import { Tooltip, type TooltipProps } from '../../chakra/tooltip';
+import type { TooltipProps } from '../../chakra/tooltip';
+import { Tooltip } from '../../chakra/tooltip';
 import { TruncatedTextTooltip } from './TruncatedTextTooltip';
 
 export interface TruncatedTextProps extends Omit<SkeletonTextProps, 'loading'> {

toolkit/components/truncation/TruncatedTextTooltip.tsx

@@ -4,7 +4,8 @@ import useFontFaceObserver from 'use-font-face-observer';
 
 import type { ExcludeUndefined } from 'types/utils';
 
-import { Tooltip, type TooltipProps } from '../../chakra/tooltip';
+import type { TooltipProps } from '../../chakra/tooltip';
+import { Tooltip } from '../../chakra/tooltip';
 import { useDisclosure } from '../../hooks/useDisclosure';
 import { BODY_TYPEFACE } from '../../theme/foundations/typography';
 

tools/scripts/pw.docker.deps.sh

@@ -18,4 +18,4 @@ export npm_config_build_from_source=false
 export npm_config_prefer_offline=true
 export NODE_PATH=$(pwd)/node_modules_linux
 
-pnpm install --modules-folder node_modules_linux
+pnpm install --modules-dir node_modules_linux