testnet label and network logo fixes #3153
Open
+212
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom2drum
approved these changes
Nov 27, 2025
Comment on lines
+9
to
+11
| // for the case where the image dimensions are not known before the image is loaded | ||
| skeletonWidth?: BoxProps['width']; | ||
| skeletonHeight?: BoxProps['height']; |
Collaborator
There was a problem hiding this comment.
Since skeletonWidth without skeletonHeight doesn't make much sense (if I understand the comment correctly), it may be better to combine these props into a single object.
Suggested change
| // for the case where the image dimensions are not known before the image is loaded | |
| skeletonWidth?: BoxProps['width']; | |
| skeletonHeight?: BoxProps['height']; | |
| // for the case where the image dimensions are not known before the image is loaded | |
| skeletonProps?: BoxProps; |
Collaborator
Author
There was a problem hiding this comment.
skeleton props are inherited from the component props, but can be overwritten by those -- I think it's clearer what are they for in case of width/height, not just generic 'props'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Related Issue(s)
fixes #3147
Additional Information
Also I refactored NetworkLogo component since it was a bit overengineered
Checklist for PR author