fix: feature flag a11y features in listing pipeline (#5979)

Author: emilyjablonski

api/prisma/seed-helpers/listing-factory.ts

@@ -39,6 +39,7 @@ export const listingFactory = async (
     applicationDueDate?: Date;
     closedAt?: Date;
     digitalApp?: boolean;
+    enableListingFeaturesAndUtilities?: boolean;
     includeBuildingFeatures?: boolean;
     includeEligibilityRules?: boolean;
     includeReservedCommunityTypes?: boolean;
@@ -230,10 +231,12 @@ export const listingFactory = async (
       : {},
     ...additionalEligibilityRules(optionalParams?.includeEligibilityRules),
     ...buildingFeatures(optionalParams?.includeBuildingFeatures),
-    ...featuresAndUtilites(
-      optionalParams?.optionalFeatures,
-      optionalParams?.optionalUtilities,
-    ),
+    ...(optionalParams?.enableListingFeaturesAndUtilities
+      ? featuresAndUtilites(
+          optionalParams?.optionalFeatures,
+          optionalParams?.optionalUtilities,
+        )
+      : {}),
     ...(optionalParams?.listing?.listingType === ListingTypeEnum.nonRegulated
       ? listingsRequiredDocuments(optionalParams?.requiredDocumentsList)
       : {}),

api/prisma/seed-staging.ts

@@ -991,6 +991,7 @@ export const stagingSeed = async (
         ],
         userAccounts: [{ id: partnerUser.id }],
         optionalFeatures: { carpetInUnit: true },
+        enableListingFeaturesAndUtilities: true,
       },
     ],
     [
@@ -1182,6 +1183,7 @@ export const stagingSeed = async (
           }),
         ],
         userAccounts: [{ id: partnerUser.id }],
+        enableListingFeaturesAndUtilities: true,
       },
     ],
     [
@@ -1210,6 +1212,7 @@ export const stagingSeed = async (
           },
         ],
         userAccounts: [{ id: partnerUser.id }],
+        enableListingFeaturesAndUtilities: true,
       },
     ],
     [
@@ -1250,6 +1253,7 @@ export const stagingSeed = async (
           }),
         ],
         userAccounts: [{ id: partnerUser.id }],
+        enableListingFeaturesAndUtilities: true,
       },
     ],
     [
@@ -1259,6 +1263,7 @@ export const stagingSeed = async (
         listing: littleVillageApartments,
         multiselectQuestions: [workInCityQuestion],
         userAccounts: [{ id: partnerUser.id }],
+        enableListingFeaturesAndUtilities: true,
       },
     ],
     [
@@ -1404,6 +1409,7 @@ export const stagingSeed = async (
           },
         ],
         userAccounts: [{ id: partnerUser.id }],
+        enableListingFeaturesAndUtilities: true,
       },
     ],
     [
@@ -1439,6 +1445,7 @@ export const stagingSeed = async (
             },
           },
         ],
+        enableListingFeaturesAndUtilities: true,
       },
     ],
     [
@@ -1500,6 +1507,7 @@ export const stagingSeed = async (
             },
           },
         ],
+        enableListingFeaturesAndUtilities: true,
       },
     ],
   ];

api/test/integration/listing.e2e-spec.ts

@@ -685,6 +685,7 @@ describe('Listing Controller Tests', () => {
         }),
       });
       const listing1Input = await listingFactory(jurisdictionB.id, prisma, {
+        enableListingFeaturesAndUtilities: true,
         listing: {
           homeType: HomeTypeEnum.apartment,
           isVerified: true,
@@ -718,6 +719,7 @@ describe('Listing Controller Tests', () => {
       });
 
       const listing2Input = await listingFactory(jurisdictionB.id, prisma, {
+        enableListingFeaturesAndUtilities: true,
         includeReservedCommunityTypes: true,
         listing: {
           homeType: HomeTypeEnum.duplex,

sites/partners/src/components/listings/PaperListingForm/index.tsx

@@ -395,14 +395,23 @@ const ListingForm = ({
             formData.listingType = undefined
           }
 
-          if (formData.configurableAccessibilityFeatures) {
-            setAccessibilityFeatures(
-              Object.values(formData.configurableAccessibilityFeatures).flat() as string[]
+          if (
+            doJurisdictionsHaveFeatureFlagOn(
+              FeatureFlagEnum.enableAccessibilityFeatures,
+              jurisdictionId
             )
-          }
+          ) {
+            if (formData.configurableAccessibilityFeatures) {
+              setAccessibilityFeatures(
+                Object.values(formData.configurableAccessibilityFeatures).flat() as string[]
+              )
+            }
 
-          if (!formData.configurableAccessibilityFeatures) {
-            formData.configurableAccessibilityFeatures = accessibilityFeatures
+            if (!formData.configurableAccessibilityFeatures) {
+              formData.configurableAccessibilityFeatures = accessibilityFeatures
+            }
+          } else {
+            delete formData.configurableAccessibilityFeatures
           }
 
           if (successful) {