test: flaky test

emilyjablonski · emilyjablonski · commit 9fe9e05a77de · 2026-02-27T20:20:28.000-07:00
diff --git a/api/test/integration/permission-tests/permission-as-admin.e2e-spec.ts b/api/test/integration/permission-tests/permission-as-admin.e2e-spec.ts
@@ -40,6 +40,7 @@ import { EmailAndAppUrl } from '../../../src/dtos/users/email-and-app-url.dto';
 import { ConfirmationRequest } from '../../../src/dtos/users/confirmation-request.dto';
 import { UserService } from '../../../src/services/user.service';
 import { EmailService } from '../../../src/services/email.service';
+import { CronJobService } from '../../../src/services/cron-job.service';
 import { permissionActions } from '../../../src/enums/permissions/permission-actions-enum';
 import { AfsResolve } from '../../../src/dtos/application-flagged-sets/afs-resolve.dto';
 import {
@@ -75,6 +76,11 @@ const testEmailService = {
   applicationConfirmation: jest.fn(),
 };
 
+const testCronJobService = {
+  startCronJob: jest.fn().mockResolvedValue(undefined),
+  markCronJobAsStarted: jest.fn().mockResolvedValue(undefined),
+};
+
 describe('Testing Permissioning of endpoints as Admin User', () => {
   let app: INestApplication;
   let prisma: PrismaService;
@@ -88,6 +94,8 @@ describe('Testing Permissioning of endpoints as Admin User', () => {
     })
       .overrideProvider(EmailService)
       .useValue(testEmailService)
+      .overrideProvider(CronJobService)
+      .useValue(testCronJobService)
       .compile();
 
     app = moduleFixture.createNestApplication();
diff --git a/api/test/integration/permission-tests/permission-as-juris-admin-correct-juris.e2e-spec.ts b/api/test/integration/permission-tests/permission-as-juris-admin-correct-juris.e2e-spec.ts
@@ -39,6 +39,7 @@ import { EmailAndAppUrl } from '../../../src/dtos/users/email-and-app-url.dto';
 import { ConfirmationRequest } from '../../../src/dtos/users/confirmation-request.dto';
 import { UserService } from '../../../src/services/user.service';
 import { EmailService } from '../../../src/services/email.service';
+import { CronJobService } from '../../../src/services/cron-job.service';
 import { permissionActions } from '../../../src/enums/permissions/permission-actions-enum';
 import { AfsResolve } from '../../../src/dtos/application-flagged-sets/afs-resolve.dto';
 import {
@@ -73,6 +74,11 @@ const testEmailService = {
   applicationConfirmation: jest.fn(),
 };
 
+const testCronJobService = {
+  startCronJob: jest.fn().mockResolvedValue(undefined),
+  markCronJobAsStarted: jest.fn().mockResolvedValue(undefined),
+};
+
 describe('Testing Permissioning of endpoints as Jurisdictional Admin in the correct jurisdiction', () => {
   let app: INestApplication;
   let prisma: PrismaService;
@@ -85,6 +91,8 @@ describe('Testing Permissioning of endpoints as Jurisdictional Admin in the corr
     })
       .overrideProvider(EmailService)
       .useValue(testEmailService)
+      .overrideProvider(CronJobService)
+      .useValue(testCronJobService)
       .compile();
 
     app = moduleFixture.createNestApplication();
diff --git a/api/test/integration/permission-tests/permission-as-juris-admin-wrong-juris.e2e-spec.ts b/api/test/integration/permission-tests/permission-as-juris-admin-wrong-juris.e2e-spec.ts
@@ -39,6 +39,7 @@ import { EmailAndAppUrl } from '../../../src/dtos/users/email-and-app-url.dto';
 import { ConfirmationRequest } from '../../../src/dtos/users/confirmation-request.dto';
 import { UserService } from '../../../src/services/user.service';
 import { EmailService } from '../../../src/services/email.service';
+import { CronJobService } from '../../../src/services/cron-job.service';
 import { AfsResolve } from '../../../src/dtos/application-flagged-sets/afs-resolve.dto';
 import {
   generateJurisdiction,
@@ -72,6 +73,11 @@ const testEmailService = {
   applicationConfirmation: jest.fn(),
 };
 
+const testCronJobService = {
+  startCronJob: jest.fn().mockResolvedValue(undefined),
+  markCronJobAsStarted: jest.fn().mockResolvedValue(undefined),
+};
+
 describe('Testing Permissioning of endpoints as Jurisdictional Admin in the wrong jurisdiction', () => {
   let app: INestApplication;
   let prisma: PrismaService;
@@ -85,6 +91,8 @@ describe('Testing Permissioning of endpoints as Jurisdictional Admin in the wron
     })
       .overrideProvider(EmailService)
       .useValue(testEmailService)
+      .overrideProvider(CronJobService)
+      .useValue(testCronJobService)
       .compile();
 
     app = moduleFixture.createNestApplication();
diff --git a/api/test/integration/permission-tests/permission-as-limited-juris-admin-correct-juris.e2e-spec.ts b/api/test/integration/permission-tests/permission-as-limited-juris-admin-correct-juris.e2e-spec.ts
@@ -39,6 +39,7 @@ import { EmailAndAppUrl } from '../../../src/dtos/users/email-and-app-url.dto';
 import { ConfirmationRequest } from '../../../src/dtos/users/confirmation-request.dto';
 import { UserService } from '../../../src/services/user.service';
 import { EmailService } from '../../../src/services/email.service';
+import { CronJobService } from '../../../src/services/cron-job.service';
 import { permissionActions } from '../../../src/enums/permissions/permission-actions-enum';
 import { AfsResolve } from '../../../src/dtos/application-flagged-sets/afs-resolve.dto';
 import {
@@ -72,6 +73,11 @@ const testEmailService = {
   applicationConfirmation: jest.fn(),
 };
 
+const testCronJobService = {
+  startCronJob: jest.fn().mockResolvedValue(undefined),
+  markCronJobAsStarted: jest.fn().mockResolvedValue(undefined),
+};
+
 describe('Testing Permissioning of endpoints as Limited Jurisdictional Admin in the correct jurisdiction', () => {
   let app: INestApplication;
   let prisma: PrismaService;
@@ -84,6 +90,8 @@ describe('Testing Permissioning of endpoints as Limited Jurisdictional Admin in
     })
       .overrideProvider(EmailService)
       .useValue(testEmailService)
+      .overrideProvider(CronJobService)
+      .useValue(testCronJobService)
       .compile();
 
     app = moduleFixture.createNestApplication();
diff --git a/api/test/integration/permission-tests/permission-as-limited-juris-admin-wrong-juris.e2e-spec.ts b/api/test/integration/permission-tests/permission-as-limited-juris-admin-wrong-juris.e2e-spec.ts
@@ -39,6 +39,7 @@ import { EmailAndAppUrl } from '../../../src/dtos/users/email-and-app-url.dto';
 import { ConfirmationRequest } from '../../../src/dtos/users/confirmation-request.dto';
 import { UserService } from '../../../src/services/user.service';
 import { EmailService } from '../../../src/services/email.service';
+import { CronJobService } from '../../../src/services/cron-job.service';
 import { AfsResolve } from '../../../src/dtos/application-flagged-sets/afs-resolve.dto';
 import {
   generateJurisdiction,
@@ -72,6 +73,11 @@ const testEmailService = {
   applicationConfirmation: jest.fn(),
 };
 
+const testCronJobService = {
+  startCronJob: jest.fn().mockResolvedValue(undefined),
+  markCronJobAsStarted: jest.fn().mockResolvedValue(undefined),
+};
+
 describe('Testing Permissioning of endpoints as Limited Jurisdictional Admin in the wrong jurisdiction', () => {
   let app: INestApplication;
   let prisma: PrismaService;
@@ -85,6 +91,8 @@ describe('Testing Permissioning of endpoints as Limited Jurisdictional Admin in
     })
       .overrideProvider(EmailService)
       .useValue(testEmailService)
+      .overrideProvider(CronJobService)
+      .useValue(testCronJobService)
       .compile();
 
     app = moduleFixture.createNestApplication();
diff --git a/api/test/integration/permission-tests/permission-as-no-user.e2e-spec.ts b/api/test/integration/permission-tests/permission-as-no-user.e2e-spec.ts
@@ -36,6 +36,7 @@ import { EmailAndAppUrl } from '../../../src/dtos/users/email-and-app-url.dto';
 import { ConfirmationRequest } from '../../../src/dtos/users/confirmation-request.dto';
 import { UserService } from '../../../src/services/user.service';
 import { EmailService } from '../../../src/services/email.service';
+import { CronJobService } from '../../../src/services/cron-job.service';
 import { AfsResolve } from '../../../src/dtos/application-flagged-sets/afs-resolve.dto';
 import { unitRentTypeFactory } from '../../../prisma/seed-helpers/unit-rent-type-factory';
 import { UnitRentTypeCreate } from '../../../src/dtos/unit-rent-types/unit-rent-type-create.dto';
@@ -74,6 +75,11 @@ const testEmailService = {
   applicationConfirmation: jest.fn(),
 };
 
+const testCronJobService = {
+  startCronJob: jest.fn().mockResolvedValue(undefined),
+  markCronJobAsStarted: jest.fn().mockResolvedValue(undefined),
+};
+
 describe('Testing Permissioning of endpoints as logged out user', () => {
   let app: INestApplication;
   let prisma: PrismaService;
@@ -87,6 +93,8 @@ describe('Testing Permissioning of endpoints as logged out user', () => {
     })
       .overrideProvider(EmailService)
       .useValue(testEmailService)
+      .overrideProvider(CronJobService)
+      .useValue(testCronJobService)
       .compile();
 
     app = moduleFixture.createNestApplication();
diff --git a/api/test/integration/permission-tests/permission-as-partner-correct-listing.e2e-spec.ts b/api/test/integration/permission-tests/permission-as-partner-correct-listing.e2e-spec.ts
@@ -40,6 +40,7 @@ import { EmailAndAppUrl } from '../../../src/dtos/users/email-and-app-url.dto';
 import { ConfirmationRequest } from '../../../src/dtos/users/confirmation-request.dto';
 import { UserService } from '../../../src/services/user.service';
 import { EmailService } from '../../../src/services/email.service';
+import { CronJobService } from '../../../src/services/cron-job.service';
 import { permissionActions } from '../../../src/enums/permissions/permission-actions-enum';
 import { AfsResolve } from '../../../src/dtos/application-flagged-sets/afs-resolve.dto';
 import {
@@ -76,6 +77,11 @@ const testEmailService = {
   lotteryPublishedApplicant: jest.fn(),
 };
 
+const testCronJobService = {
+  startCronJob: jest.fn().mockResolvedValue(undefined),
+  markCronJobAsStarted: jest.fn().mockResolvedValue(undefined),
+};
+
 describe('Testing Permissioning of endpoints as partner with correct listing', () => {
   let app: INestApplication;
   let prisma: PrismaService;
@@ -95,6 +101,8 @@ describe('Testing Permissioning of endpoints as partner with correct listing', (
     })
       .overrideProvider(EmailService)
       .useValue(testEmailService)
+      .overrideProvider(CronJobService)
+      .useValue(testCronJobService)
       .compile();
 
     app = moduleFixture.createNestApplication();
diff --git a/api/test/integration/permission-tests/permission-as-partner-wrong-listing.e2e-spec.ts b/api/test/integration/permission-tests/permission-as-partner-wrong-listing.e2e-spec.ts
@@ -40,6 +40,7 @@ import { EmailAndAppUrl } from '../../../src/dtos/users/email-and-app-url.dto';
 import { ConfirmationRequest } from '../../../src/dtos/users/confirmation-request.dto';
 import { UserService } from '../../../src/services/user.service';
 import { EmailService } from '../../../src/services/email.service';
+import { CronJobService } from '../../../src/services/cron-job.service';
 import { AfsResolve } from '../../../src/dtos/application-flagged-sets/afs-resolve.dto';
 import {
   generateJurisdiction,
@@ -72,6 +73,11 @@ const testEmailService = {
   applicationConfirmation: jest.fn(),
 };
 
+const testCronJobService = {
+  startCronJob: jest.fn().mockResolvedValue(undefined),
+  markCronJobAsStarted: jest.fn().mockResolvedValue(undefined),
+};
+
 describe('Testing Permissioning of endpoints as partner with wrong listing', () => {
   let app: INestApplication;
   let prisma: PrismaService;
@@ -89,6 +95,8 @@ describe('Testing Permissioning of endpoints as partner with wrong listing', ()
     })
       .overrideProvider(EmailService)
       .useValue(testEmailService)
+      .overrideProvider(CronJobService)
+      .useValue(testCronJobService)
       .compile();
 
     app = moduleFixture.createNestApplication();
diff --git a/api/test/integration/permission-tests/permission-as-public.e2e-spec.ts b/api/test/integration/permission-tests/permission-as-public.e2e-spec.ts
@@ -40,6 +40,7 @@ import { EmailAndAppUrl } from '../../../src/dtos/users/email-and-app-url.dto';
 import { ConfirmationRequest } from '../../../src/dtos/users/confirmation-request.dto';
 import { UserService } from '../../../src/services/user.service';
 import { EmailService } from '../../../src/services/email.service';
+import { CronJobService } from '../../../src/services/cron-job.service';
 import { AfsResolve } from '../../../src/dtos/application-flagged-sets/afs-resolve.dto';
 import {
   generateJurisdiction,
@@ -75,6 +76,11 @@ const testEmailService = {
   applicationConfirmation: jest.fn(),
 };
 
+const testCronJobService = {
+  startCronJob: jest.fn().mockResolvedValue(undefined),
+  markCronJobAsStarted: jest.fn().mockResolvedValue(undefined),
+};
+
 describe('Testing Permissioning of endpoints as public user', () => {
   let app: INestApplication;
   let prisma: PrismaService;
@@ -89,6 +95,8 @@ describe('Testing Permissioning of endpoints as public user', () => {
     })
       .overrideProvider(EmailService)
       .useValue(testEmailService)
+      .overrideProvider(CronJobService)
+      .useValue(testCronJobService)
       .compile();
 
     app = moduleFixture.createNestApplication();
diff --git a/api/test/integration/permission-tests/permission-as-support-admin.e2e-spec.ts b/api/test/integration/permission-tests/permission-as-support-admin.e2e-spec.ts
@@ -40,6 +40,7 @@ import { EmailAndAppUrl } from '../../../src/dtos/users/email-and-app-url.dto';
 import { ConfirmationRequest } from '../../../src/dtos/users/confirmation-request.dto';
 import { UserService } from '../../../src/services/user.service';
 import { EmailService } from '../../../src/services/email.service';
+import { CronJobService } from '../../../src/services/cron-job.service';
 import { permissionActions } from '../../../src/enums/permissions/permission-actions-enum';
 import { AfsResolve } from '../../../src/dtos/application-flagged-sets/afs-resolve.dto';
 import {
@@ -77,6 +78,11 @@ const testEmailService = {
   applicationConfirmation: jest.fn(),
 };
 
+const testCronJobService = {
+  startCronJob: jest.fn().mockResolvedValue(undefined),
+  markCronJobAsStarted: jest.fn().mockResolvedValue(undefined),
+};
+
 describe('Testing Permissioning of endpoints as Support Admin User', () => {
   let app: INestApplication;
   let prisma: PrismaService;
@@ -90,6 +96,8 @@ describe('Testing Permissioning of endpoints as Support Admin User', () => {
     })
       .overrideProvider(EmailService)
       .useValue(testEmailService)
+      .overrideProvider(CronJobService)
+      .useValue(testCronJobService)
       .compile();
 
     app = moduleFixture.createNestApplication();
diff --git a/sites/public/__tests__/components/applications/ApplicationsView.test.tsx b/sites/public/__tests__/components/applications/ApplicationsView.test.tsx
@@ -1,5 +1,6 @@
 import React from "react"
 import { cleanup } from "@testing-library/react"
+import userEvent from "@testing-library/user-event"
 import { mockNextRouter, render, waitFor, within, screen } from "../../testUtils"
 import { AuthContext } from "@bloom-housing/shared-helpers"
 import ApplicationsView, {
@@ -16,7 +17,6 @@ import {
 } from "@bloom-housing/shared-helpers/src/types/backend-swagger"
 import { setupServer } from "msw/lib/node"
 import { rest } from "msw"
-import userEvent from "@testing-library/user-event"
 
 const server = setupServer()
 window.scrollTo = jest.fn()
@@ -106,12 +106,13 @@ function getApplications(
 
 function renderApplicationsView(
   filterType = ApplicationsIndexEnum.all,
-  enableApplicationStatus = false
+  enableApplicationStatus = false,
+  profileOverrides = {}
 ) {
   return render(
     <AuthContext.Provider
       value={{
-        profile: { ...user, jurisdictions: [], listings: [] },
+        profile: { ...user, jurisdictions: [], listings: [], ...profileOverrides },
         applicationsService: new ApplicationsService(),
       }}
     >
@@ -545,4 +546,77 @@ describe("<ApplicationsView>", () => {
       expect(screen.queryByText("Your confirmation number is:")).not.toBeInTheDocument()
     })
   })
+
+  describe("Advocate applicant search", () => {
+    it("should not show applicant search for non-advocate users", async () => {
+      server.use(
+        rest.get("http://localhost:3100/applications/publicAppsView", (_req, res, ctx) => {
+          return res(ctx.json(getApplications(1, 0, 0)))
+        })
+      )
+
+      renderApplicationsView(ApplicationsIndexEnum.all, false, { isAdvocate: false })
+
+      expect(await screen.findAllByRole("link", { name: /view application/i })).toHaveLength(1)
+      expect(screen.queryByPlaceholderText("Search by first and last name")).not.toBeInTheDocument()
+    })
+
+    it("should hide search bar for advocate only when unfiltered fetch returns zero total applications", async () => {
+      server.use(
+        rest.get("http://localhost:3100/applications/publicAppsView", (_req, res, ctx) => {
+          return res(ctx.json(getApplications(0, 0, 0)))
+        })
+      )
+
+      renderApplicationsView(ApplicationsIndexEnum.all, false, { isAdvocate: true })
+
+      expect(
+        await screen.findByText("It looks like you haven't applied to any listings yet.")
+      ).toBeInTheDocument()
+      expect(screen.queryByPlaceholderText("Search by first and last name")).not.toBeInTheDocument()
+    })
+
+    it("should keep search bar visible for advocate when unfiltered fetch has applications", async () => {
+      server.use(
+        rest.get("http://localhost:3100/applications/publicAppsView", (_req, res, ctx) => {
+          return res(ctx.json(getApplications(1, 0, 0)))
+        })
+      )
+
+      renderApplicationsView(ApplicationsIndexEnum.all, false, { isAdvocate: true })
+
+      expect(await screen.findAllByRole("link", { name: /view application/i })).toHaveLength(1)
+      expect(screen.getByPlaceholderText("Search by first and last name")).toBeInTheDocument()
+    })
+
+    it("should send applicantNameSearch only when debounced input has at least 3 characters", async () => {
+      const applicantNameSearchParams: string[] = []
+
+      server.use(
+        rest.get("http://localhost:3100/applications/publicAppsView", (req, res, ctx) => {
+          applicantNameSearchParams.push(req.url.searchParams.get("applicantNameSearch") || "")
+          return res(ctx.json(getApplications(1, 0, 0)))
+        }),
+        rest.get("http://localhost/api/adapter/applications/publicAppsView", (req, res, ctx) => {
+          applicantNameSearchParams.push(req.url.searchParams.get("applicantNameSearch") || "")
+          return res(ctx.json(getApplications(1, 0, 0)))
+        })
+      )
+
+      renderApplicationsView(ApplicationsIndexEnum.all, false, { isAdvocate: true })
+
+      const searchInput = await screen.findByPlaceholderText("Search by first and last name")
+      expect(applicantNameSearchParams).toEqual([""])
+
+      await userEvent.type(searchInput, "ab")
+      await new Promise((resolve) => setTimeout(resolve, 650))
+      expect(applicantNameSearchParams).toEqual([""])
+
+      await userEvent.clear(searchInput)
+      await userEvent.type(searchInput, "abc")
+      await waitFor(() => expect(applicantNameSearchParams).toEqual(["", "abc"]), {
+        timeout: 2000,
+      })
+    })
+  })
 })
