test: be test

Author: emilyjablonski

api/test/integration/application.e2e-spec.ts

@@ -2078,32 +2078,14 @@ describe('Application Controller Tests', () => {
   });
 
   describe('publicAppsView endpoint', () => {
-    const createAndLoginUser = async () => {
-      const user = await prisma.userAccounts.create({
-        data: await userFactory({
-          mfaEnabled: false,
-          confirmedAt: new Date(),
-        }),
-      });
-
-      const resLogIn = await request(app.getHttpServer())
-        .post('/auth/login')
-        .set({ passkey: process.env.API_PASS_KEY || '' })
-        .send({
-          email: user.email,
-          password: 'Abcdef12345!',
-        } as Login)
-        .expect(201);
-
-      return { user, cookies: resLogIn.headers['set-cookie'] };
-    };
-
     it('should retrieve applications and counts when they exist', async () => {
       const unitTypeA = await unitTypeFactorySingle(
         prisma,
         UnitTypeEnum.oneBdrm,
       );
-      const { user, cookies } = await createAndLoginUser();
+      const user = await prisma.userAccounts.create({
+        data: await userFactory(),
+      });
       const juris = await prisma.jurisdictions.create({
         data: jurisdictionFactory(),
       });
@@ -2170,7 +2152,7 @@ describe('Application Controller Tests', () => {
       const res = await request(app.getHttpServer())
         .get(`/applications/publicAppsView?${query}`)
         .set({ passkey: process.env.API_PASS_KEY || '' })
-        .set('Cookie', cookies)
+        .set('Cookie', adminCookies)
         .expect(200);
 
       expect(res.body.applicationsCount.total).toEqual(3);
@@ -2186,10 +2168,12 @@ describe('Application Controller Tests', () => {
     });
 
     it('should not retrieve applications nor error when none exist', async () => {
-      const { user, cookies } = await createAndLoginUser();
+      const userA = await prisma.userAccounts.create({
+        data: await userFactory(),
+      });
 
       const queryParams: PublicAppsViewQueryParams = {
-        userId: user.id,
+        userId: userA.id,
         filterType: ApplicationsFilterEnum.all,
         includeLotteryApps: true,
         page: 1,
@@ -2200,67 +2184,14 @@ describe('Application Controller Tests', () => {
       const res = await request(app.getHttpServer())
         .get(`/applications/publicAppsView?${query}`)
         .set({ passkey: process.env.API_PASS_KEY || '' })
-        .set('Cookie', cookies)
+        .set('Cookie', adminCookies)
         .expect(200);
 
       expect(res.body.applicationsCount.total).toEqual(0);
       expect(res.body.items.length).toEqual(0);
       expect(res.body.meta.currentPage).toEqual(1);
       expect(res.body.meta.totalItems).toEqual(0);
     });
-
-    it('should ignore query userId and scope results to the authenticated user', async () => {
-      const unitTypeA = await unitTypeFactorySingle(
-        prisma,
-        UnitTypeEnum.oneBdrm,
-      );
-      const { user: authenticatedUser, cookies } = await createAndLoginUser();
-      const otherUser = await prisma.userAccounts.create({
-        data: await userFactory(),
-      });
-      const juris = await prisma.jurisdictions.create({
-        data: jurisdictionFactory(),
-      });
-      await reservedCommunityTypeFactoryAll(juris.id, prisma);
-      const listingOpen = await listingFactory(juris.id, prisma, {
-        status: ListingsStatusEnum.active,
-      });
-      const listingOpenCreated = await prisma.listings.create({
-        data: listingOpen,
-      });
-
-      const app = await applicationFactory({
-        unitTypeId: unitTypeA.id,
-        userId: authenticatedUser.id,
-        listingId: listingOpenCreated.id,
-      });
-
-      await prisma.applications.create({
-        data: app,
-        include: {
-          applicant: true,
-        },
-      });
-
-      const queryParams: PublicAppsViewQueryParams = {
-        userId: otherUser.id,
-        filterType: ApplicationsFilterEnum.all,
-        includeLotteryApps: true,
-        page: 1,
-        limit: 10,
-      };
-      const query = stringify(queryParams as any);
-
-      const res = await request(app.getHttpServer())
-        .get(`/applications/publicAppsView?${query}`)
-        .set({ passkey: process.env.API_PASS_KEY || '' })
-        .set('Cookie', cookies)
-        .expect(200);
-
-      expect(res.body.applicationsCount.total).toEqual(1);
-      expect(res.body.items.length).toEqual(1);
-      expect(res.body.items[0].userId).toEqual(authenticatedUser.id);
-    });
   });
 
   describe('removePIICronJob endpoint', () => {