fix: how did you hear test labels

Author: emilyjablonski

sites/public/__tests__/pages/applications/review/demographics.test.tsx

@@ -8,6 +8,7 @@ import {
   Listing,
   RaceEthnicityConfiguration,
 } from "@bloom-housing/shared-helpers/src/types/backend-swagger"
+import { t } from "@bloom-housing/ui-components"
 import { defaultRaceEthnicityConfiguration } from "@bloom-housing/shared-helpers/__tests__/testHelpers"
 import { mockNextRouter, render } from "../../../testUtils"
 import ApplicationConductor from "../../../../src/lib/applications/ApplicationConductor"
@@ -78,11 +79,55 @@ describe("Demographics", () => {
       expect(screen.getByRole("checkbox", { name: "Other / Multiracial" })).toBeInTheDocument()
       expect(screen.getByRole("checkbox", { name: "Decline to respond" })).toBeInTheDocument()
       expect(screen.getByLabelText("Which best describes your ethnicity?")).toBeInTheDocument()
+      const howDidYouHearGroup = screen.getByRole("group", {
+        name: "How did you hear about this listing?",
+      })
+      expect(within(howDidYouHearGroup).getAllByRole("checkbox")).toHaveLength(9)
+      expect(
+        within(howDidYouHearGroup).getByRole("checkbox", {
+          name: t("application.review.demographics.howDidYouHearOptions.flyer"),
+        })
+      ).toBeInTheDocument()
+      expect(
+        within(howDidYouHearGroup).getByRole("checkbox", {
+          name: t("application.review.demographics.howDidYouHearOptions.emailAlert"),
+        })
+      ).toBeInTheDocument()
+      expect(
+        within(howDidYouHearGroup).getByRole("checkbox", {
+          name: t("application.review.demographics.howDidYouHearOptions.friend"),
+        })
+      ).toBeInTheDocument()
+      expect(
+        within(howDidYouHearGroup).getByRole("checkbox", {
+          name: t("application.review.demographics.howDidYouHearOptions.housingCounselor"),
+        })
+      ).toBeInTheDocument()
+      expect(
+        within(howDidYouHearGroup).getByRole("checkbox", {
+          name: t("application.review.demographics.howDidYouHearOptions.developerWebsite"),
+        })
+      ).toBeInTheDocument()
       expect(
-        screen.getAllByRole("checkbox", {
-          name: /Jurisdiction website|Developer website|Flyer|Email alert|Friend|Housing counselor|Radio ad|Bus ad|Other/,
+        within(howDidYouHearGroup).getByRole("checkbox", {
+          name: t("application.review.demographics.howDidYouHearOptions.jurisdictionWebsite"),
         })
-      ).toHaveLength(11)
+      ).toBeInTheDocument()
+      expect(
+        within(howDidYouHearGroup).getByRole("checkbox", {
+          name: t("application.review.demographics.howDidYouHearOptions.busAd"),
+        })
+      ).toBeInTheDocument()
+      expect(
+        within(howDidYouHearGroup).getByRole("checkbox", {
+          name: t("application.review.demographics.howDidYouHearOptions.radioAd"),
+        })
+      ).toBeInTheDocument()
+      expect(
+        within(howDidYouHearGroup).getByRole("checkbox", {
+          name: t("application.review.demographics.howDidYouHearOptions.other"),
+        })
+      ).toBeInTheDocument()
     })
 
     it("should render sub demographics fields when parent is checked", () => {
@@ -229,17 +274,55 @@ describe("Demographics", () => {
         <ApplicationDemographics />
       </AppSubmissionContext.Provider>
     )
-    expect(screen.getByText("How did you hear about this listing?")).toBeInTheDocument()
-    expect(screen.getByRole("checkbox", { name: "Jurisdiction website" })).toBeInTheDocument()
-    expect(screen.getByRole("checkbox", { name: "Developer website" })).toBeInTheDocument()
-    expect(screen.getByRole("checkbox", { name: "Flyer" })).toBeInTheDocument()
-    expect(screen.getByRole("checkbox", { name: "Email alert" })).toBeInTheDocument()
-    expect(screen.getByRole("checkbox", { name: "Friend" })).toBeInTheDocument()
-    expect(screen.getByRole("checkbox", { name: "Friend" })).toBeInTheDocument()
-    expect(screen.getByRole("checkbox", { name: "Housing counselor" })).toBeInTheDocument()
-    expect(screen.queryByRole("checkbox", { name: "Radio ad" })).not.toBeInTheDocument()
-    expect(screen.queryByRole("checkbox", { name: "Bus ad" })).not.toBeInTheDocument()
-    expect(screen.getByRole("checkbox", { name: "Other" })).toBeInTheDocument()
+    const howDidYouHearGroup = screen.getByRole("group", {
+      name: "How did you hear about this listing?",
+    })
+    expect(within(howDidYouHearGroup).getAllByRole("checkbox")).toHaveLength(7)
+    expect(
+      within(howDidYouHearGroup).getByRole("checkbox", {
+        name: t("application.review.demographics.howDidYouHearOptions.flyer"),
+      })
+    ).toBeInTheDocument()
+    expect(
+      within(howDidYouHearGroup).getByRole("checkbox", {
+        name: t("application.review.demographics.howDidYouHearOptions.emailAlert"),
+      })
+    ).toBeInTheDocument()
+    expect(
+      within(howDidYouHearGroup).getByRole("checkbox", {
+        name: t("application.review.demographics.howDidYouHearOptions.friend"),
+      })
+    ).toBeInTheDocument()
+    expect(
+      within(howDidYouHearGroup).getByRole("checkbox", {
+        name: t("application.review.demographics.howDidYouHearOptions.housingCounselor"),
+      })
+    ).toBeInTheDocument()
+    expect(
+      within(howDidYouHearGroup).getByRole("checkbox", {
+        name: t("application.review.demographics.howDidYouHearOptions.developerWebsite"),
+      })
+    ).toBeInTheDocument()
+    expect(
+      within(howDidYouHearGroup).getByRole("checkbox", {
+        name: t("application.review.demographics.howDidYouHearOptions.jurisdictionWebsite"),
+      })
+    ).toBeInTheDocument()
+    expect(
+      within(howDidYouHearGroup).queryByRole("checkbox", {
+        name: t("application.review.demographics.howDidYouHearOptions.busAd"),
+      })
+    ).not.toBeInTheDocument()
+    expect(
+      within(howDidYouHearGroup).queryByRole("checkbox", {
+        name: t("application.review.demographics.howDidYouHearOptions.radioAd"),
+      })
+    ).not.toBeInTheDocument()
+    expect(
+      within(howDidYouHearGroup).getByRole("checkbox", {
+        name: t("application.review.demographics.howDidYouHearOptions.other"),
+      })
+    ).toBeInTheDocument()
   })
 
   it("should hide ethnicity field when disabledEthnicityQuestion flag is on", () => {
@@ -280,19 +363,16 @@ describe("Demographics", () => {
         options: [
           {
             id: "blackAfricanAmerican",
-            hasSubOptions: false,
             subOptions: [],
             allowOtherText: false,
           },
           {
             id: "white",
-            hasSubOptions: false,
             subOptions: [],
             allowOtherText: false,
           },
           {
             id: "otherMultiracial",
-            hasSubOptions: false,
             subOptions: [],
             allowOtherText: true,
           },
@@ -340,7 +420,6 @@ describe("Demographics", () => {
         options: [
           {
             id: "asian",
-            hasSubOptions: true,
             subOptions: [
               { id: "chinese", allowOtherText: false },
               { id: "vietnamese", allowOtherText: false },