Adding phone numbers to user accounts #2058
plunkettgoogle
started this conversation in
Ideas
Replies: 2 comments
-
|
I slimmed down the PR to only include the necessary changes in the user_accounts table + backend APIs, and upstreamed to a PR here: #2075. Hopefully this is compatible with what y'all were planning with 2-factor authentication. |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Unfortunately it looks like CityOfDetroit is missing some user profile related changes (#1862), so I'll need to make another PR once we've merged those changes downstream. You can still check out the original PR though, I think the backend changes should be largely the same. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hello fine folks,
I'm currently working on a feature over in the CityOfDetroit/bloom fork that would allow for sending listing updates via SMS. Naturally this requires associating a phone number to a user account. I've heard that y'all are working on 2-factor auth with a phone number, so I wanted to make sure that wherever I land is amenable to how y'all plan on adding phone numbers. I've uploaded a PR on the CityOfDetroit repo: CityOfDetroit#710.
If anyone could take a look and make sure I'm not too far off the mark, that would be great. The PR obviously needs more work (tests, formatting validation, etc), but I wanted to get some of your eyes on it sooner rather than later.
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions