Skip to content

Commit 7c05f61

Browse files
committed
[SPARK-28130][PYTHON] Print pretty messages for skipped tests when xmlrunner is available in PySpark
## What changes were proposed in this pull request? Currently, pretty skipped message added by apache@f7435be mechanism seems not working when xmlrunner is installed apparently. This PR fixes two things: 1. When `xmlrunner` is installed, seems `xmlrunner` does not respect `vervosity` level in unittests (default is level 1). So the output looks as below ``` Running tests... ---------------------------------------------------------------------- SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS ---------------------------------------------------------------------- ``` So it is not caught by our message detection mechanism. 2. If we manually set the `vervocity` level to `xmlrunner`, it prints messages as below: ``` test_mixed_udf (pyspark.sql.tests.test_pandas_udf_scalar.ScalarPandasUDFTests) ... SKIP (0.000s) test_mixed_udf_and_sql (pyspark.sql.tests.test_pandas_udf_scalar.ScalarPandasUDFTests) ... SKIP (0.000s) ... ``` This is different in our Jenkins machine: ``` test_createDataFrame_column_name_encoding (pyspark.sql.tests.test_arrow.ArrowTests) ... skipped 'Pandas >= 0.23.2 must be installed; however, it was not found.' test_createDataFrame_does_not_modify_input (pyspark.sql.tests.test_arrow.ArrowTests) ... skipped 'Pandas >= 0.23.2 must be installed; however, it was not found.' ... ``` Note that last `SKIP` is different. This PR fixes the regular expression to catch `SKIP` case as well. ## How was this patch tested? Manually tested. **Before:** ``` Starting test(python2.7): pyspark.... Finished test(python2.7): pyspark.... (0s) ... Tests passed in 562 seconds ======================================================================== ... ``` **After:** ``` Starting test(python2.7): pyspark.... Finished test(python2.7): pyspark.... (48s) ... 93 tests were skipped ... Tests passed in 560 seconds Skipped tests pyspark.... with python2.7: pyspark...(...) ... SKIP (0.000s) ... ======================================================================== ... ``` Closes apache#24927 from HyukjinKwon/SPARK-28130. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
1 parent a00774a commit 7c05f61

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+68
-64
lines changed

python/pyspark/ml/tests/test_algorithms.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@ def test_linear_regression_with_huber_loss(self):
334334

335335
try:
336336
import xmlrunner
337-
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports')
337+
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports', verbosity=2)
338338
except ImportError:
339339
testRunner = None
340340
unittest.main(testRunner=testRunner, verbosity=2)

python/pyspark/ml/tests/test_base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def testDefaultFitMultiple(self):
7171

7272
try:
7373
import xmlrunner
74-
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports')
74+
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports', verbosity=2)
7575
except ImportError:
7676
testRunner = None
7777
unittest.main(testRunner=testRunner, verbosity=2)

python/pyspark/ml/tests/test_evaluation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def test_clustering_evaluator_with_cosine_distance(self):
5757

5858
try:
5959
import xmlrunner
60-
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports')
60+
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports', verbosity=2)
6161
except ImportError:
6262
testRunner = None
6363
unittest.main(testRunner=testRunner, verbosity=2)

python/pyspark/ml/tests/test_feature.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ def test_apply_binary_term_freqs(self):
307307

308308
try:
309309
import xmlrunner
310-
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports')
310+
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports', verbosity=2)
311311
except ImportError:
312312
testRunner = None
313313
unittest.main(testRunner=testRunner, verbosity=2)

python/pyspark/ml/tests/test_image.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ def test_read_images_multiple_times(self):
104104

105105
try:
106106
import xmlrunner
107-
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports')
107+
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports', verbosity=2)
108108
except ImportError:
109109
testRunner = None
110110
unittest.main(testRunner=testRunner, verbosity=2)

python/pyspark/ml/tests/test_linalg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ def test_infer_schema(self):
382382

383383
try:
384384
import xmlrunner
385-
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports')
385+
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports', verbosity=2)
386386
except ImportError:
387387
testRunner = None
388388
unittest.main(testRunner=testRunner, verbosity=2)

python/pyspark/ml/tests/test_param.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ def test_java_params(self):
360360

361361
try:
362362
import xmlrunner
363-
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports')
363+
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports', verbosity=2)
364364
except ImportError:
365365
testRunner = None
366366
unittest.main(testRunner=testRunner, verbosity=2)

python/pyspark/ml/tests/test_persistence.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ def test_default_read_write_default_params(self):
392392

393393
try:
394394
import xmlrunner
395-
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports')
395+
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports', verbosity=2)
396396
except ImportError:
397397
testRunner = None
398398
unittest.main(testRunner=testRunner, verbosity=2)

python/pyspark/ml/tests/test_pipeline.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def doTransform(pipeline):
6363

6464
try:
6565
import xmlrunner
66-
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports')
66+
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports', verbosity=2)
6767
except ImportError:
6868
testRunner = None
6969
unittest.main(testRunner=testRunner, verbosity=2)

python/pyspark/ml/tests/test_stat.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def test_chisquaretest(self):
4444

4545
try:
4646
import xmlrunner
47-
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports')
47+
testRunner = xmlrunner.XMLTestRunner(output='target/test-reports', verbosity=2)
4848
except ImportError:
4949
testRunner = None
5050
unittest.main(testRunner=testRunner, verbosity=2)

0 commit comments

Comments
 (0)