{180374805} No timeout for successfully authenticated connections

Signed-off-by: mohitkhullar <mkhullar1@bloomberg.net>

Author: mohitkhullar

db/comdb2.c

@@ -236,6 +236,7 @@ int gbl_uses_password;
 int gbl_unauth_tag_access = 0;
 int64_t gbl_num_auth_allowed = 0;
 int64_t gbl_num_auth_denied = 0;
+int gbl_allow_old_authn = 1;
 int gbl_uses_externalauth = 0;
 int gbl_uses_externalauth_connect = 0;
 int gbl_externalauth_warn = 0;

db/comdb2.h

@@ -1632,6 +1632,7 @@ extern int gbl_maxreclen;
 extern int gbl_penaltyincpercent;
 extern int gbl_maxwthreadpenalty;
 
+extern int gbl_allow_old_authn;
 extern int gbl_uses_password;
 extern int gbl_unauth_tag_access;
 extern int gbl_uses_externalauth;

db/db_tunables.h

@@ -2379,6 +2379,10 @@ REGISTER_TUNABLE("merge_table_enabled",
                  TUNABLE_BOOLEAN, &gbl_merge_table_enabled, 0, NULL, NULL,
                  NULL, NULL);
 
+REGISTER_TUNABLE("allow_old_authn", "Reuse old successful authentication for the connection",
+                 TUNABLE_BOOLEAN, &gbl_allow_old_authn, NOARG | READEARLY,
+                 NULL, NULL, NULL, NULL);
+
 REGISTER_TUNABLE("externalauth", NULL, TUNABLE_BOOLEAN, &gbl_uses_externalauth, NOARG | READEARLY,
                  NULL, NULL, NULL, NULL);
 

db/sql.h

@@ -501,6 +501,7 @@ struct plugin_callbacks {
     plugin_func *local_check; /* newsql_local_check_evbuffer */
     plugin_func *peer_check; /* newsql_peer_check_evbuffer */
     auth_func *get_authdata; /* newsql_get_authdata */
+    plugin_func *free_authdata; /* newsql_free_authdata */
     api_type_func *api_type; /* newsql_api_type */
 
     /* Optional */
@@ -567,6 +568,7 @@ struct plugin_callbacks {
         make_plugin_callback(clnt, name, local_check);                         \
         make_plugin_callback(clnt, name, peer_check);                          \
         make_plugin_callback(clnt, name, get_authdata);                        \
+        make_plugin_callback(clnt, name, free_authdata);                       \
         make_plugin_callback(clnt, name, api_type);                            \
         make_plugin_optional_null(clnt, count);                                \
         make_plugin_optional_null(clnt, type);                                 \
@@ -597,6 +599,7 @@ int clr_high_availability(struct sqlclntstate *);
 uint64_t get_client_starttime(struct sqlclntstate *);
 int get_client_retries(struct sqlclntstate *);
 void *get_authdata(struct sqlclntstate *);
+void free_authdata(struct sqlclntstate *);
 char *clnt_tzname(struct sqlclntstate *, sqlite3_stmt *);
 
 struct clnt_ddl_context {

db/sqlinterfaces.c

@@ -576,6 +576,12 @@ void *get_authdata(struct sqlclntstate *clnt)
     return clnt->plugin.get_authdata(clnt);
 }
 
+void free_authdata(struct sqlclntstate *clnt)
+{
+    if (clnt && clnt->plugin.free_authdata)
+        clnt->plugin.free_authdata(clnt);
+}
+
 static int skip_row(struct sqlclntstate *clnt, uint64_t rowid)
 {
     return clnt->plugin.skip_row(clnt, rowid);
@@ -5245,7 +5251,7 @@ void cleanup_clnt(struct sqlclntstate *clnt)
     memset(clnt->work.aFingerprint, 0, FINGERPRINTSZ);
 
     clear_session_tbls(clnt);
-    free(clnt->authdata);
+    free_authdata(clnt);
     clnt->authdata = NULL;
 
     free_client_adj_col_names(clnt);
@@ -5277,6 +5283,18 @@ void cleanup_clnt(struct sqlclntstate *clnt)
 int gbl_unexpected_last_type_warn = 1;
 int gbl_unexpected_last_type_abort = 0;
 
+int cdb2_in_client_trans() {
+    struct sql_thread *thd = pthread_getspecific(query_info_key);
+    if (thd == NULL)
+        return 0;
+
+    struct sqlclntstate *clnt = thd->clnt;
+    if (clnt == NULL)
+        return 0;
+
+    return clnt->in_client_trans;
+}
+
 void reset_clnt(struct sqlclntstate *clnt, int initial)
 {
     if (initial) {
@@ -5431,7 +5449,7 @@ void reset_clnt(struct sqlclntstate *clnt, int initial)
     }
     free(clnt->context);
     if (clnt->authdata) {
-        free(clnt->authdata);
+        free_authdata(clnt);
         clnt->authdata = NULL;
     }
     clnt->context = NULL;
@@ -6814,6 +6832,10 @@ void *internal_get_authdata(struct sqlclntstate *a)
         return a->authdata;
     return NULL;
 }
+int internal_free_authdata(struct sqlclntstate *a)
+{
+    return 0;
+}
 static int internal_local_check(struct sqlclntstate *a)
 {
     return 1;

plugins/newsql/newsql.c

@@ -2530,6 +2530,7 @@ void free_newsql_appdata(struct sqlclntstate *clnt)
 }
 
 void *(*externalMakeNewsqlAuthData)(void *, CDB2SQLQUERY__IdentityBlob *id) = NULL;
+void (*externalFreeNewsqlAuthData)(void *) = NULL;
 
 static void *newsql_get_authdata(struct sqlclntstate *clnt)
 {
@@ -2547,12 +2548,21 @@ static void *newsql_get_authdata(struct sqlclntstate *clnt)
 
     }
     if (clnt->authdata) {
-        free(clnt->authdata);
+        externalFreeNewsqlAuthData(clnt->authdata);
         clnt->authdata = NULL;
     }
     return NULL;
 }
 
+static int newsql_free_authdata(struct sqlclntstate *clnt)
+{
+    if (clnt->authdata) {
+        externalFreeNewsqlAuthData(clnt->authdata);
+        clnt->authdata = NULL;
+    }
+    return 0;
+}
+
 void newsql_setup_clnt(struct sqlclntstate *clnt)
 {
     struct newsql_appdata *appdata = clnt->appdata;

tests/tunables.test/t00_all_tunables.expected

@@ -30,6 +30,7 @@
 (name='allow_mismatched_tag_size', description='Allow variants in padding in static tag struct sizes', type='BOOLEAN', value='OFF', read_only='N')
 (name='allow_negative_column_size', description='Allow negative column size in csc2 schema. Added mostly for backwards compatibility. (Default: off)', type='BOOLEAN', value='OFF', read_only='Y')
 (name='allow_offline_upgrades', description='Allow machines marked offline to become master.', type='BOOLEAN', value='OFF', read_only='N')
+(name='allow_old_authn', description='Reuse old successful authentication for the connection', type='BOOLEAN', value='ON', read_only='N')
 (name='allow_parallel_rep_on_pagesplit', description='allow parallel rep on pgsplit', type='BOOLEAN', value='ON', read_only='N')
 (name='allow_parallel_rep_on_prefix', description='allow parallel rep on bam_prefix', type='BOOLEAN', value='ON', read_only='N')
 (name='allow_portmux_route', description='', type='BOOLEAN', value='ON', read_only='Y')