tid

Signed-off-by: mohitkhullar <mkhullar1@bloomberg.net>

Author: mohitkhullar

db/comdb2.c

@@ -236,7 +236,7 @@ int gbl_uses_password;
 int gbl_unauth_tag_access = 0;
 int64_t gbl_num_auth_allowed = 0;
 int64_t gbl_num_auth_denied = 0;
-int gbl_allow_old_authn = 0;
+int gbl_allow_old_authn = 1;
 int gbl_uses_externalauth = 0;
 int gbl_uses_externalauth_connect = 0;
 int gbl_externalauth_warn = 0;

db/db_tunables.h

@@ -2384,7 +2384,7 @@ REGISTER_TUNABLE("merge_table_enabled",
                  NULL, NULL);
 
 REGISTER_TUNABLE("allow_old_authn", "Reuse old successful authentication for the connection",
-                 TUNABLE_BOOLEAN, &gbl_uses_externalauth, NOARG | READEARLY,
+                 TUNABLE_BOOLEAN, &gbl_allow_old_authn, NOARG | READEARLY,
                  NULL, NULL, NULL, NULL);
 
 REGISTER_TUNABLE("externalauth", NULL, TUNABLE_BOOLEAN, &gbl_uses_externalauth, NOARG | READEARLY,

db/sqlinterfaces.c

@@ -5289,6 +5289,22 @@ void cleanup_clnt(struct sqlclntstate *clnt)
 int gbl_unexpected_last_type_warn = 1;
 int gbl_unexpected_last_type_abort = 0;
 
+/* Not final */
+int cdb2_get_tid() {
+    struct sql_thread *thd = pthread_getspecific(query_info_key);
+    if (thd == NULL)
+        return 0;
+
+    struct sqlclntstate *clnt = thd->clnt;
+    if (clnt == NULL)
+        return 0;
+
+    if (clnt->dbtran.cursor_tran)
+        return clnt->dbtran.cursor_tran->id;
+
+    return 0;
+}
+
 void reset_clnt(struct sqlclntstate *clnt, int initial)
 {
     if (initial) {

tests/tunables.test/t00_all_tunables.expected

@@ -30,7 +30,7 @@
 (name='allow_mismatched_tag_size', description='Allow variants in padding in static tag struct sizes', type='BOOLEAN', value='OFF', read_only='N')
 (name='allow_negative_column_size', description='Allow negative column size in csc2 schema. Added mostly for backwards compatibility. (Default: off)', type='BOOLEAN', value='OFF', read_only='Y')
 (name='allow_offline_upgrades', description='Allow machines marked offline to become master.', type='BOOLEAN', value='OFF', read_only='N')
-(name='allow_old_authn', description='Reuse old successful authentication for the connection', type='BOOLEAN', value='OFF', read_only='N')
+(name='allow_old_authn', description='Reuse old successful authentication for the connection', type='BOOLEAN', value='ON', read_only='N')
 (name='allow_parallel_rep_on_pagesplit', description='allow parallel rep on pgsplit', type='BOOLEAN', value='ON', read_only='N')
 (name='allow_parallel_rep_on_prefix', description='allow parallel rep on bam_prefix', type='BOOLEAN', value='ON', read_only='N')
 (name='allow_portmux_route', description='', type='BOOLEAN', value='ON', read_only='Y')