Commit e80381e
committed
Fix enum value collision between AllocatorType and ObjectTrackingEvent
The ObjectTrackingEvent enum values were colliding with AllocatorType
values. This caused a bug where OBJECT_DESTROYED (value 2) was
incorrectly matching PYOBJECT_MALLOC in the deallocation check.
This would incorrectly treat pymalloc allocations as deallocations when
checking stack traces. The bug went undetected because we lacked tests
for Python allocations with trace_python_allocators enabled.
Fixed by changing ObjectTrackingEvent values to 10 and 20 to avoid
collision. Added test coverage for pymalloc allocations with Python
stack traces to prevent regressions.
Signed-off-by: Pablo Galindo Salgado <[email protected]>1 parent 6cfb8a4 commit e80381e
2 files changed
+50
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
| 131 | + | |
| 132 | + | |
131 | 133 | | |
132 | | - | |
133 | | - | |
| 134 | + | |
| 135 | + | |
134 | 136 | | |
135 | 137 | | |
136 | 138 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1630 | 1630 | | |
1631 | 1631 | | |
1632 | 1632 | | |
| 1633 | + | |
| 1634 | + | |
| 1635 | + | |
| 1636 | + | |
| 1637 | + | |
| 1638 | + | |
| 1639 | + | |
| 1640 | + | |
| 1641 | + | |
| 1642 | + | |
| 1643 | + | |
| 1644 | + | |
| 1645 | + | |
| 1646 | + | |
| 1647 | + | |
| 1648 | + | |
| 1649 | + | |
| 1650 | + | |
| 1651 | + | |
| 1652 | + | |
| 1653 | + | |
| 1654 | + | |
| 1655 | + | |
| 1656 | + | |
| 1657 | + | |
| 1658 | + | |
| 1659 | + | |
| 1660 | + | |
| 1661 | + | |
| 1662 | + | |
| 1663 | + | |
| 1664 | + | |
| 1665 | + | |
| 1666 | + | |
| 1667 | + | |
| 1668 | + | |
| 1669 | + | |
| 1670 | + | |
| 1671 | + | |
| 1672 | + | |
| 1673 | + | |
| 1674 | + | |
| 1675 | + | |
| 1676 | + | |
| 1677 | + | |
| 1678 | + | |
1633 | 1679 | | |
1634 | 1680 | | |
1635 | 1681 | | |
| |||
0 commit comments