feat: disable docker in docker

blooop · blooop · commit 4394aa9d6cf3 · 2024-10-14T13:07:46.000Z
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -22,9 +22,10 @@
 			]
 		}
 	},
-	"features": {
-      "ghcr.io/devcontainers/features/docker-in-docker:2": {}
-    },
+	//docker in docker is included in the pixi devcontainer example, but disabling for the moment due to security issues
+	// "features": {
+    //   "ghcr.io/devcontainers/features/docker-in-docker:2": {}
+    // },
     "mounts": ["source=${localWorkspaceFolderBasename}-pixi,target=${containerWorkspaceFolder}/.pixi,type=volume"],
     "postCreateCommand": "sudo chown vscode .pixi && pixi install"
 }

Original file line number	Diff line number	Diff line change
`@@ -22,9 +22,10 @@`
`22`	`22`	`]`
`23`	`23`	`}`
`24`	`24`	`},`
`25`		`- "features": {`
`26`		`- "ghcr.io/devcontainers/features/docker-in-docker:2": {}`
`27`		`- },`
	`25`	`+ //docker in docker is included in the pixi devcontainer example, but disabling for the moment due to security issues`
	`26`	`+ // "features": {`
	`27`	`+ // "ghcr.io/devcontainers/features/docker-in-docker:2": {}`
	`28`	`+ // },`
`28`	`29`	`"mounts": ["source=${localWorkspaceFolderBasename}-pixi,target=${containerWorkspaceFolder}/.pixi,type=volume"],`
`29`	`30`	`"postCreateCommand": "sudo chown vscode .pixi && pixi install"`
`30`	`31`	`}`