Revert "[pdf] Change IsPdfExtensionUrl() to IsPdfExtensionOrigin()"

This reverts commit db57e30.

Reason for revert: breaks builds in several perf bots
https://ci.chromium.org/ui/p/chrome/builders/ci/linux-builder-perf/349623/overview

Original change's description:
> [pdf] Change IsPdfExtensionUrl() to IsPdfExtensionOrigin()
>
> The check really pertains to the origin, not the entire URL. It also
> allows for a merging of logic between IsPdfExtensionOrigin() and
> IsPdfInternalPluginAllowedOrigin(). Furthermore, it makes the function
> more appropriate for security checks.
>
> Use IsPdfInternalPluginAllowedOrigin() in the implementation of
> ChromePrintRenderFrameHelperDelegate::GetPdfElement().
>
> Change-Id: Ia8a6bb99a9e2d19b8bc857525ac74ac93e29c565
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200416
> Commit-Queue: Daniel Hosseinian <[email protected]>
> Reviewed-by: Lei Zhang <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#927504}

NOTREECHECKS

Change-Id: Id8f4ceb05d79e5f93af6e42aaaae8398103b3ed8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201368
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Johann Koenig <[email protected]>
Commit-Queue: Johann Koenig <[email protected]>
Owners-Override: Johann Koenig <[email protected]>
Cr-Commit-Position: refs/heads/main@{#927565}

Author: Sadrul Chowdhury

chrome/browser/chrome_content_browser_client.cc

@@ -2920,7 +2920,7 @@ bool UpdatePreferredColorScheme(WebPreferences* web_prefs,
   if (!base::FeatureList::IsEnabled(features::kWebUIDarkMode)) {
     // Update based on last committed url.
     force_light = force_light || url.SchemeIs(content::kChromeUIScheme);
-    force_light = force_light || IsPdfExtensionOrigin(url::Origin::Create(url));
+    force_light = force_light || IsPdfExtensionUrl(url);
   }
 
   // Reauth WebUI doesn't support dark mode yet because it shares the dialog

chrome/browser/renderer_context_menu/render_view_context_menu.cc

@@ -2269,8 +2269,7 @@ bool RenderViewContextMenu::IsCommandIdEnabled(int id) const {
       // Rotate commands should be disabled when in PDF Viewer's Presentation
       // mode.
       is_pdf_viewer_fullscreen =
-          IsPdfExtensionOrigin(url::Origin::Create(GetDocumentURL(params_))) &&
-          IsHTML5Fullscreen();
+          IsPdfExtensionUrl(GetDocumentURL(params_)) && IsHTML5Fullscreen();
 #endif
       return !is_pdf_viewer_fullscreen &&
              (params_.media_flags & ContextMenuData::kMediaCanRotate) != 0;

chrome/common/pdf_util.cc

@@ -39,18 +39,23 @@ std::string GetPDFPlaceholderHTML(const GURL& pdf_url) {
   return webui::GetI18nTemplateHtml(template_html, &values);
 }
 
-bool IsPdfExtensionOrigin(const url::Origin& origin) {
+bool IsPdfExtensionUrl(const GURL& url) {
 #if BUILDFLAG(ENABLE_EXTENSIONS)
-  return origin.scheme() == extensions::kExtensionScheme &&
-         origin.host() == extension_misc::kPdfExtensionId;
+  return url.SchemeIs(extensions::kExtensionScheme) &&
+         url.host_piece() == extension_misc::kPdfExtensionId;
 #else
   return false;
 #endif
 }
 
 bool IsPdfInternalPluginAllowedOrigin(const url::Origin& origin) {
-  if (IsPdfExtensionOrigin(origin))
+#if BUILDFLAG(ENABLE_EXTENSIONS)
+  // Allow embedding the internal PDF plugin in the built-in PDF extension.
+  if (origin.scheme() == extensions::kExtensionScheme &&
+      origin.host() == extension_misc::kPdfExtensionId) {
     return true;
+  }
+#endif  // BUILDFLAG(ENABLE_EXTENSIONS)
 
   // Allow embedding the internal PDF plugin in chrome://print.
   if (origin == url::Origin::Create(GURL(chrome::kChromeUIPrintURL)))

chrome/common/pdf_util.h

@@ -30,8 +30,8 @@ void ReportPDFLoadStatus(PDFLoadStatus status);
 // Returns the HTML contents of the placeholder.
 std::string GetPDFPlaceholderHTML(const GURL& pdf_url);
 
-// Returns whether `origin` is for the built-in PDF extension.
-bool IsPdfExtensionOrigin(const url::Origin& origin);
+// Returns `true` if `url` is for the built-in PDF extension.
+bool IsPdfExtensionUrl(const GURL& url);
 
 // Returns `true` if the origin is allowed to create the internal PDF plugin.
 // Note that for the Pepper-free plugin, this applies to the origin of the

chrome/renderer/printing/chrome_print_render_frame_helper_delegate.cc

@@ -9,14 +9,14 @@
 #include "base/command_line.h"
 #include "base/strings/string_util.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/common/url_constants.h"
 #include "content/public/renderer/render_frame.h"
 #include "extensions/buildflags/buildflags.h"
 #include "mojo/public/cpp/bindings/remote.h"
 #include "third_party/blink/public/common/browser_interface_broker_proxy.h"
 #include "third_party/blink/public/web/web_document.h"
 #include "third_party/blink/public/web/web_element.h"
 #include "third_party/blink/public/web/web_local_frame.h"
-#include "url/origin.h"
 
 #if BUILDFLAG(ENABLE_EXTENSIONS)
 #include "chrome/common/pdf_util.h"
@@ -33,7 +33,8 @@ ChromePrintRenderFrameHelperDelegate::~ChromePrintRenderFrameHelperDelegate() =
 blink::WebElement ChromePrintRenderFrameHelperDelegate::GetPdfElement(
     blink::WebLocalFrame* frame) {
 #if BUILDFLAG(ENABLE_EXTENSIONS)
-  if (IsPdfInternalPluginAllowedOrigin(frame->GetSecurityOrigin())) {
+  GURL url = frame->GetDocument().Url();
+  if (url.GetOrigin() == chrome::kChromeUIPrintURL || IsPdfExtensionUrl(url)) {
     // <object> with id="plugin" is created in
     // chrome/browser/resources/pdf/pdf_viewer_base.js.
     auto viewer_element = frame->GetDocument().GetElementById("viewer");