Building help

[harryfornasier]

Wondering if someone could help me. I'm on MacOS 12.6 using Xcode 14.0.1. I'm getting stuck generating the build files with an error:

src % gn gen ../out/release
ERROR at //.gn:70:20: Assignment had no effect.
no_check_targets = [
                   ^
You set the variable "no_check_targets" here and it was unused before it went
out of scope.

Is there something i've missed? Don't know if it's relevant but earlier I was getting an error with "should_use_hermetic_xcode.py" but that seems to have gone away.

[blueboxd]

Hi, sorry for the late response 🙇

I haven't seen that error...
Maybe args.gn or another .gn/.gni file is corrupt?

Please try updated Building script/steps.
In my env (macOS 12.5.1/Xcode 14.0.1), at least the build started without issues.

[harryfornasier]

Wondering if someone could help me again. I attempted building this last year but I couldn't get it to work so I'm trying this year. For some reason when I run this:

curl https://gist.githubusercontent.com/blueboxd/c1f355fb6fe829e98ff5453880683993/raw/744c2352501afb7b0ca184a788580de2149e0872/build.sh | bash

I get "/chromium-project/chromium-legacy/.gclient_entries missing, .gclient file in parent directory /Users/harry/chromium-project/chromium-legacy might not be the file you want to use."

"Could not find gn executable at: /Users/harry/chromium-project/chromium-legacy/src/buildtools/Mac/gn"

Is there a prerequisite I missed? I was a bit confused by that patched clang prerequisite, is that installed with that script? or do I have to do that first? I followed this link given (https://github.com/llvm-project) but I couldn't find exactly what it was I needed to download.

[harryfornasier]

I thought i'd have another go at building chromium-legacy. I think the path was messed up somehow as I redid it and it seems to have gotten further. When trying to run gn gen ../out/release i'm getting this error, wondering if you have any ideas:

ERROR at //build/config/compiler/BUILD.gn:698:5: Assertion failed.
    assert(use_lld, "LTO is only supported with lld")
    ^-----
LTO is only supported with lld
See //build/config/BUILDCONFIG.gn:348:3: which caused the file to be included.
  "//build/config/compiler:no_unresolved_symbols",
  ^----------------------------------------------

[krackers]

I think @Wowfunhappy ran into something similar, in his instructions https://github.com/blueboxd/chromium-legacy/wiki/Building/5889ea84de011c9fee58f0db63b246a5227178ea he disabled use_thin_lto

[harryfornasier]

Thanks, those steps seemed to have helped. Unfortunately, it seems i'm unable to do step 3 on the list. The build file referenced has changed I think. It now says:

 # Normally, this would be defined in the `runtime_library` config but NaCl
  # saigo libc++ does not use the custom hermetic libc++. Unfortunately, there
  # isn't really a better config to add this define for the define to
  # consistently apply in both Chromium and non-Chromium code *and* non-NaCl
  # and NaCl code.
  #
  # TODO(https://crbug.com/702997): Move this back to the `runtime_library`
  # config when NaCl is removed.
  if (use_safe_libcxx) {
    defines += [ "_LIBCPP_ENABLE_ASSERTIONS=1" ]
    cflags_cc += [ "-stdlib=libc++" ]
    ldflags += [ "-stdlib=libc++" ]
   }
 }

I still tried to add in the two lines cflags_cc += [ "-stdlib=libc++" ] and ldflags += [ "-stdlib=libc++" ] like wowhappyfun did but they weren't there originally. I also noticed that chrome/installer/gcapi_mac/BUILD.gn has changed in chromium@672ec2f. it now says this instead:

config("gcapi_config") {
  # gcapi can be bundled with installers of other software, which might run
  # on older macOS versions than chrome itself. To not making a dependency on
  # gcapi a problem for these installers, make it target a very old version
  # of macOS.**
  min_version = "10.9" # Was 10.12
  cflags = [
    "-isysroot",
    rebase_path(sysroot, root_build_dir),
    "-mmacos-version-min=$min_version",
++ "-stdlib=libc++",  # TODO(thakis): Remove once min_version >= 10.9.
  ]
  ldflags = [
    "-isysroot",
    rebase_path(sysroot, root_build_dir),
    "-mmacos-version-min=$min_version",
++    "-stdlib=libc++",  # TODO(thakis): Remove once min_version >= 10.9.
  ]
}

I tried to edit this file too by adding the lines changing 10.12 to 10.9 and adding in the missing lines but I'm not sure if it actually made a difference.

When I run the build command, It seems to be failing on shared_mutex:

[12616/56464] CXX obj/third_party/vulkan-deps/vulkan-validation-layers/src/vulkan_layer_utils/vk_format_utils.o
FAILED: obj/third_party/vulkan-deps/vulkan-validation-layers/src/vulkan_layer_utils/vk_format_utils.o 
../../../clang-master/bin/clang++ -MMD -MF obj/third_party/vulkan-deps/vulkan-validation-layers/src/vulkan_layer_utils/vk_format_utils.o.d -DXXH_NO_LONG_LONG -DOFFICIAL_BUILD -DCR_XCODE_VERSION=1420 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DVULKAN_NON_CMAKE_BUILD -DVK_ENABLE_BETA_EXTENSIONS -DVK_USE_PLATFORM_METAL_EXT -I../../src/third_party/vulkan-deps/vulkan-validation-layers/src/layers -I../../src/third_party/vulkan-deps/vulkan-validation-layers/src/layers/external -I../../src/third_party/vulkan-deps/vulkan-validation-layers/src/layers/vulkan -I../../src -Igen -I../../src/third_party/vulkan-deps/vulkan-headers/src/include -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing -fstack-protector -femit-dwarf-unwind=no-compact-unwind -faligned-allocation -fcolor-diagnostics -fmerge-all-constants -fcrash-diagnostics-dir=../../src/tools/clang/crashreports -mllvm -instcombine-lower-dbg-declare=0 -ffp-contract=off -arch x86_64 -ftrivial-auto-var-init=pattern -O2 -fno-omit-frame-pointer -g2 -gdwarf-aranges -Xclang -debug-info-kind=limited -isysroot ../../../../../../Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk -mmacos-version-min=10.9 -fprofile-instr-use=/Users/fornasier/chromium-project/chromium-legacy/src/chrome/build/pgo_profiles/chrome-mac-main-1687132334-cee0a7f66e5955067075eb72b656e2d07e47e249.profdata -Wno-profile-instr-unprofiled -Wno-profile-instr-out-of-date -Wno-backend-plugin -mllvm -enable-ext-tsp-block-placement=1 -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wall -Wno-unused-variable -Wno-c++11-narrowing -Wno-unused-but-set-variable -Wno-misleading-indentation -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration -Wno-logical-op-parentheses -Wenum-compare-conditional -Wno-ignored-pragma-optimize -Wno-deprecated-builtins -Wno-bitfield-constant-conversion -Wno-deprecated-this-capture -Wno-unused-function -Wno-unguarded-availability-new -Wno-extra-semi -Wno-redundant-parens -std=c++20 -Wno-trigraphs -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -std=c++17 -Wno-nullability-completeness -c ../../src/third_party/vulkan-deps/vulkan-validation-layers/src/layers/vulkan/generated/vk_format_utils.cpp -o obj/third_party/vulkan-deps/vulkan-validation-layers/src/vulkan_layer_utils/vk_format_utils.o
In file included from ../../src/third_party/vulkan-deps/vulkan-validation-layers/src/layers/vulkan/generated/vk_format_utils.cpp:25:
../../src/third_party/vulkan-deps/vulkan-validation-layers/src/layers/utils/vk_layer_utils.h:568:31: error: 'shared_mutex' is unavailable: introduced in macOS 10.12
typedef std::shared_lock<std::shared_mutex> ReadLockGuard;
                              ^
../../../../../../Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk/usr/include/c++/v1/shared_mutex:180:58: note: 'shared_mutex' has been explicitly marked unavailable here
class _LIBCPP_TYPE_VIS _LIBCPP_AVAILABILITY_SHARED_MUTEX shared_mutex

On a separate note everytime I close the terminal I basically have to start from scratch if I go back and try to run either gn or ninja I get "gn unknown command". I try to re-add it to the path but it just doesn't seem to register or something.

Edit: here's also my terminal output, sorry it's so long it's because I couldn't close the terminal
Terminal Saved Output.pdf

[krackers]

Maybe try skipping steps 3 and 4. The error you're seeing is because you changed the 10.12 to 10.9. Adding -stdlib-libc++ may not be necessary now anymore.

[krackers]

I try to re-add it to the path but it just doesn't seem to register or something.

How are you adding to path? Just doing export PATH=foo doesn't make it persist across sessions, you need to put it in bashrc or equivalent so it gets loaded for each session.

[harryfornasier]

Maybe try skipping steps 3 and 4. The error you're seeing is because you changed the 10.12 to 10.9. Adding -stdlib-libc++ may not be necessary now anymore.

So I started from scratch to get rid of anything I might have changed. When trying to make the build files i'm getting this error:

ERROR at //content/test/BUILD.gn:3143:5: Replacing nonempty list.
    weak_frameworks = [ "ScreenCaptureKit.framework" ]  # macOS 12.3
    ^--------------
This overwrites a previously-defined nonempty list with another nonempty list.
See //content/test/BUILD.gn:3140:23: for previous definition
    weak_frameworks = [
                      ^
Did you mean to append/modify instead? If you really want to overwrite, do:
  foo = []
before reassigning.
See //BUILD.gn:190:9: which caused the file to be included.
        "//content/test:content_browsertests",
        ^------------------------------------

Adding in use_thin_lto like wowhappyfun did doesn't seem to change anything.

How are you adding to path? Just doing export PATH=foo doesn't make it persist across sessions, you need to put it in bashrc or equivalent so it gets loaded for each session.

Realised I was using the wrong line to add it to the path, so this is fixed now

[krackers]

Hm yeah idk why it didn't work then. I'd probably just go through the steps in the bash script manually, ensuring that the bluebox version is currently checked out for each of the out-of-tree deps

[krackers]

Also I believe running gclient sync will reset deps, because the git specified in the DEPS file is to the upstream one, not bluebox fork:

https://github.com/blueboxd/chromium-legacy/blob/master.lion/DEPS#L1814

[harryfornasier]

Also I believe running gclient sync will reset deps, because the git specified in the DEPS file is to the upstream one, not bluebox fork:

Ahh I see, do gclient sync -v --no-history and gclient sync -D do the same thing? Because running gclient sync -D fixed the problem I was having earlier with the regex.

[krackers]

-D does the following:

parser.add_option('-D', '--delete_unversioned_trees', action='store_true',
--
  | help='Deletes from the working copy any dependencies that '
  | 'have been removed since the last sync, as long as '
  | 'there are no local modifications. When used with '
  | '--force, such dependencies are removed even if they '
  | 'have local modifications. When used with --reset, '
  | 'all untracked directories are removed from the '
  | 'working copy, excluding those which are explicitly '
  | 'ignored in the repository.')

[krackers]

I just recommend using a clean clone each time, because git submodules have never worked well for me

[harryfornasier]

Starting from scratch completely and running the tldr script gets this error:

ninja: error: '../../../clang-master/lib/clang/18/lib/darwin/libclang_rt.osx.a', needed by 'obj/third_party/protobuf/libprotoc_lib.a', missing and no known rule to make it

I understand why this is happening as the the clang folder only contains clang 17 not clang 18. I also noticed that in Blueboxd's recent update of the building instructions it mentions needing clang 18+. However, I can't seem to find how to install clang 18. How do I install clang 18?

[krackers]

maybe via macports?

[harryfornasier]

It seems like it's not an official release yet, so i'd have to build it from source. I looked at the documentation and I did manage to get something built, but i'm not exactly sure what the build commands are to build what I need for chromium-legacy

[krackers]

I think you can set

echo "clang_base_path=\"`pwd`\"" >> ../chromium-legacy/out/release/args.gn

similar to what used to be done to use bluebox's patched clang. In terms of what needs to be built though, not sure... presumably everything that used to be provided in https://github.com/blueboxd/llvm-project/releases/download/main/main.tar.xz