chore: Update CI workflow and fix string parsing

devin-ai-integration[bot] · rayozzie · devin-ai-integration[bot] · commit fab3b5180343 · 2025-01-29T20:15:59.000Z
Co-Authored-By: ray@blues.com &lt;ray@blues.com&gt;
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -4,7 +4,7 @@ jobs:
   test:
     strategy:
       matrix:
-        go-version: [1.16.x]
+        go-version: [1.21.x]
         os: [ubuntu-latest]
     runs-on: ${{ matrix.os }}
     steps:
@@ -16,8 +16,8 @@ jobs:
       uses: actions/checkout@v2
     - name: Install dependencies
       run: |
-        go get -u honnef.co/go/tools/cmd/staticcheck@latest
-        go get -u golang.org/x/tools/cmd/goimports
+        go install honnef.co/go/tools/cmd/staticcheck@v0.2.2
+        go install golang.org/x/tools/cmd/goimports@v0.1.10
     - name: Run staticcheck
       run: staticcheck ./...
     - name: Check code formatting
diff --git a/jparse/node.go b/jparse/node.go
@@ -30,20 +30,20 @@ type StringNode struct {
 }
 
 func parseString(p *parser, t token) (Node, error) {
+	if t.Value == "" {
+		return nil, newError(ErrSyntaxError, t)
+	}
 
 	s, ok := unescape(t.Value)
 	if !ok {
 		typ := ErrIllegalEscape
 		if len(s) > 0 && s[0] == 'u' {
 			typ = ErrIllegalEscapeHex
 		}
-
 		return nil, newErrorHint(typ, t, s)
 	}
 
-	return &StringNode{
-		Value: s,
-	}, nil
+	return &StringNode{Value: s}, nil
 }
 
 func (n *StringNode) optimize() (Node, error) {

Original file line number	Diff line number	Diff line change
`@@ -30,20 +30,20 @@ type StringNode struct {`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`func parseString(p *parser, t token) (Node, error) {`
	`33`	`+ if t.Value == "" {`
	`34`	`+ return nil, newError(ErrSyntaxError, t)`
	`35`	`+ }`
`33`	`36`
`34`	`37`	`s, ok := unescape(t.Value)`
`35`	`38`	`if !ok {`
`36`	`39`	`typ := ErrIllegalEscape`
`37`	`40`	`if len(s) > 0 && s[0] == 'u' {`
`38`	`41`	`typ = ErrIllegalEscapeHex`
`39`	`42`	`}`
`40`		`-`
`41`	`43`	`return nil, newErrorHint(typ, t, s)`
`42`	`44`	`}`
`43`	`45`
`44`		`- return &StringNode{`
`45`		`- Value: s,`
`46`		`- }, nil`
	`46`	`+ return &StringNode{Value: s}, nil`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`func (n *StringNode) optimize() (Node, error) {`