fix: registration with a prefix (#1260)

* tst: Register with a prefix

* fix: Apply default key_for_filename

* fix: Delete _contents_ of registration target, not target itself

* chore: update CHANGELOG

Author: danielballan

CHANGELOG.md

@@ -10,6 +10,7 @@ Write the date in place of the "Unreleased" in the case a new version is release
 - Add ExternalPolicyDecisionPoint for authorization and an example with Open Policy Agent
 
 ### Changed
+
 - Rename "create" scope to the more explicit "create:node"
 - Split "apikeys" scope into "create:apikeys" and "revoke:apikeys" scopes
 
@@ -19,6 +20,7 @@ Write the date in place of the "Unreleased" in the case a new version is release
 - Allow clients to register standalone data directories as single nodes
   (e.g. Zarr stores) directly rather than discovering them by walking their
   parent directory.
+- Fix regression that broke registering files at a prefix.
 
 ## v0.2.2 (2025-11-25)
 

tiled/_tests/test_directory_walker.py

@@ -96,6 +96,24 @@ async def test_same_filename_separate_directory(tmpdir):
         assert "a" in client["two"]
 
 
+@pytest.mark.asyncio
+async def test_register_prefix(tmpdir):
+    "Register under a prefix"
+    df1.to_csv(Path(tmpdir, "a.csv"))
+    catalog = in_memory(writable_storage=str(tmpdir))
+    with Context.from_app(build_app(catalog)) as context:
+        client = from_context(context)
+        x = client.create_container("x")
+        y = x.create_container("y")
+        y.create_container("z")  # will be overwritten
+        # Test that node is present.
+        client["x", "y", "z"]
+        await register(client, tmpdir, prefix="/x/y")
+        # New node is present; old contents were overwritten.
+        assert "a" in client["x/y"]
+        assert "z" not in client["x/y"]
+
+
 @pytest.mark.asyncio
 async def test_mimetype_detection_hook(tmpdir):
     content = "a, b, c\n1, 2 ,3\n4, 5, 6\n"

tiled/client/register.py

@@ -164,7 +164,7 @@ async def register(
     for segment in prefix_parts:
         child_node = await anyio.to_thread.run_sync(node.get, segment)
         if child_node is None:
-            key = key_from_filename(segment)
+            key = settings.key_from_filename(segment)
             await create_node_or_drop_collision(
                 node,
                 structure_family=StructureFamily.container,
@@ -186,7 +186,9 @@ async def register(
         if overwrite:
             logger.info(f"  Overwriting '/{'/'.join(prefix_parts)}'")
             # TODO When we have a tiled AsyncClient, use that.
-            await anyio.to_thread.run_sync(partial(node.delete, recursive=True))
+            await anyio.to_thread.run_sync(
+                partial(node.delete_contents, recursive=True)
+            )
         await _walk(node, Path(path), parsed_walkers, settings=settings)
     else:
         await register_single_item(node, path, is_directory=False, settings=settings)