Fix LDAPAuthenticator tests

Author: tpoliaw

tiled/_tests/test_authenticators.py

@@ -50,12 +50,15 @@ async def testing():
 
     asyncio.run(testing())
 
-def test_ldap_validation():
-    # single address, port can be none
+def test_ldap_port_validation():
+    # port can be none
     auth = LDAPAuthenticator(server_address="http://ldap.example.com", server_port=None)
     assert auth.server_port is not None
+
+def test_auth_server_list_wrapping():
+    auth = LDAPAuthenticator(server_address="http://ldap.example.com", server_port=None)
     assert auth.server_address_list == ["http://ldap.example.com"]
 
-    # list of addresses aren't nested into extra list
+def test_list_of_addresses_not_nested_into_extra_list():
     auth = LDAPAuthenticator(server_address=["http://ldap.example.com"])
     assert auth.server_address_list == ["http://ldap.example.com"]

tiled/authenticators.py

@@ -507,7 +507,7 @@ class LDAPAuthenticator(InternalAuthenticator):
     def ignore_nones(cls, data: Any) -> Any:
         if isinstance(data, dict):
             if data.get("server_port") is None:
-                data.pop("server_port")
+                data.pop("server_port", None)
         return data
 
     async def resolve_username(self, username_supplied_by_user):