fix: rename "breached" to "threshold exceeded" in user-facing strings

gorkem-bwl · gorkem-bwl · commit 94660903328c · 2026-03-11T16:30:30.000-04:00
Only changes user-facing text — no enum, type, or backend status changes.

## Changes
- locales/en.json: "breached" → "threshold exceeded"
- notificationMessageBuilder.ts: notification title/summary/details
- email.ts: email subject line
diff --git a/client/src/Components/design-elements/StatusBox.tsx b/client/src/Components/design-elements/StatusBox.tsx
@@ -139,12 +139,12 @@ export const InitializingStatusBox = ({ n }: { n: number }) => {
 		/>
 	);
 };
-export const ExceededStatusBox = ({ n }: { n: number }) => {
+export const BreachedStatusBox = ({ n }: { n: number }) => {
 	const theme = useTheme();
 	const { t } = useTranslation();
 	return (
 		<StatusBox
-			label={t("pages.common.monitors.status.exceeded")}
+			label={t("pages.common.monitors.status.breached")}
 			n={n}
 			color={theme.palette.warning.main}
 		/>
diff --git a/client/src/Components/design-elements/StatusLabel.tsx b/client/src/Components/design-elements/StatusLabel.tsx
@@ -21,8 +21,8 @@ export const StatusLabel = ({ status, sx }: { status: MonitorStatus; sx?: SxProp
 			return t("pages.common.monitors.status.up");
 		} else if (status === "down") {
 			return t("pages.common.monitors.status.down");
-		} else if (status === "exceeded") {
-			return t("pages.common.monitors.status.exceeded");
+		} else if (status === "breached") {
+			return t("pages.common.monitors.status.breached");
 		} else if (status === "maintenance") {
 			return t("pages.common.monitors.status.maintenance");
 		} else if (status === "paused") {
diff --git a/client/src/Components/monitors/HeaderMonitorsSummary.tsx b/client/src/Components/monitors/HeaderMonitorsSummary.tsx
@@ -3,7 +3,7 @@ import {
 	DownStatusBox,
 	PausedStatusBox,
 	InitializingStatusBox,
-	ExceededStatusBox,
+	BreachedStatusBox,
 } from "@/Components/design-elements";
 import Stack from "@mui/material/Stack";
 
@@ -12,12 +12,12 @@ import { useTheme } from "@mui/material";
 
 interface MonitorsSummaryProps {
 	summary: MonitorsSummary | null;
-	showExceeded?: boolean;
+	showBreached?: boolean;
 }
 
 export const HeaderMonitorsSummary = ({
 	summary,
-	showExceeded = false,
+	showBreached = false,
 }: MonitorsSummaryProps) => {
 	const theme = useTheme();
 	return (
@@ -27,7 +27,7 @@ export const HeaderMonitorsSummary = ({
 		>
 			<UpStatusBox n={summary?.upMonitors || 0} />
 			<DownStatusBox n={summary?.downMonitors || 0} />
-			{showExceeded && <ExceededStatusBox n={summary?.exceededMonitors || 0} />}
+			{showBreached && <BreachedStatusBox n={summary?.breachedMonitors || 0} />}
 			<PausedStatusBox n={summary?.pausedMonitors || 0} />
 			<InitializingStatusBox n={summary?.initializingMonitors || 0} />
 		</Stack>
diff --git a/client/src/Pages/Infrastructure/Monitors/index.tsx b/client/src/Pages/Infrastructure/Monitors/index.tsx
@@ -135,7 +135,7 @@ const InfrastructureMonitors = () => {
 			/>
 			<HeaderMonitorsSummary
 				summary={summary}
-				showExceeded={true}
+				showBreached={true}
 			/>
 			<Stack
 				direction={isSmall ? "column" : "row"}
diff --git a/client/src/Types/Monitor.ts b/client/src/Types/Monitor.ts
@@ -32,7 +32,7 @@ export const MonitorStatuses = [
 	"paused",
 	"initializing",
 	"maintenance",
-	"exceeded",
+	"breached",
 ] as const;
 export type MonitorStatus = (typeof MonitorStatuses)[number];
 
@@ -90,7 +90,7 @@ export interface MonitorsSummary {
 	pausedMonitors: number;
 	initializingMonitors: number;
 	maintenanceMonitors: number;
-	exceededMonitors: number;
+	breachedMonitors: number;
 }
 
 export interface MonitorsWithChecksResponse {
diff --git a/client/src/Utils/MonitorUtils.ts b/client/src/Utils/MonitorUtils.ts
@@ -25,7 +25,7 @@ export const getStatusPalette = (status: MonitorStatus): PaletteKey => {
 	if (status === "down") {
 		return "error";
 	}
-	if (status === "exceeded") {
+	if (status === "breached") {
 		return "error";
 	}
 	return "warning";
diff --git a/client/src/locales/en.json b/client/src/locales/en.json
@@ -401,7 +401,7 @@
 				},
 				"status": {
 					"down": "down",
-					"exceeded": "threshold exceeded",
+					"breached": "threshold exceeded",
 					"initializing": "initializing",
 					"maintenance": "maintenance",
 					"paused": "paused",
diff --git a/server/src/db/migration/0005_renameBreachedToExceeded.ts b/server/src/db/migration/0005_renameBreachedToExceeded.ts
diff --git a/server/src/db/migration/index.ts b/server/src/db/migration/index.ts
@@ -2,7 +2,6 @@ import { migrateStatusWindowThreshold } from "./0001_migrateStatusWindowThreshol
 import { convertChecksToTimeSeries } from "./0002_convertChecksToTimeSeries.js";
 import { cleanupDuplicateMonitorStats } from "./0003_cleanupDuplicateMonitorStats.js";
 import { fixInfrastructureThresholds } from "./0004_fixInfrastructureThresholds.js";
-import { renameBreachedToExceeded } from "./0005_renameBreachedToExceeded.js";
 import MigrationModel from "../models/Migration.js";
 
 type MigrationEntry = {
@@ -15,7 +14,6 @@ const migrations: MigrationEntry[] = [
 	{ name: "0002_convertChecksToTimeSeries", execute: convertChecksToTimeSeries },
 	{ name: "0003_cleanupDuplicateMonitorStats", execute: cleanupDuplicateMonitorStats },
 	{ name: "0004_fixInfrastructureThresholds", execute: fixInfrastructureThresholds },
-	{ name: "0005_renameBreachedToExceeded", execute: renameBreachedToExceeded },
 ];
 
 const runMigrations = async (logger?: { info: Function; error: Function }) => {
diff --git a/server/src/repositories/monitors/MongoMonitorsRepository.ts b/server/src/repositories/monitors/MongoMonitorsRepository.ts
@@ -262,9 +262,9 @@ class MongoMonitorsRepository implements IMonitorsRepository {
 							$cond: [{ $eq: ["$status", "maintenance"] }, 1, 0],
 						},
 					},
-					exceededMonitors: {
+					breachedMonitors: {
 						$sum: {
-							$cond: [{ $eq: ["$status", "exceeded"] }, 1, 0],
+							$cond: [{ $eq: ["$status", "breached"] }, 1, 0],
 						},
 					},
 				},
@@ -281,7 +281,7 @@ class MongoMonitorsRepository implements IMonitorsRepository {
 				pausedMonitors: 0,
 				initializingMonitors: 0,
 				maintenanceMonitors: 0,
-				exceededMonitors: 0,
+				breachedMonitors: 0,
 			}
 		);
 	};
diff --git a/server/src/service/infrastructure/SuperSimpleQueue/SuperSimpleQueueHelper.ts b/server/src/service/infrastructure/SuperSimpleQueue/SuperSimpleQueueHelper.ts
@@ -440,14 +440,14 @@ export class SuperSimpleQueueHelper implements ISuperSimpleQueueHelper {
 			decision.shouldSendNotification = true;
 			decision.incidentReason = "status_down";
 			decision.notificationReason = "status_change";
-		} else if (monitor.status === "exceeded") {
+		} else if (monitor.status === "breached") {
 			// Hardware monitor exceeded thresholds
 			decision.shouldCreateIncident = true;
 			decision.shouldSendNotification = true;
 			decision.incidentReason = "threshold_breach";
 			decision.notificationReason = "threshold_breach";
-		} else if (monitor.status === "up" && (prevStatus === "down" || prevStatus === "exceeded")) {
-			// Monitor recovered from down or exceeded state
+		} else if (monitor.status === "up" && (prevStatus === "down" || prevStatus === "breached")) {
+			// Monitor recovered from down or breached state
 			decision.shouldResolveIncident = true;
 			decision.shouldSendNotification = true;
 			decision.notificationReason = "status_change";
diff --git a/server/src/service/infrastructure/statusService.ts b/server/src/service/infrastructure/statusService.ts
@@ -292,7 +292,7 @@ export class StatusService implements IStatusService {
 						temp: tempBreach,
 					};
 
-					// Update counters: decrement if exceeded, reset to 5 if not exceeded
+					// Update counters: decrement if breached, reset to 5 if not breached
 					if (cpuBreach) {
 						monitor.cpuAlertCounter = Math.max(0, monitor.cpuAlertCounter - 1);
 					} else {
@@ -321,23 +321,23 @@ export class StatusService implements IStatusService {
 					const anyCounterZero =
 						monitor.cpuAlertCounter === 0 || monitor.memoryAlertCounter === 0 || monitor.diskAlertCounter === 0 || monitor.tempAlertCounter === 0;
 
-					const anyThresholdExceeded = cpuBreach || memoryBreach || diskBreach || tempBreach;
+					const anyThresholdBreached = cpuBreach || memoryBreach || diskBreach || tempBreach;
 					const allThresholdsNormal = !cpuBreach && !memoryBreach && !diskBreach && !tempBreach;
 
-					// Update monitor status based on threshold exceeded state
+					// Update monitor status based on threshold breach state
 					if (newStatus !== "down") {
 						// Don't override "down" status - service unreachable takes precedence
 						// Check current monitor status, not newStatus for comparison
-						if (anyCounterZero && anyThresholdExceeded && monitor.status !== "exceeded") {
-							// Threshold exceeded: counter hit zero, change status to exceeded
-							newStatus = "exceeded";
+						if (anyCounterZero && anyThresholdBreached && monitor.status !== "breached") {
+							// Initial breach: counter hit zero, change status to breached
+							newStatus = "breached";
 							statusChanged = true;
-						} else if (anyCounterZero && anyThresholdExceeded && monitor.status === "exceeded") {
-							// Already exceeded, keep status but don't mark as changed
-							newStatus = "exceeded";
+						} else if (anyCounterZero && anyThresholdBreached && monitor.status === "breached") {
+							// Already breached, keep status but don't mark as changed
+							newStatus = "breached";
 							// statusChanged remains false
-						} else if (allThresholdsNormal && monitor.status === "exceeded") {
-							// All thresholds returned to normal, recover from exceeded state
+						} else if (allThresholdsNormal && monitor.status === "breached") {
+							// All thresholds returned to normal, recover from breached state
 							newStatus = "up";
 							statusChanged = true;
 						}
diff --git a/server/src/types/monitor.ts b/server/src/types/monitor.ts
@@ -9,7 +9,7 @@ export type MonitorType = (typeof MonitorTypes)[number];
 export const GeoCheckSupportedTypes: readonly MonitorType[] = ["http", "ping"] as const;
 export const supportsGeoCheck = (type: MonitorType): boolean => GeoCheckSupportedTypes.includes(type);
 
-export const MonitorStatuses = ["up", "down", "paused", "initializing", "maintenance", "exceeded"] as const;
+export const MonitorStatuses = ["up", "down", "paused", "initializing", "maintenance", "breached"] as const;
 export type MonitorStatus = (typeof MonitorStatuses)[number];
 
 export type MonitorMatchMethod = "equal" | "include" | "regex" | "";
@@ -64,7 +64,7 @@ export interface MonitorsSummary {
 	pausedMonitors: number;
 	initializingMonitors: number;
 	maintenanceMonitors: number;
-	exceededMonitors: number;
+	breachedMonitors: number;
 }
 
 export interface MonitorsWithChecksByTeamIdResult {

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ export const getStatusPalette = (status: MonitorStatus): PaletteKey => {`
`25`	`25`	`if (status === "down") {`
`26`	`26`	`return "error";`
`27`	`27`	`}`
`28`		`- if (status === "exceeded") {`
	`28`	`+ if (status === "breached") {`
`29`	`29`	`return "error";`
`30`	`30`	`}`
`31`	`31`	`return "warning";`