Convert exec_ calls to exec and remove compat checks

Note: This change breaks support for Qt4 and older versions of Qt5.
exec_ was a reserved keyword in python 2, its not in python 3. PyQt6 has
dropped support for exec_ and its deprecated in PySide6. Modern Qt5 supports both.

This requires disabling py2-3 compatibility checking as modernize doesn't
like using `exec` as a object property.

I'm also removing the compileall check as it's assumed that the linting
flake8/black checks will cover checking for syntax errors.

Author: MHendricks

.github/workflows/static-analysis-and-test.yml

@@ -35,10 +35,6 @@ jobs:
       - name: Format with black
         run: tox -e black
 
-      - name: Py 2 and 3 compatibility
-        run: tox -e modernize
-
-
   test:
     # We want to run on external PRs, but not on our own internal PRs as they'll
     # be run by the push to the branch. Without this if check, checks are

preditor/debug.py

@@ -190,7 +190,7 @@ def send_logger_error(self, exc_info):
             ConsolePrEdit._errorPrompted = True
             errorDialog = ErrorDialog(root_window())
             errorDialog.setText(exc_info)
-            errorDialog.exec_()
+            errorDialog.exec()
 
         # interruptted until dialog closed
         finally:

preditor/gui/dialog.py

@@ -140,7 +140,7 @@ def closeEvent(self, event):
             except TypeError:
                 pass
 
-    def exec_(self):
+    def exec(self):
         # do not use the DeleteOnClose attribute when executing a dialog as often times
         # a user will be accessing information from the dialog instance after it closes.
         # This function properly transfers ownership of the dialog instance back to
@@ -149,7 +149,7 @@ def exec_(self):
         self.setAttribute(Qt.WidgetAttribute.WA_DeleteOnClose, False)
 
         # execute the dialog
-        return QDialog.exec_(self)
+        return super().exec()
 
     def setGeometry(self, *args):
         """

preditor/gui/drag_tab_bar.py

@@ -54,7 +54,7 @@ def mouseMoveEvent(self, event):  # noqa: N802
         drag.setHotSpot(event_pos - pos_in_tab)
         cursor = QCursor(Qt.CursorShape.OpenHandCursor)
         drag.setDragCursor(cursor.pixmap(), Qt.DropAction.MoveAction)
-        action = drag.exec_(Qt.DropAction.MoveAction)
+        action = drag.exec(Qt.DropAction.MoveAction)
         # If the user didn't successfully add this to a new tab widget, restore
         # the tab to the original location.
         if action == Qt.DropAction.IgnoreAction:

preditor/gui/errordialog.py

@@ -84,7 +84,7 @@ def submitRequest(self):
         # If that failed, we will use a dialog to prompt for credentials.
         except ImpersonateError:
             dialog = RedmineLoginDialog(parent=self)
-            result = dialog.exec_()
+            result = dialog.exec()
             if result == QDialog.DialogCode.Accepted:
                 kwargs.update(
                     {

preditor/gui/loggerwindow.py

@@ -429,7 +429,7 @@ def setup_run_workbox(self):
 
     def openSetPreferredTextEditorDialog(self):
         dlg = SetTextEditorPathDialog(parent=self)
-        dlg.exec_()
+        dlg.exec()
 
     def focusToConsole(self):
         """Move focus to the console"""
@@ -810,7 +810,7 @@ def maybeDisplayDialog(self, dialog):
         if dialog.objectName() in self.dont_ask_again:
             return
 
-        dialog.exec_()
+        dialog.exec()
 
     def restartLogger(self):
         """Closes this PrEditor instance and starts a new process with the same

tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = modernize,begin,py{27,36,37,38,39,310,311},end,black,flake8
+envlist = begin,py{27,36,37,38,39,310,311},end,black,flake8
 skip_missing_interpreters = True
 skipsdist = True
 
@@ -25,17 +25,6 @@ commands =
 
     coverage run -m pytest {tty:--color=yes} {posargs:tests/}
 
-[testenv:modernize]
-# Test compatibility with python 2 and 3
-deps =
-    modernize
-commands =
-    # Check for python 3 compliance
-    python -m compileall -f -q -x \.tox|shared-venv .
-    # Note: `-f numliterals -f except -f dict_six` always report failure so we can't include them
-    # in this test.
-    python -m modernize -f print -f import -f basestring -f unicode_type --enforce ./preditor
-
 [testenv:begin]
 basepython = python3
 deps =