Implement TryFrom<Vec<T>> for ArrayVec<T, N>
#202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c410-f3r
commented
Oct 21, 2021
| use std::mem; | ||
| use arrayvec::CapacityError; | ||
|
|
||
| use std::collections::HashMap; |
Contributor
Author
There was a problem hiding this comment.
This import is only used inside test_string
Comment on lines
+21
to
+34
| #[cfg(not(feature="std"))] | ||
| extern crate alloc; | ||
|
|
||
| #[cfg(feature="serde")] | ||
| extern crate serde; | ||
|
|
||
| #[cfg(not(feature="std"))] | ||
| extern crate core as std; | ||
|
|
||
| #[cfg(feature="std")] | ||
| pub use std::vec::Vec as Vec; | ||
| #[cfg(not(feature="std"))] | ||
| pub use alloc::vec::Vec as Vec; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
It is possible to avoid all cfg by simply declaring extern crate alloc; regardless of no_std.
Contributor
Author
|
Unlike most extend-like methods, this implementation does not require |
Contributor
Author
|
Closing due to the lack of feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.