Skip to content

Commit 675e753

Browse files
alexeyvbmadcode
andauthored
refactor(skills): convert review-pr and audit-file-refs to bmad-os skills (#1732)
Move Raven PR review and file-ref audit from tools/ into .claude/skills/ as proper bmad-os skills with SKILL.md + prompts/ instructions.md split pattern. Strip XML tags from Raven content, promote sections to H2 headings. Delete originals from tools/. Co-authored-by: Brian <bmadcode@gmail.com>
1 parent 276fcb1 commit 675e753

File tree

5 files changed

+22
-19
lines changed

5 files changed

+22
-19
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
name: bmad-os-audit-file-refs
3+
description: Audit BMAD source files for file-reference convention violations using parallel Haiku subagents. Use when checking path references in workflow and task files.
4+
disable-model-invocation: true
5+
---
6+
7+
Read `prompts/instructions.md` and execute.

tools/audit-file-refs.md renamed to .claude/skills/bmad-os-audit-file-refs/prompts/instructions.md

File renamed without changes.

tools/maintainer/review-pr-README.md renamed to .claude/skills/bmad-os-review-pr/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ Adversarial code review for GitHub PRs. Works with any LLM agent.
66
77
## How It Works
88

9-
Point your agent at `review-pr.md` and ask it to review a specific PR:
9+
Use `/bmad-os-review-pr` to review a specific PR:
1010

11-
> "Read tools/maintainer/review-pr.md and apply it to PR #123"
11+
> "Use /bmad-os-review-pr to review PR #123"
1212
1313
The tool will:
1414

@@ -17,7 +17,7 @@ The tool will:
1717
3. Transform findings into professional tone
1818
4. Preview the review and ask before posting
1919

20-
See `review-pr.md` for full prompt structure, severity ratings, and sandboxing rules.
20+
See `prompts/instructions.md` for full prompt structure, severity ratings, and sandboxing rules.
2121

2222
## When to Use
2323

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
name: bmad-os-review-pr
3+
description: Adversarial PR review tool (Raven's Verdict). Cynical deep review transformed into professional engineering findings. Use when asked to review a PR.
4+
disable-model-invocation: true
5+
---
6+
7+
Read `prompts/instructions.md` and execute.

tools/maintainer/review-pr.md renamed to .claude/skills/bmad-os-review-pr/prompts/instructions.md

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22

33
A cynical adversarial review, transformed into cold engineering professionalism.
44

5-
<orientation>
6-
CRITICAL: Sandboxed Execution Rules
5+
## CRITICAL: Sandboxed Execution Rules
76

87
Before proceeding, you MUST verify:
98

@@ -14,9 +13,6 @@ Before proceeding, you MUST verify:
1413

1514
**If no explicit PR number/URL was provided, STOP immediately and ask:**
1615
"What PR number or URL should I review?"
17-
</orientation>
18-
19-
<preflight-checks>
2016

2117
## Preflight Checks
2218

@@ -97,9 +93,7 @@ gh pr diff {PR_NUMBER} [--repo {REPO}] --name-only | grep -E '\.(png|jpg|jpeg|gi
9793

9894
Store list of binary files to skip. Note them in final output.
9995

100-
</preflight-checks>
101-
102-
<adversarial-review>
96+
## Adversarial Review
10397

10498
### 1.1 Run Cynical Review
10599

@@ -130,9 +124,7 @@ Likely tag:
130124
- Add `[likely]` to findings with high confidence, e.g. with direct evidence
131125
- Sort findings by severity (Critical → Moderate → Minor), not by confidence
132126

133-
</adversarial-review>
134-
135-
<tone-transformation>
127+
## Tone Transformation
136128

137129
**Transform the cynical output into cold engineering professionalism.**
138130

@@ -177,9 +169,8 @@ Output format after transformation:
177169
_Review generated by Raven's Verdict. LLM-produced analysis - findings may be incorrect or lack context. Verify before acting._
178170
```
179171

180-
</tone-transformation>
172+
## Post Review
181173

182-
<post-review>
183174
### 3.1 Preview
184175

185176
Display the complete transformed review to the user.
@@ -231,12 +222,10 @@ Do NOT use heredocs or `echo` - Markdown code blocks will break shell parsing. U
231222

232223
Keep the temp file and inform user of location.
233224

234-
</post-review>
225+
## Notes
235226

236-
<notes>
237227
- The "cynical asshole" phase is internal only - never posted
238228
- Tone transform MUST happen before any external output
239229
- When in doubt, ask the user - never assume
240230
- If you're unsure about severity, err toward higher severity
241231
- If you're unsure about confidence, be honest and use Medium or Low
242-
</notes>

0 commit comments

Comments
 (0)