Skip to content

Commit 87e5b07

Browse files
alexeyvclaude
andcommitted
fix: polish remaining review findings (8-16)
- Update stale /bmad:core:tools:shard-doc command to /bmad-shard-doc - Fix 100vw scrollbar overflow: banner uses width:100%, html gets overflow-x:clip - Add :focus-visible ring to banner link for keyboard navigation - Use file.path instead of file.history[0] in rehype-markdown-links - Fix incomplete sentence in install-bmad.md - Drop unnecessary fetch-depth:0 from docs deploy workflow Co-Authored-By: Claude Opus 4.6 <[email protected]>
1 parent accacef commit 87e5b07

File tree

7 files changed

+24
-17
lines changed

7 files changed

+24
-17
lines changed

.github/workflows/docs.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ jobs:
2727
steps:
2828
- name: Checkout repository
2929
uses: actions/checkout@v4
30-
with:
31-
fetch-depth: 0
3230

3331
- name: Setup Node.js
3432
uses: actions/setup-node@v4

docs/how-to/install-bmad.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ sidebar:
77

88
Use the `npx bmad-method install` command to set up BMad in your project with your choice of modules and AI tools.
99

10-
If you want to use a non interactive installer and provide all install options on the command line, [this guide](../non-interactive-installation.md).
10+
If you want to use a non interactive installer and provide all install options on the command line, see [this guide](../non-interactive-installation.md).
1111

1212
## When to Use This
1313

docs/how-to/shard-large-documents.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ docs/
3939
### 1. Run the Shard-Doc Tool
4040

4141
```bash
42-
/bmad:core:tools:shard-doc
42+
/bmad-shard-doc
4343
```
4444

4545
### 2. Follow the Interactive Process

test/test-rehype-plugins.mjs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ function assert(condition, testName, errorMessage = '') {
5353
// ---------------------------------------------------------------------------
5454

5555
const CONTENT_DIR = '/project/src/content/docs';
56-
const STD_FILE = { history: ['/project/src/content/docs/guide/intro.md'] };
56+
const STD_FILE = { path: '/project/src/content/docs/guide/intro.md' };
5757
const STD_OPTS = { contentDir: CONTENT_DIR };
5858
const BASE = '/BMAD-METHOD/';
5959

@@ -350,17 +350,17 @@ function runTests() {
350350
}
351351

352352
{
353-
// No file history -> no processing
353+
// No file path -> no processing
354354
const tree = makeAnchorTree('sibling.md');
355-
transform(tree, { history: undefined }, STD_OPTS);
356-
assert(getHref(tree) === 'sibling.md', 'No file history -> no processing', `Got ${getHref(tree)}`);
355+
transform(tree, { path: undefined }, STD_OPTS);
356+
assert(getHref(tree) === 'sibling.md', 'No file path -> no processing', `Got ${getHref(tree)}`);
357357
}
358358

359359
{
360-
// Empty file history array -> no processing
360+
// Empty string path -> no processing
361361
const tree = makeAnchorTree('sibling.md');
362-
transform(tree, { history: [] }, STD_OPTS);
363-
assert(getHref(tree) === 'sibling.md', 'Empty file history array -> no processing', `Got ${getHref(tree)}`);
362+
transform(tree, { path: '' }, STD_OPTS);
363+
assert(getHref(tree) === 'sibling.md', 'Empty string path -> no processing', `Got ${getHref(tree)}`);
364364
}
365365

366366
{
@@ -387,7 +387,7 @@ function runTests() {
387387
{
388388
// No content dir + no contentDir option -> throws
389389
const tree = makeAnchorTree('sibling.md');
390-
const file = { history: ['/some/random/path/file.md'] };
390+
const file = { path: '/some/random/path/file.md' };
391391
let threw = false;
392392
let errorMsg = '';
393393
try {
@@ -431,7 +431,7 @@ function runTests() {
431431
{
432432
// Use a file two levels deep so ../../ still stays inside content root
433433
const deepFile = {
434-
history: ['/project/src/content/docs/guide/sub/intro.md'],
434+
path: '/project/src/content/docs/guide/sub/intro.md',
435435
};
436436
const tree = makeAnchorTree('../../root-level.md');
437437
transform(tree, deepFile, STD_OPTS);
@@ -484,7 +484,7 @@ function runTests() {
484484
{
485485
// Root index.md: file at content root
486486
const rootFile = {
487-
history: ['/project/src/content/docs/intro.md'],
487+
path: '/project/src/content/docs/intro.md',
488488
};
489489
const tree = makeAnchorTree('index.md');
490490
transform(tree, rootFile, STD_OPTS);

website/src/components/Banner.astro

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ const llmsFullUrl = `${getSiteUrl()}/llms-full.txt`;
1010

1111
<style>
1212
.ai-banner {
13-
width: 100vw; /* Full viewport width */
14-
margin-left: calc(-50vw + 50%); /* Center and break out of container */
13+
width: 100%;
1514
height: var(--ai-banner-height, 2.75rem);
1615
background: #334155;
1716
color: #cbd5e1;
@@ -40,6 +39,11 @@ const llmsFullUrl = `${getSiteUrl()}/llms-full.txt`;
4039
.ai-banner a:hover {
4140
text-decoration: underline;
4241
}
42+
.ai-banner a:focus-visible {
43+
outline: 2px solid #B9B9FF;
44+
outline-offset: 2px;
45+
border-radius: 2px;
46+
}
4347

4448
/* Match navbar padding at breakpoints */
4549
@media (min-width: 50rem) {

website/src/rehype-markdown-links.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export default function rehypeMarkdownLinks(options = {}) {
2626

2727
return (tree, file) => {
2828
// The current file's absolute path on disk, set by Astro's markdown pipeline
29-
const currentFilePath = file.history?.[0];
29+
const currentFilePath = file.path;
3030
if (!currentFilePath) return;
3131

3232
// Auto-detect content root: walk up from current file to find src/content/docs

website/src/styles/custom.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -339,6 +339,11 @@ button:hover {
339339
MISC ENHANCEMENTS
340340
============================================ */
341341

342+
/* Prevent horizontal scrollbar from full-viewport-width breakout elements (e.g. iframe) */
343+
html {
344+
overflow-x: clip;
345+
}
346+
342347
/* Smooth scrolling */
343348
@media (prefers-reduced-motion: no-preference) {
344349
html {

0 commit comments

Comments
 (0)