Added parameterized url-ing

Author: mackmarton

grade-management-new/GradeManagement.Server/Controllers/GitHubAppController.cs

@@ -15,8 +15,9 @@ namespace GradeManagement.Server.Controllers;
 public class GitHubAppController(IHttpClientFactory httpClientFactory) : ControllerBase
 {
     [HttpGet]
-    public async Task CreateGitHubApp([FromQuery] string code)
+    public async Task<IActionResult> CreateGitHubApp([FromQuery] string code)
     {
+        string appUrl = Environment.GetEnvironmentVariable("APP_URL");
         string keyVaultUrl = Environment.GetEnvironmentVariable("KEY_VAULT_URI");
         var client = new SecretClient(new Uri(keyVaultUrl), new DefaultAzureCredential());
         var httpClient = httpClientFactory.CreateClient();
@@ -36,6 +37,8 @@ await client.SetSecretAsync($"GitHubMonitorConfig--{gitHubApp.Owner.Login}--GitH
         await client.SetSecretAsync($"GitHubMonitorConfig--{gitHubApp.Owner.Login}--GitHubAppPrivateKey", pem);
         await client.SetSecretAsync($"GitHubMonitorConfig--{gitHubApp.Owner.Login}--GitHubWebhookSecret",
             gitHubApp.WebhookSecret);
+
+        return Redirect(appUrl);
     }
 
     public static string RemovePemFencing(string pem)

grade-management-new/GradeManagement.Shared/Dtos/GitHubManifest/GitHubAppManifest.cs

@@ -4,14 +4,20 @@ namespace GradeManagement.Shared.Dtos.GitHubManifest;
 
 public class GitHubAppManifest
 {
+    public GitHubAppManifest()
+    {
+        string appUrl = Environment.GetEnvironmentVariable("APP_URL");
+        RedirectUrl = $"{appUrl}api/github";
+    }
+
     [JsonPropertyName("name")]
     public string Name { get; set; } = "Ahk GitHub Monitor";
     [JsonPropertyName("url")]
     public string Url { get; set; } = "https://github.com/bmeaut/ahk-github-automation";
     [JsonPropertyName("hook_attributes")]
-    public HookAttributes HookAttributes { get; set; } = new HookAttributes();
+    public HookAttributes HookAttributes { get; set; }
     [JsonPropertyName("redirect_url")]
-    public string RedirectUrl { get; set; } = "https://app.mm-home.eu/api/github";
+    public string RedirectUrl { get; set; }
     [JsonPropertyName("callback_urls")]
     public List<string> CallbackUrls { get; set; } = new();
     /*[JsonPropertyName("setup_url")]

grade-management-new/GradeManagement.Shared/Dtos/GitHubManifest/HookAttributes.cs

@@ -4,8 +4,14 @@ namespace GradeManagement.Shared.Dtos.GitHubManifest;
 
 public class HookAttributes
 {
+    public HookAttributes()
+    {
+        string monitorUrl = Environment.GetEnvironmentVariable("MONITOR_URL");
+        Url = $"{monitorUrl}api/github-webhooks";
+    }
+
     [JsonPropertyName("url")]
-    public string Url { get; set; } = "https://monitor.mm-home.eu/api/github-webhooks";
+    public string Url { get; set; }
     [JsonPropertyName("active")]
     public bool Active { get; set; } = true;
 }