pnpm workspace root package should not require name (#590)

Author: bmish

lib/package.ts

@@ -34,7 +34,7 @@ export class Package {
   }
 
   get name() {
-    if (this.packageJson.workspaces && !this.packageJson.name) {
+    if (this.workspacePatterns.length > 0 && !this.packageJson.name) {
       return '(Root)';
     }
     if (!this.packageJson.name) {

test/fixtures/index.ts

@@ -40,6 +40,10 @@ export const FIXTURE_PATH_PACKAGE_MISSING_NAME = join(
   FIXTURE_PATH,
   'package-missing-name'
 );
+export const FIXTURE_PATH_WORKSPACE_PNPM_MISSING_NAME = join(
+  FIXTURE_PATH,
+  'workspace-pnpm-missing-name'
+);
 export const FIXTURE_PATH_INCONSISTENT_LOCAL_PACKAGE_VERSION = join(
   FIXTURE_PATH,
   'inconsistent-local-package-version'

test/fixtures/workspace-pnpm-missing-name/package.json

@@ -0,0 +1 @@
+{}

test/fixtures/workspace-pnpm-missing-name/packages/package1/package.json

@@ -0,0 +1,3 @@
+{
+    "name": "package1"
+}

test/fixtures/workspace-pnpm-missing-name/pnpm-workspace.yaml

@@ -0,0 +1,2 @@
+packages:
+  - packages

test/lib/package-test.ts

@@ -1,5 +1,8 @@
 import { Package } from '../../lib/package.js';
-import { FIXTURE_PATH_PACKAGE_MISSING_NAME } from '../fixtures/index.js';
+import {
+  FIXTURE_PATH_PACKAGE_MISSING_NAME,
+  FIXTURE_PATH_WORKSPACE_PNPM_MISSING_NAME,
+} from '../fixtures/index.js';
 import { join } from 'node:path';
 
 describe('Utils | Package', function () {
@@ -16,4 +19,20 @@ describe('Utils | Package', function () {
       )} missing \`name\``
     );
   });
+
+  it('uses (Root) with name-less workspace root package', function () {
+    const package_ = new Package(
+      FIXTURE_PATH_PACKAGE_MISSING_NAME,
+      FIXTURE_PATH_PACKAGE_MISSING_NAME
+    );
+    expect(package_.name).toStrictEqual('(Root)');
+  });
+
+  it('uses (Root) with name-less workspace root package (pnpm)', function () {
+    const package_ = new Package(
+      FIXTURE_PATH_WORKSPACE_PNPM_MISSING_NAME,
+      FIXTURE_PATH_WORKSPACE_PNPM_MISSING_NAME
+    );
+    expect(package_.name).toStrictEqual('(Root)');
+  });
 });