Merge pull request #159 from bmish/esm

Convert to ESM

Author: bmish

.eslintrc.js renamed to .eslintrc.cjs

@@ -14,6 +14,11 @@ module.exports = {
       tryExtensions: ['.js', '.json', '.node', '.ts', '.d.ts'],
     },
   },
+  rules: {
+    'import/extensions': 'off', // extensions now recommended in ESM
+
+    'node/no-missing-import': 'off', // bug with recognizing node: prefix https://github.com/mysticatea/eslint-plugin-node/issues/275
+  },
   overrides: [
     {
       files: ['test/**/*.js'],

bin/check-dependency-version-consistency.ts

@@ -2,15 +2,18 @@
 /* eslint node/shebang:"off" -- shebang needed so compiled code gets interpreted as JS */
 
 import { Command } from 'commander';
-import { readFileSync } from 'fs';
+import { readFileSync } from 'node:fs';
 import {
   calculateVersionsForEachDependency,
   calculateMismatchingVersions,
   filterOutIgnoredDependencies,
-} from '../lib/dependency-versions';
-import { mismatchingVersionsToOutputLines } from '../lib/output';
-import { join } from 'path';
+} from '../lib/dependency-versions.js';
+import { mismatchingVersionsToOutputLines } from '../lib/output.js';
+import { join, dirname } from 'node:path';
 import type { PackageJson } from 'type-fest';
+import { fileURLToPath } from 'node:url';
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
 
 function getCurrentPackageVersion(): string {
   const packageJson: PackageJson = JSON.parse(

lib/dependency-versions.ts

@@ -1,6 +1,6 @@
-import { readFileSync, existsSync } from 'fs';
+import { readFileSync, existsSync } from 'node:fs';
 import type { PackageJson } from 'type-fest';
-import { getPackageJsonPaths } from './workspace';
+import { getPackageJsonPaths } from './workspace.js';
 
 export type DependenciesToVersionsSeen = Map<
   string,

lib/fs.ts

@@ -1,4 +1,4 @@
-import { readdirSync } from 'fs';
+import { readdirSync } from 'node:fs';
 
 export function getDirectoriesInPath(path: string): string[] {
   return readdirSync(path, { withFileTypes: true })

lib/output.ts

@@ -1,4 +1,4 @@
-import type { MismatchingDependencyVersions } from './dependency-versions';
+import type { MismatchingDependencyVersions } from './dependency-versions.js';
 
 export function mismatchingVersionsToOutputLines(
   mismatchingDependencyVersions: MismatchingDependencyVersions

lib/workspace.ts

@@ -1,7 +1,7 @@
-import { join } from 'path';
-import { existsSync, readFileSync } from 'fs';
-import { getDirectoriesInPath } from './fs';
-import { flatMap } from './js';
+import { join } from 'node:path';
+import { existsSync, readFileSync } from 'node:fs';
+import { getDirectoriesInPath } from './fs.js';
+import { flatMap } from './js.js';
 import type { PackageJson } from 'type-fest';
 
 export function getPackageJsonPaths(root: string): string[] {

package.json

@@ -15,6 +15,7 @@
     "url": "https://github.com/bmish/check-dependency-version-consistency.git"
   },
   "license": "MIT",
+  "type": "module",
   "bin": {
     "check-dependency-version-consistency": "dist/bin/check-dependency-version-consistency.js"
   },
@@ -27,7 +28,7 @@
     "lint:types": "tsc",
     "prepublishOnly": "tsc",
     "release": "release-it",
-    "test": "nyc mocha -r ts-node/register 'test/**/*.ts'"
+    "test": "node --loader ts-node/esm node_modules/mocha/lib/cli/cli --extension ts --recursive test"
   },
   "nyc": {
     "branches": 100,

test/fixtures/index.ts

@@ -1,4 +1,7 @@
-import { join } from 'path';
+import { join, dirname } from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
 
 const FIXTURE_PATH = join(__dirname, '..', '/fixtures');
 

test/lib/dependency-versions.ts

@@ -3,15 +3,15 @@ import {
   calculateVersionsForEachDependency,
   calculateMismatchingVersions,
   filterOutIgnoredDependencies,
-} from '../../lib/dependency-versions';
-import { deepStrictEqual, throws } from 'assert';
+} from '../../lib/dependency-versions.js';
+import { deepStrictEqual, throws } from 'node:assert';
 import {
   FIXTURE_PATH_VALID,
   FIXTURE_PATH_INCONSISTENT_VERSIONS,
   FIXTURE_PATH_NO_PACKAGES,
   FIXTURE_PATH_NO_DEPENDENCIES,
   FIXTURE_PATH_PACKAGE_MISSING_PACKAGE_JSON,
-} from '../fixtures';
+} from '../fixtures/index.js';
 
 describe('Utils | dependency-versions', function () {
   describe('#calculateMismatchingVersions', function () {

test/lib/fs.ts

@@ -1,7 +1,7 @@
 import 'mocha'; // eslint-disable-line import/no-unassigned-import -- to get Mocha types to work
-import { getDirectoriesInPath } from '../../lib/fs';
-import { deepStrictEqual } from 'assert';
-import { FIXTURE_PATH_VALID } from '../fixtures';
+import { getDirectoriesInPath } from '../../lib/fs.js';
+import { deepStrictEqual } from 'node:assert';
+import { FIXTURE_PATH_VALID } from '../fixtures/index.js';
 
 describe('Utils | fs', function () {
   describe('#getDirectoriesInPath', function () {