more efficient tmp-dir

Author: otrok7

admin/class-bread-admin.php

@@ -230,11 +230,6 @@ function is_root_server_missing()
                 $url = admin_url('options-general.php?page=class-bread-admin.php');
                 echo "<p><a href='$url'>Settings</a></p>";
                 echo '</div>';
-            } else if (!$this->bread->temp_dir()) {
-                echo '<div id="message" class="error"><p>' . $this->bread->temp_dir() . ' temporary directory is not writable.</p>';
-                $url = admin_url('options-general.php?page=class-bread-admin.php');
-                echo "<p><a href='$url'>Settings</a></p>";
-                echo '</div>';
             }
         }
     }

includes/class-bread.php

@@ -93,6 +93,9 @@ public function bmlt(): Bread_Bmlt
     }
     public function temp_dir(): string
     {
+        if (empty($this->tmp_dir)) {
+            $this->tmp_dir = Bread::setup_temp_dir();
+        }
         return $this->tmp_dir;
     }
     public function getOption($name): mixed
@@ -337,7 +340,6 @@ public function __construct()
             $this->version = '2.8.0';
         }
         $this->plugin_name = 'bread';
-        $this->tmp_dir = $this->setup_temp_dir();
         $this->protocol = (strpos(strtolower(home_url()), "https") !== false ? "https" : "http") . "://";
         $this->bread_bmlt = new Bread_Bmlt($this);