fix env casing and api errors

Author: JohnDuprey

Modules/CIPPCore/Public/Authentication/New-CIPPAPIConfig.ps1

@@ -55,12 +55,13 @@ function New-CIPPAPIConfig {
                         enableAccessTokenIssuance = $false
                         enableIdTokenIssuance     = $true
                     }
-                    redirectUris          = @("https://$($ENV:Website_hostname)/.auth/login/aad/callback")
+                    redirectUris          = @("https://$($ENV:WEBSITE_HOSTNAME)/.auth/login/aad/callback")
                 }
             } | ConvertTo-Json -Depth 10 -Compress
 
             if ($PSCmdlet.ShouldProcess($AppName, 'Create API App')) {
                 Write-Information 'Creating app'
+                Write-Information $CreateBody
                 $APIApp = New-GraphPOSTRequest -uri 'https://graph.microsoft.com/v1.0/applications' -AsApp $true -NoAuthCheck $true -type POST -body $CreateBody
                 Write-Information 'Creating password'
                 $APIPassword = New-GraphPOSTRequest -uri "https://graph.microsoft.com/v1.0/applications/$($APIApp.id)/addPassword" -AsApp $true -NoAuthCheck $true -type POST -body "{`"passwordCredential`":{`"displayName`":`"Generated by API Setup`"}}"
@@ -118,9 +119,6 @@ function New-CIPPAPIConfig {
         $ErrorMessage = Get-CippException -Exception $_
         Write-Information ($ErrorMessage | ConvertTo-Json -Depth 10)
         Write-LogMessage -headers $Headers -API $APINAME -tenant 'None' -message "Failed to setup CIPP-API Access: $($ErrorMessage.NormalizedError) Linenumber: $($_.InvocationInfo.ScriptLineNumber)" -Sev 'Error' -LogData $ErrorMessage
-        return @{
-            Results = "Failed to setup CIPP-API Access: $($ErrorMessage.NormalizedError)"
-        }
-
+        throw "Failed to setup CIPP-API Access: $($ErrorMessage.NormalizedError)"
     }
 }

Modules/CIPPCore/Public/Entrypoints/HTTP Functions/CIPP/Settings/Invoke-ExecApiClient.ps1

@@ -50,7 +50,6 @@ function Invoke-ExecApiClient {
                     $AddUpdateSuccess = $true
                 } catch {
                     $AddedText = "Could not modify App Registrations. Check the CIPP documentation for API requirements. Error: $($_.Exception.Message)"
-                    $Body = $Body | Select-Object * -ExcludeProperty CIPPAPI
                 }
             }