Add error handling to group template parsing

Wrapped group template JSON parsing in a try/catch block to handle malformed data gracefully. Added a default value for missing groupType and improved logging for parse errors.

Author: JohnDuprey

Modules/CIPPCore/Public/Entrypoints/HTTP Functions/Identity/Administration/Groups/Invoke-ListGroupTemplates.ps1

@@ -13,35 +13,44 @@ function Invoke-ListGroupTemplates {
     $Table = Get-CippTable -tablename 'templates'
     $Filter = "PartitionKey eq 'GroupTemplate'"
     $Templates = (Get-CIPPAzDataTableEntity @Table -Filter $Filter) | ForEach-Object {
-        $data = $_.JSON | ConvertFrom-Json -ErrorAction SilentlyContinue
-        # Normalize groupType to camelCase for consistent frontend handling
-        # Handle both stored normalized values and legacy values
-        $normalizedGroupType = switch -Wildcard ($data.groupType) {
-            # Already normalized values (most common)
-            'dynamicdistribution' { 'dynamicDistribution'; break }
-            'azurerole' { 'azureRole'; break }
-            # Legacy values that might exist in stored templates
-            '*dynamicdistribution*' { 'dynamicDistribution'; break }
-            '*dynamic*' { 'dynamic'; break }
-            '*azurerole*' { 'azureRole'; break }
-            '*unified*' { 'm365'; break }
-            '*microsoft*' { 'm365'; break }
-            '*m365*' { 'm365'; break }
-            '*generic*' { 'generic'; break }
-            '*security*' { 'security'; break }
-            '*distribution*' { 'distribution'; break }
-            '*mail*' { 'distribution'; break }
-            default { $data.groupType }
-        }
+        try {
+            $data = $_.JSON | ConvertFrom-Json -ErrorAction SilentlyContinue
+            # Normalize groupType to camelCase for consistent frontend handling
+            # Handle both stored normalized values and legacy values
+
+            if (!$data.groupType) {
+                $data.groupType = 'generic'
+            }
+
+            $normalizedGroupType = switch -Wildcard ($data.groupType) {
+                # Already normalized values (most common)
+                'dynamicdistribution' { 'dynamicDistribution'; break }
+                'azurerole' { 'azureRole'; break }
+                # Legacy values that might exist in stored templates
+                '*dynamicdistribution*' { 'dynamicDistribution'; break }
+                '*dynamic*' { 'dynamic'; break }
+                '*azurerole*' { 'azureRole'; break }
+                '*unified*' { 'm365'; break }
+                '*microsoft*' { 'm365'; break }
+                '*m365*' { 'm365'; break }
+                '*generic*' { 'generic'; break }
+                '*security*' { 'security'; break }
+                '*distribution*' { 'distribution'; break }
+                '*mail*' { 'distribution'; break }
+                default { $data.groupType }
+            }
 
-        [PSCustomObject]@{
-            displayName     = $data.displayName
-            description     = $data.description
-            groupType       = $normalizedGroupType
-            membershipRules = $data.membershipRules
-            allowExternal   = $data.allowExternal
-            username        = $data.username
-            GUID            = $_.RowKey
+            [PSCustomObject]@{
+                displayName     = $data.displayName
+                description     = $data.description
+                groupType       = $normalizedGroupType
+                membershipRules = $data.membershipRules
+                allowExternal   = $data.allowExternal
+                username        = $data.username
+                GUID            = $_.RowKey
+            }
+        } catch {
+            Write-Information "Could not parse group template $($_.RowKey): $($_.Exception.Message)"
         }
     } | Sort-Object -Property displayName