fix: exo issues with calendars and bulk request

Author: JohnDuprey

Modules/CIPPCore/Public/Entrypoints/HTTP Functions/Email-Exchange/Administration/Invoke-ExecEditCalendarPermissions.ps1

@@ -1,6 +1,6 @@
 using namespace System.Net
 
-Function Invoke-ExecEditCalendarPermissions {
+function Invoke-ExecEditCalendarPermissions {
     <#
     .FUNCTIONALITY
         Entrypoint
@@ -16,9 +16,9 @@ Function Invoke-ExecEditCalendarPermissions {
 
     # Extract parameters from query or body
     $TenantFilter = $Request.Query.tenantFilter ?? $Request.Body.tenantFilter
-    $UserID = $Request.Query.UserID ?? $Request.Body.UserID
+    $UserID = $Request.Query.userid ?? $Request.Body.userid
     $UserToGetPermissions = $Request.Query.UserToGetPermissions ?? $Request.Body.UserToGetPermissions.value
-    $Permissions = @($Request.Query.Permissions) ?? @($Request.Body.Permissions.value)
+    $Permissions = $Request.Query.Permissions ?? $Request.Body.Permissions.value
     $FolderName = $Request.Query.FolderName ?? $Request.Body.FolderName
     $RemoveAccess = $Request.Query.RemoveAccess ?? $Request.Body.RemoveAccess.value
 
@@ -32,6 +32,8 @@ Function Invoke-ExecEditCalendarPermissions {
     } catch {
         $Result = $_.Exception.Message
         $StatusCode = [HttpStatusCode]::Forbidden
+        Write-Warning "Error in ExecEditCalendarPermissions: $($_.Exception.Message)"
+        Write-Information $_.InvocationInfo.PositionMessage
     }
 
     # Associate values to output bindings by calling 'Push-OutputBinding'.

Modules/CIPPCore/Public/GraphHelper/New-ExoBulkRequest.ps1

@@ -85,15 +85,17 @@ function New-ExoBulkRequest {
                 }
                 $BatchBodyJson = ConvertTo-Json -InputObject $BatchBodyObj -Depth 10
                 $Results = Invoke-RestMethod $BatchURL -ResponseHeadersVariable responseHeaders -Method POST -Body $BatchBodyJson -Headers $Headers -ContentType 'application/json; charset=utf-8'
-                $ReturnedData.AddRange(@($Results.responses))
+                foreach ($Response in $Results.responses) {
+                    $ReturnedData.Add($Response)
+                }
 
                 Write-Host "Batch #$($batches.IndexOf($batch) + 1) of $($batches.Count) processed"
             }
         } catch {
             # Error handling (omitted for brevity)
         }
 
-        Write-Information ($ReturnedHeaders | ConvertTo-Json -Depth 10)
+        #Write-Information ($responseHeaders | ConvertTo-Json -Depth 10)
 
         # Process the returned data
         if ($ReturnWithCommand) {
@@ -114,13 +116,14 @@ function New-ExoBulkRequest {
                     }
                     $body | Add-Member -MemberType NoteProperty -Name 'value' -Value $msg -Force
                 }
-                $resultValue = $body.value
-
-                if (-not $FinalData.ContainsKey($CmdletName)) {
-                    $FinalData[$CmdletName] = [System.Collections.Generic.List[object]]::new()
-                    $FinalData.$CmdletName.Add($resultValue)
-                } else {
-                    $FinalData.$CmdletName.Add($resultValue)
+                $resultValues = $body.value
+                foreach ($resultValue in $resultValues) {
+                    if (-not $FinalData.ContainsKey($CmdletName)) {
+                        $FinalData[$CmdletName] = [System.Collections.Generic.List[object]]::new()
+                        $FinalData.$CmdletName.Add($resultValue)
+                    } else {
+                        $FinalData.$CmdletName.Add($resultValue)
+                    }
                 }
             }
         } else {

Modules/CIPPCore/Public/Set-CIPPCalendarPermission.ps1

@@ -13,6 +13,7 @@ function Set-CIPPCalendarPermission {
     )
 
     try {
+
         # If a pretty logging name is not provided, use the ID instead
         if ([string]::IsNullOrWhiteSpace($LoggingName) -and $RemoveAccess) {
             $LoggingName = $RemoveAccess
@@ -25,6 +26,7 @@ function Set-CIPPCalendarPermission {
             AccessRights = @($Permissions)
             User         = $UserToGetPermissions
         }
+        
         if ($RemoveAccess) {
             if ($PSCmdlet.ShouldProcess("$UserID\$folderName", "Remove permissions for $LoggingName")) {
                 $null = New-ExoRequest -tenantid $TenantFilter -cmdlet 'Remove-MailboxFolderPermission' -cmdParams @{Identity = "$($UserID):\$folderName"; User = $RemoveAccess }
@@ -43,7 +45,9 @@ function Set-CIPPCalendarPermission {
             }
         }
     } catch {
-        $ErrorMessage = Get-CippException -Message $_
+        $ErrorMessage = Get-CippException -Exception $_
+        Write-Warning "Error changing calendar permissions $($_.Exception.Message)"
+        Write-Information $_.InvocationInfo.PositionMessage
         $Result = "Failed to set calendar permissions for $LoggingName on $UserID : $($ErrorMessage.NormalizedError)"
         Write-LogMessage -headers $Headers -API $APIName -tenant $TenantFilter -message $Result -sev Error -LogData $ErrorMessage
         throw $Result