Refactor Application Insights initialization and logging

Updated Get-ApplicationInsightsQuery.ps1 to check for $global:TelemetryClient instead of the connection string environment variable. Moved Enable-CippConsoleLogging calls into the TelemetryClient initialization blocks in profile.ps1 and removed redundant console logging enablement code.

Author: JohnDuprey

Modules/CIPPCore/Public/Get-ApplicationInsightsQuery.ps1

@@ -5,8 +5,8 @@ function Get-ApplicationInsightsQuery {
         [string]$Query
     )
 
-    if (!$env:APPLICATIONINSIGHTS_CONNECTION_STRING) {
-        throw 'Application Insights not enabled for this environment.'
+    if (!$global:TelemetryClient) {
+        throw 'Application Insights is not enabled for this instance.'
     }
 
     if ($env:MSI_SECRET) {

profile.ps1

@@ -23,11 +23,13 @@ if (-not $global:TelemetryClient) {
             $config = [Microsoft.ApplicationInsights.Extensibility.TelemetryConfiguration]::CreateDefault()
             $config.ConnectionString = $connectionString
             $global:TelemetryClient = [Microsoft.ApplicationInsights.TelemetryClient]::new($config)
+            Enable-CippConsoleLogging
             Write-Information 'TelemetryClient initialized with connection string'
         } elseif ($env:APPINSIGHTS_INSTRUMENTATIONKEY) {
             # Fall back to instrumentation key
             $global:TelemetryClient = [Microsoft.ApplicationInsights.TelemetryClient]::new()
             $global:TelemetryClient.InstrumentationKey = $env:APPINSIGHTS_INSTRUMENTATIONKEY
+            Enable-CippConsoleLogging
             Write-Information 'TelemetryClient initialized with instrumentation key'
         } else {
             Write-Warning 'No Application Insights connection string or instrumentation key found'
@@ -101,16 +103,6 @@ if (!$LastStartup -or $CurrentVersion -ne $LastStartup.Version) {
     Write-Host 'Cleared GitHub release notes cache to force refresh on version update.'
 }
 
-# Enable console logging to Application Insights
-if ($env:APPLICATIONINSIGHTS_CONNECTION_STRING) {
-    try {
-        Enable-CippConsoleLogging
-        Write-Information 'Console logging to Application Insights enabled'
-    } catch {
-        Write-Warning "Failed to enable console logging: $($_.Exception.Message)"
-    }
-}
-
 # Uncomment the next line to enable legacy AzureRm alias in Azure PowerShell.
 # Enable-AzureRmAlias