fix reporting

Author: KelvinTegelaar

Modules/CIPPCore/Public/Standards/Invoke-CIPPStandardMailboxRecipientLimits.ps1

@@ -69,8 +69,12 @@ function Invoke-CIPPStandardMailboxRecipientLimits {
     if ($null -ne $Mailboxes -and @($Mailboxes).Count -gt 0) {
         # Process mailboxes and categorize them based on their plan limits
         $MailboxResults = @($Mailboxes) | ForEach-Object {
-            $Mailbox = $_
 
+            $Mailbox = $_
+            #if the mailbox username contains a guid, we can assume it's a system mailbox and skip it
+            if ($Mailbox.UserPrincipalName -match '^[^@]+@[^.]+\.[^.]+$') {
+                return
+            }
             # Safe hashtable lookup - check if MailboxPlanId exists and is not null
             $Plan = $null
             if ($Mailbox.MailboxPlanId -and $MailboxPlanLookup.ContainsKey($Mailbox.MailboxPlanId)) {
@@ -83,8 +87,7 @@ function Invoke-CIPPStandardMailboxRecipientLimits {
                 # If mailbox has "Unlimited" set but has a plan, use the plan's limit as the current limit
                 $CurrentLimit = if ($Mailbox.RecipientLimits -eq 'Unlimited') {
                     $PlanMaxRecipients
-                }
-                else {
+                } else {
                     $Mailbox.RecipientLimits
                 }
 
@@ -96,15 +99,13 @@ function Invoke-CIPPStandardMailboxRecipientLimits {
                         PlanLimit    = $PlanMaxRecipients
                         PlanName     = $Plan.DisplayName
                     }
-                }
-                elseif ($CurrentLimit -ne $Settings.RecipientLimit) {
+                } elseif ($CurrentLimit -ne $Settings.RecipientLimit) {
                     [PSCustomObject]@{
                         Type    = 'ToUpdate'
                         Mailbox = $Mailbox
                     }
                 }
-            }
-            elseif ($Mailbox.RecipientLimits -ne $Settings.RecipientLimit) {
+            } elseif ($Mailbox.RecipientLimits -ne $Settings.RecipientLimit) {
                 [PSCustomObject]@{
                     Type    = 'ToUpdate'
                     Mailbox = $Mailbox
@@ -139,11 +140,11 @@ function Invoke-CIPPStandardMailboxRecipientLimits {
                 $MailboxChanges = $MailboxesToUpdate | ForEach-Object {
                     $CurrentLimit = if ($_.RecipientLimits -eq 'Unlimited') { 'Unlimited' } else { $_.RecipientLimits }
                     @{
-                        Identity = $_.Identity
-                        DisplayName = $_.DisplayName
+                        Identity           = $_.Identity
+                        DisplayName        = $_.DisplayName
                         PrimarySmtpAddress = $_.PrimarySmtpAddress
-                        CurrentLimit = $CurrentLimit
-                        NewLimit = $Settings.RecipientLimit
+                        CurrentLimit       = $CurrentLimit
+                        NewLimit           = $Settings.RecipientLimit
                     }
                 }
 
@@ -165,13 +166,11 @@ function Invoke-CIPPStandardMailboxRecipientLimits {
                 # Execute batch update
                 $null = New-ExoBulkRequest -tenantid $Tenant -cmdletArray $UpdateRequests
                 Write-LogMessage -API 'Standards' -tenant $Tenant -message "Successfully applied recipient limits to $($MailboxesToUpdate.Count) mailboxes" -sev Info
-            }
-            catch {
+            } catch {
                 $ErrorMessage = Get-CippException -Exception $_
                 Write-LogMessage -API 'Standards' -tenant $Tenant -message "Could not set recipient limits. $($ErrorMessage.NormalizedError)" -sev Error -LogData $ErrorMessage
             }
-        }
-        else {
+        } else {
             Write-LogMessage -API 'Standards' -tenant $Tenant -message "All mailboxes already have the correct recipient limit of $($Settings.RecipientLimit)" -sev Info
         }
     }
@@ -180,12 +179,11 @@ function Invoke-CIPPStandardMailboxRecipientLimits {
     if ($Settings.alert -eq $true) {
         if ($MailboxesToUpdate.Count -eq 0 -and $MailboxesWithPlanIssues.Count -eq 0) {
             Write-LogMessage -API 'Standards' -tenant $Tenant -message "All mailboxes have the correct recipient limit of $($Settings.RecipientLimit)" -sev Info
-        }
-        else {
+        } else {
             # Create structured alert data
             $AlertData = @{
-                RequestedLimit = $Settings.RecipientLimit
-                MailboxesToUpdate = @()
+                RequestedLimit          = $Settings.RecipientLimit
+                MailboxesToUpdate       = @()
                 MailboxesWithPlanIssues = @()
             }
 
@@ -197,11 +195,11 @@ function Invoke-CIPPStandardMailboxRecipientLimits {
                 $AlertData.MailboxesToUpdate = $MailboxesToUpdate | ForEach-Object {
                     $CurrentLimit = if ($_.RecipientLimits -eq 'Unlimited') { 'Unlimited' } else { $_.RecipientLimits }
                     @{
-                        Identity = $_.Identity
-                        DisplayName = $_.DisplayName
+                        Identity           = $_.Identity
+                        DisplayName        = $_.DisplayName
                         PrimarySmtpAddress = $_.PrimarySmtpAddress
-                        CurrentLimit = $CurrentLimit
-                        RequiredLimit = $Settings.RecipientLimit
+                        CurrentLimit       = $CurrentLimit
+                        RequiredLimit      = $Settings.RecipientLimit
                     }
                 }
                 # Add to alert objects list efficiently
@@ -214,10 +212,10 @@ function Invoke-CIPPStandardMailboxRecipientLimits {
             if ($MailboxesWithPlanIssues.Count -gt 0) {
                 $AlertData.MailboxesWithPlanIssues = $MailboxesWithPlanIssues | ForEach-Object {
                     @{
-                        Identity = $_.Identity
-                        CurrentLimit = $_.CurrentLimit
-                        PlanLimit = $_.PlanLimit
-                        PlanName = $_.PlanName
+                        Identity       = $_.Identity
+                        CurrentLimit   = $_.CurrentLimit
+                        PlanLimit      = $_.PlanLimit
+                        PlanName       = $_.PlanName
                         RequestedLimit = $Settings.RecipientLimit
                     }
                 }
@@ -249,8 +247,7 @@ function Invoke-CIPPStandardMailboxRecipientLimits {
 
         if ($MailboxesToUpdate.Count -eq 0 -and $MailboxesWithPlanIssues.Count -eq 0) {
             $FieldValue = $true
-        }
-        else {
+        } else {
             $FieldValue = $ReportData
         }
         Set-CIPPStandardsCompareField -FieldName 'standards.MailboxRecipientLimits' -FieldValue $FieldValue -Tenant $Tenant