improve CA speeds

Author: KelvinTegelaar

Modules/CIPPCore/Public/New-CIPPBackupTask.ps1

@@ -43,10 +43,12 @@ function New-CIPPBackupTask {
         }
         'ca' {
             Measure-CippTask -TaskName 'ConditionalAccess' -EventName 'CIPP.BackupCompleted' -Script {
+                $preloadedUsers = New-GraphGetRequest -uri "https://graph.microsoft.com/beta/users?`$top=999&`$select=displayName,id" -tenantid $TenantFilter
+                $preloadedGroups = New-GraphGetRequest -uri "https://graph.microsoft.com/beta/groups?`$top=999&`$select=displayName,id" -tenantid $TenantFilter
                 $Policies = New-GraphGetRequest -uri 'https://graph.microsoft.com/beta/conditionalAccess/policies?$top=999' -tenantid $TenantFilter -AsApp $true
                 foreach ($policy in $policies) {
                     try {
-                        New-CIPPCATemplate -TenantFilter $TenantFilter -JSON $policy
+                        New-CIPPCATemplate -TenantFilter $TenantFilter -JSON $policy -preloadedUsers $preloadedUsers -preloadedGroups $preloadedGroups
                     } catch {
                         "Failed to create a template of the Conditional Access Policy with ID: $($policy.id). Error: $($_.Exception.Message)"
                     }

Modules/CIPPCore/Public/New-CIPPCATemplate.ps1

@@ -4,15 +4,25 @@ function New-CIPPCATemplate {
         $TenantFilter,
         $JSON,
         $APIName = 'Add CIPP CA Template',
-        $Headers
+        $Headers,
+        $preloadedUsers,
+        $preloadedGroups
     )
 
     $JSON = ([pscustomobject]$JSON) | ForEach-Object {
         $NonEmptyProperties = $_.psobject.Properties | Where-Object { $null -ne $_.Value } | Select-Object -ExpandProperty Name
         $_ | Select-Object -Property $NonEmptyProperties
     }
-    $users = (New-GraphGetRequest -uri "https://graph.microsoft.com/beta/users?`$top=999&`$select=displayName,id" -tenantid $TenantFilter)
-    $groups = (New-GraphGetRequest -uri "https://graph.microsoft.com/beta/groups?`$top=999&`$select=displayName,id" -tenantid $TenantFilter)
+    if ($preloadedUsers) {
+        $users = $preloadedUsers
+    } else {
+        $users = (New-GraphGetRequest -uri "https://graph.microsoft.com/beta/users?`$top=999&`$select=displayName,id" -tenantid $TenantFilter)
+    }
+    if ($preloadedGroups) {
+        $groups = $preloadedGroups
+    } else {
+        $groups = (New-GraphGetRequest -uri "https://graph.microsoft.com/beta/groups?`$top=999&`$select=displayName,id" -tenantid $TenantFilter)
+    }
     $includelocations = New-Object System.Collections.ArrayList
     $IncludeJSON = foreach ($Location in $JSON.conditions.locations.includeLocations) {
         $locationinfo = New-GraphGetRequest -uri 'https://graph.microsoft.com/beta/identity/conditionalAccess/namedLocations' -tenantid $TenantFilter | Where-Object -Property id -EQ $location | Select-Object * -ExcludeProperty id, *time*