Skip to content

Commit 8cac674

Browse files
authored
Merge pull request #642 from KelvinTegelaar/dev
[pull] dev from KelvinTegelaar:dev
2 parents abd2a77 + a0203a8 commit 8cac674

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Modules/CIPPCore/Public/New-CIPPCAPolicy.ps1

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,12 @@ function New-CIPPCAPolicy {
144144
if (($JSONobj.conditions.applications.includeApplications -and $JSONobj.conditions.applications.includeApplications -notcontains 'All') -or ($JSONobj.conditions.applications.excludeApplications -and $JSONobj.conditions.applications.excludeApplications -notcontains 'All')) {
145145
$AllServicePrincipals = New-GraphGETRequest -uri 'https://graph.microsoft.com/v1.0/servicePrincipals?$select=appId' -tenantid $TenantFilter -asApp $true
146146

147+
$ReservedApplicationNames = @('none', 'All', 'Office365', 'MicrosoftAdminPortals')
148+
147149
if ($JSONobj.conditions.applications.excludeApplications -and $JSONobj.conditions.applications.excludeApplications -notcontains 'All') {
148150
$ValidExclusions = [system.collections.generic.list[string]]::new()
149151
foreach ($appId in $JSONobj.conditions.applications.excludeApplications) {
150-
if ($AllServicePrincipals.appId -contains $appId) {
152+
if ($AllServicePrincipals.appId -contains $appId -or $ReservedApplicationNames -contains $appId) {
151153
$ValidExclusions.Add($appId)
152154
}
153155
}
@@ -156,7 +158,7 @@ function New-CIPPCAPolicy {
156158
if ($JSONobj.conditions.applications.includeApplications -and $JSONobj.conditions.applications.includeApplications -notcontains 'All') {
157159
$ValidInclusions = [system.collections.generic.list[string]]::new()
158160
foreach ($appId in $JSONobj.conditions.applications.includeApplications) {
159-
if ($AllServicePrincipals.appId -contains $appId) {
161+
if ($AllServicePrincipals.appId -contains $appId -or $ReservedApplicationNames -contains $appId) {
160162
$ValidInclusions.Add($appId)
161163
}
162164
}

0 commit comments

Comments
 (0)