fix: improve error handling and logging in Invoke-RemoveScheduledItem function

Author: kris6673

Modules/CIPPCore/Public/Entrypoints/HTTP Functions/CIPP/Scheduler/Invoke-RemoveScheduledItem.ps1

@@ -4,32 +4,41 @@ function Invoke-RemoveScheduledItem {
         Entrypoint,AnyTenant
     .ROLE
         CIPP.Scheduler.ReadWrite
+    .DESCRIPTION
+        Removes a scheduled item from CIPP's scheduler.
     #>
     [CmdletBinding()]
     param($Request, $TriggerMetadata)
 
-    $APIName = 'RemoveScheduledItem'
-    $User = $Request.Headers
+    $APIName = $Request.Params.CIPPEndpoint
+    $Headers = $Request.Headers
 
     $RowKey = $Request.Query.id ? $Request.Query.id : $Request.Body.id
     $task = @{
         RowKey       = $RowKey
         PartitionKey = 'ScheduledTask'
     }
-    $Table = Get-CIPPTable -TableName 'ScheduledTasks'
-    Remove-AzDataTableEntity -Force @Table -Entity $task
+    try {
+        $Table = Get-CIPPTable -TableName 'ScheduledTasks'
+        Remove-AzDataTableEntity -Force @Table -Entity $task
 
-    $DetailTable = Get-CIPPTable -TableName 'ScheduledTaskDetails'
-    $Details = Get-CIPPAzDataTableEntity @DetailTable -Filter "PartitionKey eq '$($RowKey)'" -Property RowKey, PartitionKey, ETag
+        $DetailTable = Get-CIPPTable -TableName 'ScheduledTaskDetails'
+        $Details = Get-CIPPAzDataTableEntity @DetailTable -Filter "PartitionKey eq '$($RowKey)'" -Property RowKey, PartitionKey, ETag
 
-    if ($Details) {
-        Remove-AzDataTableEntity -Force @DetailTable -Entity $Details
-    }
+        if ($Details) {
+            Remove-AzDataTableEntity -Force @DetailTable -Entity $Details
+        }
 
-    Write-LogMessage -Headers $User -API $APINAME -message "Task removed: $($task.RowKey)" -Sev 'Info'
+        Write-LogMessage -Headers $Headers -API $APIName -message "Task removed: $($task.RowKey)" -Sev 'Info'
+        $StatusCode = [HttpStatusCode]::OK
+    } catch {
+        $ErrorMessage = Get-CippException -Exception $_
+        Write-LogMessage -Headers $Headers -API $APIName -message "Failed to remove task: $($task.RowKey). $($ErrorMessage.NormalizedError)" -Sev 'Error' -LogData $ErrorMessage
+        $StatusCode = [HttpStatusCode]::BadRequest
+    }
 
     return ([HttpResponseContext]@{
-            StatusCode = [HttpStatusCode]::OK
+            StatusCode = $StatusCode
             Body       = @{ Results = 'Task removed successfully.' }
         })