Skip to content

Commit ebfd5ef

Browse files
committed
Update CippEntrypoints.psm1
1 parent 7fdce16 commit ebfd5ef

File tree

1 file changed

+7
-13
lines changed

1 file changed

+7
-13
lines changed

Modules/CippEntrypoints/CippEntrypoints.psm1

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -227,14 +227,7 @@ function Receive-CippOrchestrationTrigger {
227227
$Output = $Output | Where-Object { $_.GetType().Name -eq 'ActivityInvocationTask' }
228228
if (($Output | Measure-Object).Count -gt 0) {
229229
Write-Information "Waiting for ($($Output.Count)) activity functions to complete..."
230-
$Results = $Output | ForEach-Object {
231-
$Task = $_
232-
try {
233-
Wait-ActivityFunction -Task $Task
234-
} catch {
235-
Write-Warning "Error waiting for activity function: $($_.Exception.Message)"
236-
}
237-
}
230+
$Results = Wait-ActivityFunction -Task @($Output)
238231
} else {
239232
$Results = @()
240233
}
@@ -340,11 +333,12 @@ function Receive-CippActivityTrigger {
340333

341334
try {
342335
Write-Verbose "Activity starting Function: $FunctionName."
343-
$ActivityStatus = 'Success'
336+
344337
# Wrap the function execution with telemetry
345338
$Output = Measure-CippTask -TaskName $taskName -Metadata $metadata -Script {
346339
Invoke-Command -ScriptBlock { & $FunctionName -Item $Item }
347340
}
341+
$Status = 'Completed'
348342

349343
Write-Verbose "Activity completed Function: $FunctionName."
350344
if ($TaskStatus) {
@@ -353,7 +347,7 @@ function Receive-CippActivityTrigger {
353347
}
354348
} catch {
355349
$ErrorMsg = $_.Exception.Message
356-
$ActivityStatus = 'Failed'
350+
$Status = 'Failed'
357351
if ($TaskStatus) {
358352
$QueueTask.Status = 'Failed'
359353
$QueueTask.Message = $ErrorMsg
@@ -362,15 +356,15 @@ function Receive-CippActivityTrigger {
362356
}
363357
} else {
364358
$ErrorMsg = 'Function not provided'
365-
$ActivityStatus = 'Failed'
359+
$Status = 'Failed'
366360
if ($TaskStatus) {
367361
$QueueTask.Status = 'Failed'
368362
$null = Set-CippQueueTask @QueueTask
369363
}
370364
}
371365
} catch {
372366
Write-Error "Error in Receive-CippActivityTrigger: $($_.Exception.Message)"
373-
$ActivityStatus = 'Failed'
367+
$Status = 'Failed'
374368
if ($TaskStatus) {
375369
$QueueTask.Status = 'Failed'
376370
$null = Set-CippQueueTask @QueueTask
@@ -381,7 +375,7 @@ function Receive-CippActivityTrigger {
381375
if ($null -ne $Output -and $Output -ne '') {
382376
return $Output
383377
} else {
384-
return "Activity '$($Item.Command)' ended with status: $ActivityStatus."
378+
return "Activity function ended with status $($Status)."
385379
}
386380
}
387381

0 commit comments

Comments
 (0)