Fix: error handling in Get-GraphToken to fix "Conversion from JSON failed with error: Unexpected character encountered while parsing value: R. Path '', line 0, position 0" error

kris6673 · kris6673 · commit ed5be4d56d40 · 2025-10-08T23:10:57.000+02:00
diff --git a/Modules/CIPPCore/Public/GraphHelper/Get-GraphToken.ps1 b/Modules/CIPPCore/Public/GraphHelper/Get-GraphToken.ps1
@@ -95,10 +95,14 @@ function Get-GraphToken($tenantid, $scope, $AsApp, $AppID, $AppSecret, $refreshT
             }
         }
         $Tenant.LastGraphError = if ( $_.ErrorDetails.Message) {
-            $msg = $_.ErrorDetails.Message | ConvertFrom-Json
-            "$($msg.error):$($msg.error_description)"
+            if (Test-Json $_.ErrorDetails.Message -ErrorAction SilentlyContinue) {
+                $msg = $_.ErrorDetails.Message | ConvertFrom-Json
+                "$($msg.error):$($msg.error_description)"
+            } else {
+                "$($_.ErrorDetails.Message)"
+            }
         } else {
-            $_.Exception.message
+            $_.Exception.Message
         }
         $Tenant.GraphErrorCount++
 

Original file line number	Diff line number	Diff line change
`@@ -95,10 +95,14 @@ function Get-GraphToken($tenantid, $scope, $AsApp, $AppID, $AppSecret, $refreshT`
`95`	`95`	`}`
`96`	`96`	`}`
`97`	`97`	`$Tenant.LastGraphError = if ( $_.ErrorDetails.Message) {`
`98`		`- $msg = $_.ErrorDetails.Message \| ConvertFrom-Json`
`99`		`- "$($msg.error):$($msg.error_description)"`
	`98`	`+ if (Test-Json $_.ErrorDetails.Message -ErrorAction SilentlyContinue) {`
	`99`	`+ $msg = $_.ErrorDetails.Message \| ConvertFrom-Json`
	`100`	`+ "$($msg.error):$($msg.error_description)"`
	`101`	`+ } else {`
	`102`	`+ "$($_.ErrorDetails.Message)"`
	`103`	`+ }`
`100`	`104`	`} else {`
`101`		`- $_.Exception.message`
	`105`	`+ $_.Exception.Message`
`102`	`106`	`}`
`103`	`107`	`$Tenant.GraphErrorCount++`
`104`	`108`