Skip to content

Commit fa20803

Browse files
committed
audit log tweaks
1 parent 49b6099 commit fa20803

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

Modules/CIPPCore/Public/Webhooks/Test-CIPPAuditLogRules.ps1

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ function Test-CIPPAuditLogRules {
6363
$Data = $AuditRecord.auditData | Select-Object *, CIPPAction, CIPPClause, CIPPGeoLocation, CIPPBadRepIP, CIPPHostedIP, CIPPIPDetected, CIPPLocationInfo, CIPPExtendedProperties, CIPPDeviceProperties, CIPPParameters, CIPPModifiedProperties, AuditRecord -ErrorAction SilentlyContinue
6464
try {
6565
if ($Data.ExtendedProperties) {
66-
$Data.CIPPExtendedProperties = ($Data.ExtendedProperties | ConvertTo-Json)
66+
$Data.CIPPExtendedProperties = ($Data.ExtendedProperties | ConvertTo-Json -Compress)
6767
$Data.ExtendedProperties | ForEach-Object {
6868
if ($_.Value -in $ExtendedPropertiesIgnoreList) {
6969
#write-warning "No need to process this operation as its in our ignore list. Some extended information: $($data.operation):$($_.Value) - $($TenantFilter)"
@@ -73,15 +73,15 @@ function Test-CIPPAuditLogRules {
7373
}
7474
}
7575
if ($Data.DeviceProperties) {
76-
$Data.CIPPDeviceProperties = ($Data.DeviceProperties | ConvertTo-Json)
76+
$Data.CIPPDeviceProperties = ($Data.DeviceProperties | ConvertTo-Json -Compress)
7777
$Data.DeviceProperties | ForEach-Object { $Data | Add-Member -NotePropertyName $_.Name -NotePropertyValue $_.Value -Force -ErrorAction SilentlyContinue }
7878
}
7979
if ($Data.parameters) {
80-
$Data.CIPPParameters = ($Data.parameters | ConvertTo-Json)
80+
$Data.CIPPParameters = ($Data.parameters | ConvertTo-Json -Compress)
8181
$Data.parameters | ForEach-Object { $Data | Add-Member -NotePropertyName $_.Name -NotePropertyValue $_.Value -Force -ErrorAction SilentlyContinue }
8282
}
8383
if ($Data.ModifiedProperties) {
84-
$Data.CIPPModifiedProperties = ($Data.ModifiedProperties | ConvertTo-Json)
84+
$Data.CIPPModifiedProperties = ($Data.ModifiedProperties | ConvertTo-Json -Compress)
8585
try {
8686
$Data.ModifiedProperties | ForEach-Object { $Data | Add-Member -NotePropertyName "$($_.Name)" -NotePropertyValue "$($_.NewValue)" -Force -ErrorAction SilentlyContinue }
8787
} catch {
@@ -146,7 +146,7 @@ function Test-CIPPAuditLogRules {
146146
Hosting = "$hosting"
147147
ASName = "$ASName"
148148
}
149-
$HasLocationData = $true
149+
150150
try {
151151
$null = Add-CIPPAzDataTableEntity @LocationTable -Entity $LocationInfo -Force
152152
} catch {
@@ -158,11 +158,13 @@ function Test-CIPPAuditLogRules {
158158
$Data.CIPPBadRepIP = $Proxy
159159
$Data.CIPPHostedIP = $hosting
160160
$Data.CIPPIPDetected = $IP
161-
$Data.CIPPLocationInfo = ($Location | ConvertTo-Json)
162-
$Data.AuditRecord = ($RootProperties | ConvertTo-Json)
161+
$Data.CIPPLocationInfo = ($Location | ConvertTo-Json -Compress)
162+
$HasLocationData = $true
163163
}
164164
}
165-
$Data | Select-Object *, @{n = 'HasLocationData'; exp = { $HasLocationData } } -ExcludeProperty ExtendedProperties, DeviceProperties, parameters
165+
$Data | Select-Object *,
166+
@{n = 'HasLocationData'; exp = { $HasLocationData } },
167+
@{n = 'AuditRecord'; exp = { $RootProperties | ConvertTo-Json -Compress } } -ExcludeProperty ExtendedProperties, DeviceProperties, parameters
166168
} catch {
167169
#write-warning "Audit log: Error processing data: $($_.Exception.Message)`r`n$($_.InvocationInfo.PositionMessage)"
168170
Write-LogMessage -API 'Webhooks' -message 'Error Processing Audit Log Data' -LogData (Get-CippException -Exception $_) -sev Error -tenant $TenantFilter
@@ -193,7 +195,7 @@ function Test-CIPPAuditLogRules {
193195
$CIPPClause = [System.Collections.Generic.List[string]]::new()
194196
$AddedLocationCondition = $false
195197
foreach ($condition in $conditions) {
196-
if ($condition.Input.value -eq 'CIPPGeoLocation' -and !$AddedLocationCondition) {
198+
if ($condition.Property.value -eq 'CIPPGeoLocation' -and !$AddedLocationCondition) {
197199
$conditionsString.Add("`$_.HasLocationData -eq `$true")
198200
$CIPPClause.Add('HasLocationData is true')
199201
$AddedLocationCondition = $true

0 commit comments

Comments
 (0)